[GitHub] eolivelli commented on a change in pull request #521: Issue 520: Add more http endpoint

[gi...@git.apache.org]

eolivelli commented on a change in pull request #521: Issue 520: Add more http endpoint
URL: https://github.com/apache/bookkeeper/pull/521#discussion_r140982513
 
 

 ##########
 File path: bookkeeper-http/http-server/src/main/java/org/apache/bookkeeper/http/AbstractHttpHandlerFactory.java
 ##########
 @@ -0,0 +1,135 @@
+/**
+ *
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ *
+ */
+package org.apache.bookkeeper.http;
+
+/**
+ * Abstract handler factory which provide interface
+ * to create handlers for bookkeeper http endpoints.
+ */
+public abstract class AbstractHttpHandlerFactory<Handler> {
+    private HttpServiceProvider httpServiceProvider;
+
+    public AbstractHttpHandlerFactory(HttpServiceProvider httpServiceProvider) {
+        this.httpServiceProvider = httpServiceProvider;
+    }
+
+    public HttpServiceProvider getHttpServiceProvider() {
+        return httpServiceProvider;
+    }
+
+    /**
+     * Create a handler for heartbeat api.
+     */
+    public abstract Handler newHeartbeatHandler();
 
 Review comment:
   Idea:
   can you evaluate to have a single method
   newHandler(enum ApiType)
   we will have a more extensible API for the future
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services