You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2022/08/31 12:35:46 UTC
[GitHub] [maven-jxr] sman-81 opened a new pull request, #76: Remove dependency org.apache.commons:commons-lang3
sman-81 opened a new pull request, #76:
URL: https://github.com/apache/maven-jxr/pull/76
The project depended on commons-lang3 for its `StringUtils.replace` method only, which is a null-safe alternative to `String.replace`.
Review of StringUtils usage shows that affected variables cannot be null. Thus the dependency can be replaced by core Java.
Following this checklist to help us incorporate your contribution quickly and easily:
- [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/browse/JXR) filed
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
- [x] Each commit in the pull request should have a meaningful subject line and body.
- [x] Format the pull request title like `[JXR-XXX] - Fixes bug in ApproximateQuantiles`,
where you replace `JXR-XXX` with the appropriate JIRA issue. Best practice
is to use the JIRA issue title in the pull request title and in the first line of the
commit message.
- [x] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
- [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
- [x] You have run the integration tests successfully (`mvn -Prun-its clean verify`).
If your pull request is about ~20 lines of code you don't need to sign an
[Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf) if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
you have to acknowledge this by using the following check-box.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
- [ ] In any other case, please file an [Apache Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jxr] slawekjaranowski merged pull request #76: [JXR-176] Remove dependency org.apache.commons:commons-lang3
Posted by GitBox <gi...@apache.org>.
slawekjaranowski merged PR #76:
URL: https://github.com/apache/maven-jxr/pull/76
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jxr] sman-81 commented on pull request #76: Remove dependency org.apache.commons:commons-lang3
Posted by GitBox <gi...@apache.org>.
sman-81 commented on PR #76:
URL: https://github.com/apache/maven-jxr/pull/76#issuecomment-1278585157
Hi @slawekjaranowski hope you are doing great. Could you look at my PR and hopefully merge?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jxr] sman-81 commented on pull request #76: [JXR-176] Remove dependency org.apache.commons:commons-lang3
Posted by GitBox <gi...@apache.org>.
sman-81 commented on PR #76:
URL: https://github.com/apache/maven-jxr/pull/76#issuecomment-1279934449
Hi @slawekjaranowski,
Thanks again for your feedback.
Pull request rebased to master, merge conflicts resolved, issue [JXR-176](https://issues.apache.org/jira/browse/JXR-176) created. Please re-review.
cheers,
Markus
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-jxr] slawekjaranowski commented on pull request #76: Remove dependency org.apache.commons:commons-lang3
Posted by GitBox <gi...@apache.org>.
slawekjaranowski commented on PR #76:
URL: https://github.com/apache/maven-jxr/pull/76#issuecomment-1279908923
Please resolve conflicts.
For such PR jira issue will be appreciated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org