You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zookeeper.apache.org by iv...@apache.org on 2012/12/14 15:14:55 UTC

svn commit: r1421875 - in /zookeeper/bookkeeper/trunk: CHANGES.txt bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java

Author: ivank
Date: Fri Dec 14 14:14:53 2012
New Revision: 1421875

URL: http://svn.apache.org/viewvc?rev=1421875&view=rev
Log:
BOOKKEEPER-504: Fix findbugs warning in PendingReadOp (fpj via ivank)

Modified:
    zookeeper/bookkeeper/trunk/CHANGES.txt
    zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java

Modified: zookeeper/bookkeeper/trunk/CHANGES.txt
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/CHANGES.txt?rev=1421875&r1=1421874&r2=1421875&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/CHANGES.txt (original)
+++ zookeeper/bookkeeper/trunk/CHANGES.txt Fri Dec 14 14:14:53 2012
@@ -452,6 +452,8 @@ Release 4.1.0 - 2012-06-07
 
         BOOKKEEPER-408: BookieReadWriteTest will enter the endless loop and will not leave out (ivank)
 
+	BOOKKEEPER-504: Fix findbugs warning in PendingReadOp (fpj via ivank)
+
       hedwig-client/
 
         BOOKKEEPER-217: NPE in hedwig client when enable DEBUG (sijie via ivank)

Modified: zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java
URL: http://svn.apache.org/viewvc/zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java?rev=1421875&r1=1421874&r2=1421875&view=diff
==============================================================================
--- zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java (original)
+++ zookeeper/bookkeeper/trunk/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/PendingReadOp.java Fri Dec 14 14:14:53 2012
@@ -192,7 +192,6 @@ class PendingReadOp implements Enumerati
                 ++numMissedEntryReads;
             }
 
-            int bookieIndex = lh.distributionSchedule.getWriteSet(entryId).get(nextReplicaIndexToReadFrom - 1);
             LOG.error(errMsg + " while reading entry: " + entryId + " ledgerId: " + lh.ledgerId + " from bookie: "
                       + host);