You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Marc Speck <ma...@gmail.com> on 2008/09/02 15:59:50 UTC
Minor bug in SimpleWebDavServlet
When PathInfo is null or "/", a response is already created and it makes no
sense to call super.service() anymore:
Index: SimpleWebDavServlet.java
===================================================================
--- SimpleWebDavServlet.java (revision 691120)
+++ SimpleWebDavServlet.java (working copy)
@@ -85,9 +85,9 @@
uri += slingRepo.getDefaultWorkspace();
response.sendRedirect(uri);
}
+ } else {
+ super.service(request, response);
}
-
- super.service(request, response);
}
// ---------- SCR integration
----------------------------------------------
Regards,
Marc
Re: Minor bug in SimpleWebDavServlet
Posted by Felix Meschberger <fm...@gmail.com>.
Hi Marc,
Thanks alot for this report.
Regards
Felix
Marc Speck schrieb:
> When PathInfo is null or "/", a response is already created and it makes no
> sense to call super.service() anymore:
>
>
> Index: SimpleWebDavServlet.java
> ===================================================================
> --- SimpleWebDavServlet.java (revision 691120)
> +++ SimpleWebDavServlet.java (working copy)
> @@ -85,9 +85,9 @@
> uri += slingRepo.getDefaultWorkspace();
> response.sendRedirect(uri);
> }
> + } else {
> + super.service(request, response);
> }
> -
> - super.service(request, response);
> }
>
> // ---------- SCR integration
> ----------------------------------------------
>
>
> Regards,
> Marc
>
Re: Minor bug in SimpleWebDavServlet
Posted by Felix Meschberger <fm...@gmail.com>.
Hi Marc,
Thanks. So I closed the issue.
Regards
Felix
Marc Speck schrieb:
> Thanks for patching, it's fine for me.
> Marc
>
Re: Minor bug in SimpleWebDavServlet
Posted by Marc Speck <ma...@gmail.com>.
Thanks for patching, it's fine for me.
Marc
Re: Minor bug in SimpleWebDavServlet
Posted by Felix Meschberger <fm...@gmail.com>.
Hi Marc,
I fixed this in Rev. 691374 of the jcr/webdav module as per SLING-639 [1].
Could you please verify, the fix is correct ? Thanks.
Regards
Felix
[1] https://issues.apache.org/jira/browse/SLING-639
Marc Speck schrieb:
> When PathInfo is null or "/", a response is already created and it makes no
> sense to call super.service() anymore:
>
>
> Index: SimpleWebDavServlet.java
> ===================================================================
> --- SimpleWebDavServlet.java (revision 691120)
> +++ SimpleWebDavServlet.java (working copy)
> @@ -85,9 +85,9 @@
> uri += slingRepo.getDefaultWorkspace();
> response.sendRedirect(uri);
> }
> + } else {
> + super.service(request, response);
> }
> -
> - super.service(request, response);
> }
>
> // ---------- SCR integration
> ----------------------------------------------
>
>
> Regards,
> Marc
>