[GitHub] [apisix-helm-chart] tokers commented on a change in pull request #161: feat: support to mount 3rd plugins from configmap

[GitBox <gi...@apache.org>]

tokers commented on a change in pull request #161:
URL: https://github.com/apache/apisix-helm-chart/pull/161#discussion_r737281083



##########
File path: charts/apisix/templates/deployment.yaml
##########
@@ -94,6 +103,13 @@ spec:
         - configMap:
             name: {{ include "apisix.fullname" . }}
           name: apisix-config
+      {{- if .Values.customPlugins.enabled }}
+      {{- range $plugin := .Values.customPlugins.plugins }}
+        - name: plugin-{{ $plugin.configMap.name }}
+          configMap:
+            name: {{ $plugin.configMap.name }}

Review comment:
       It's not a good idea, since keys in configmap are flat but custom plugins may have its own directory structure, only  users know how to mount files to configmap, and, put all plugins codes into the same configmap might cause the key confictions.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org