You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Chun-Hung Hsiao <ch...@apache.org> on 2019/02/05 08:01:17 UTC
Review Request 69896: Made SLRP `PublishResourcesReboot` test to check
persistent volume cleanup.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69896/
-----------------------------------------------------------
Review request for mesos and Benjamin Bannier.
Bugs: MESOS-9544
https://issues.apache.org/jira/browse/MESOS-9544
Repository: mesos
Description
-------
This patch renames the `ROOT_PublishResourcesReboot` test to
`ROOT_CreateDestroyPersistentMountVolumeWithReboot` and makes it verify
that the persistent volume is cleaned up with `DESTROY` after a reboot.
Diffs
-----
src/tests/storage_local_resource_provider_tests.cpp e8ed20f818ed7f1a3ce15758ea3c366520443377
Diff: https://reviews.apache.org/r/69896/diff/1/
Testing
-------
`make check`
Run in repetition with ~1000 repetitions.
Thanks,
Chun-Hung Hsiao
Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to
check persistent volume cleanup.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69896/#review212740
-----------------------------------------------------------
src/tests/storage_local_resource_provider_tests.cpp
Line 2282 (original)
<https://reviews.apache.org/r/69896/#comment298632>
Not mentioned anywhere.
src/tests/storage_local_resource_provider_tests.cpp
Lines 2519-2523 (patched)
<https://reviews.apache.org/r/69896/#comment298634>
Could you briefly document _why_ we do this? You could probably merge this note with the one mentioning MESOS-9553.
src/tests/storage_local_resource_provider_tests.cpp
Line 2564 (original), 2598 (patched)
<https://reviews.apache.org/r/69896/#comment298633>
Wait for an operation status update here?
- Benjamin Bannier
On Feb. 12, 2019, 6:22 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69896/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 6:22 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9544
> https://issues.apache.org/jira/browse/MESOS-9544
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch renames the `ROOT_PublishResourcesReboot` test to
> `ROOT_CreateDestroyPersistentMountVolumeWithReboot` and makes it verify
> that the persistent volume is cleaned up with `DESTROY` after a reboot.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
>
>
> Diff: https://reviews.apache.org/r/69896/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
> Run in repetition with ~200 repetitions.
>
> Manually injected some delay in the SLRP profile reconciliation loop to test the behavior. Without waiting for the 3rd `UpdateSlaveMessage` the test flake would manifest, and with the trick the flake is gone.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to
check persistent volume cleanup.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69896/#review212741
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Bannier
On Feb. 12, 2019, 6:22 a.m., Chun-Hung Hsiao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69896/
> -----------------------------------------------------------
>
> (Updated Feb. 12, 2019, 6:22 a.m.)
>
>
> Review request for mesos and Benjamin Bannier.
>
>
> Bugs: MESOS-9544
> https://issues.apache.org/jira/browse/MESOS-9544
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This patch renames the `ROOT_PublishResourcesReboot` test to
> `ROOT_CreateDestroyPersistentMountVolumeWithReboot` and makes it verify
> that the persistent volume is cleaned up with `DESTROY` after a reboot.
>
>
> Diffs
> -----
>
> src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
>
>
> Diff: https://reviews.apache.org/r/69896/diff/2/
>
>
> Testing
> -------
>
> `make check`
>
> Run in repetition with ~200 repetitions.
>
> Manually injected some delay in the SLRP profile reconciliation loop to test the behavior. Without waiting for the 3rd `UpdateSlaveMessage` the test flake would manifest, and with the trick the flake is gone.
>
>
> Thanks,
>
> Chun-Hung Hsiao
>
>
Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to
check persistent volume cleanup.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69896/
-----------------------------------------------------------
(Updated Feb. 28, 2019, 12:18 a.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Removed unnecessary filters.
Bugs: MESOS-9565
https://issues.apache.org/jira/browse/MESOS-9565
Repository: mesos
Description
-------
This patch renames the `ROOT_PublishResourcesReboot` test to
`ROOT_CreateDestroyPersistentMountVolumeWithReboot` and makes it verify
that the persistent volume is cleaned up with `DESTROY` after a reboot.
NOTE: The `filesystem/linux` isolator has been removed from the test
because it is not necessary for the test. However, the root privilege is
still required by the test CSI plugin for bind-mounting.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp a661951a0a326cc342aa0c45dd0967692ae70941
Diff: https://reviews.apache.org/r/69896/diff/4/
Changes: https://reviews.apache.org/r/69896/diff/3-4/
Testing
-------
`make check`
Run in repetition with ~200 repetitions.
Manually injected some delay in the SLRP profile reconciliation loop to test the behavior. Without waiting for the 3rd `UpdateSlaveMessage` the test flake would manifest, and with the trick the flake is gone.
Thanks,
Chun-Hung Hsiao
Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to
check persistent volume cleanup.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69896/
-----------------------------------------------------------
(Updated Feb. 13, 2019, 9:20 p.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Addressed Benjamin's comments and fixed a compilation error.
Bugs: MESOS-9565
https://issues.apache.org/jira/browse/MESOS-9565
Repository: mesos
Description (updated)
-------
This patch renames the `ROOT_PublishResourcesReboot` test to
`ROOT_CreateDestroyPersistentMountVolumeWithReboot` and makes it verify
that the persistent volume is cleaned up with `DESTROY` after a reboot.
NOTE: The `filesystem/linux` isolator has been removed from the test
because it is not necessary for the test. However, the root privilege is
still required by the test CSI plugin for bind-mounting.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
Diff: https://reviews.apache.org/r/69896/diff/3/
Changes: https://reviews.apache.org/r/69896/diff/2-3/
Testing
-------
`make check`
Run in repetition with ~200 repetitions.
Manually injected some delay in the SLRP profile reconciliation loop to test the behavior. Without waiting for the 3rd `UpdateSlaveMessage` the test flake would manifest, and with the trick the flake is gone.
Thanks,
Chun-Hung Hsiao
Re: Review Request 69896: Made SLRP `PublishResourcesReboot` test to
check persistent volume cleanup.
Posted by Chun-Hung Hsiao <ch...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69896/
-----------------------------------------------------------
(Updated Feb. 12, 2019, 5:22 a.m.)
Review request for mesos and Benjamin Bannier.
Changes
-------
Resolved a test flake more cleanly (IMO).
Bugs: MESOS-9544
https://issues.apache.org/jira/browse/MESOS-9544
Repository: mesos
Description
-------
This patch renames the `ROOT_PublishResourcesReboot` test to
`ROOT_CreateDestroyPersistentMountVolumeWithReboot` and makes it verify
that the persistent volume is cleaned up with `DESTROY` after a reboot.
Diffs (updated)
-----
src/tests/storage_local_resource_provider_tests.cpp fb001aa8d32d1a0a03014a35772fe10b65ce8d9a
Diff: https://reviews.apache.org/r/69896/diff/2/
Changes: https://reviews.apache.org/r/69896/diff/1-2/
Testing
-------
`make check`
Run in repetition with ~1000 repetitions.
Thanks,
Chun-Hung Hsiao