You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by eh...@apache.org on 2003/01/04 01:34:01 UTC

cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ide VAJAntToolGUI.java

ehatcher    2003/01/03 16:34:01

  Modified:    src/main/org/apache/tools/ant/taskdefs/optional/ide
                        VAJAntToolGUI.java
  Log:
  XDoclet does not like the semicolons on these lines
  
  Revision  Changes    Path
  1.17      +7 -7      jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ide/VAJAntToolGUI.java
  
  Index: VAJAntToolGUI.java
  ===================================================================
  RCS file: /home/cvs/jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ide/VAJAntToolGUI.java,v
  retrieving revision 1.16
  retrieving revision 1.17
  diff -u -r1.16 -r1.17
  --- VAJAntToolGUI.java	8 Nov 2002 16:37:44 -0000	1.16
  +++ VAJAntToolGUI.java	4 Jan 2003 00:34:01 -0000	1.17
  @@ -210,7 +210,7 @@
                   logException(error);
               }
   
  -            getMessageTextArea().append(lineSeparator + "Total time: " 
  +            getMessageTextArea().append(lineSeparator + "Total time: "
                   + DateUtils.formatElapsedTime(System.currentTimeMillis() - startTime));
           }
   
  @@ -428,12 +428,12 @@
                   handleException(exc);
               }
           }
  -        public void windowActivated(WindowEvent e) {};
  -        public void windowClosed(WindowEvent e) {};
  -        public void windowDeactivated(WindowEvent e) {};
  -        public void windowDeiconified(WindowEvent e) {};
  -        public void windowIconified(WindowEvent e) {};
  -        public void windowOpened(WindowEvent e) {};
  +        public void windowActivated(WindowEvent e) {}
  +        public void windowClosed(WindowEvent e) {}
  +        public void windowDeactivated(WindowEvent e) {}
  +        public void windowDeiconified(WindowEvent e) {}
  +        public void windowIconified(WindowEvent e) {}
  +        public void windowOpened(WindowEvent e) {}
       }
   
       /**
  
  
  

--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ide VAJAntToolGUI.java

Posted by Steve Loughran <st...@iseran.com>.
----- Original Message -----
From: "Erik Hatcher" <ja...@ehatchersolutions.com>
To: "Ant Developers List" <an...@jakarta.apache.org>
Sent: Saturday, January 04, 2003 15:46
Subject: Re: cvs commit:
jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ide
VAJAntToolGUI.java


> On Saturday, January 4, 2003, at 03:12  PM, Steve Loughran wrote:
> >
> > ----- Original Message -----
> > From: <eh...@apache.org>
> > To: <ja...@apache.org>
> > Sent: Friday, January 03, 2003 16:34
> > Subject: cvs commit:
> > jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ide
> > VAJAntToolGUI.java
> >
> >
> >> ehatcher    2003/01/03 16:34:01
> >>
> >>   Modified:    src/main/org/apache/tools/ant/taskdefs/optional/ide
> >>                         VAJAntToolGUI.java
> >>   Log:
> >>   XDoclet does not like the semicolons on these lines
> >
> > why not fix xdoclet? the compilers dont complain
> >
>
> The compilers don't complain without the semicolons either, and now
> everyone is happy!  :)
>
> I spoke with Aslak about this (the Xjavadoc guru) and he said something
> along the lines that the spec doesn't say that semicolons are legal
> there, but that compilers don't mind.  I could be misquoting him here,
> but this change is easier than me learning JavaCC and attempting to fix
> the other side of the equation.

the issue I have is that some of the metadata-to-java tool (like Axis) stick
the extra semis in, and I get hate logmessages from xdoclet when it parses
the files. I dont want to have to fix every such code gen tool I have just
'cos xdoclet is fussy...


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ide VAJAntToolGUI.java

Posted by Erik Hatcher <ja...@ehatchersolutions.com>.
On Saturday, January 4, 2003, at 03:12  PM, Steve Loughran wrote:
>
> ----- Original Message -----
> From: <eh...@apache.org>
> To: <ja...@apache.org>
> Sent: Friday, January 03, 2003 16:34
> Subject: cvs commit:
> jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ide
> VAJAntToolGUI.java
>
>
>> ehatcher    2003/01/03 16:34:01
>>
>>   Modified:    src/main/org/apache/tools/ant/taskdefs/optional/ide
>>                         VAJAntToolGUI.java
>>   Log:
>>   XDoclet does not like the semicolons on these lines
>
> why not fix xdoclet? the compilers dont complain
>

The compilers don't complain without the semicolons either, and now 
everyone is happy!  :)

I spoke with Aslak about this (the Xjavadoc guru) and he said something 
along the lines that the spec doesn't say that semicolons are legal 
there, but that compilers don't mind.  I could be misquoting him here, 
but this change is easier than me learning JavaCC and attempting to fix 
the other side of the equation.

	Erik


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>


Re: cvs commit: jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ide VAJAntToolGUI.java

Posted by Steve Loughran <st...@iseran.com>.
----- Original Message -----
From: <eh...@apache.org>
To: <ja...@apache.org>
Sent: Friday, January 03, 2003 16:34
Subject: cvs commit:
jakarta-ant/src/main/org/apache/tools/ant/taskdefs/optional/ide
VAJAntToolGUI.java


> ehatcher    2003/01/03 16:34:01
>
>   Modified:    src/main/org/apache/tools/ant/taskdefs/optional/ide
>                         VAJAntToolGUI.java
>   Log:
>   XDoclet does not like the semicolons on these lines

why not fix xdoclet? the compilers dont complain


--
To unsubscribe, e-mail:   <ma...@jakarta.apache.org>
For additional commands, e-mail: <ma...@jakarta.apache.org>