[GitHub] sijie commented on a change in pull request #913: [WIP] Refactor FileInfo locking and refcounting out IndexPersistenceMgr

[GitBox <gi...@apache.org>]

sijie commented on a change in pull request #913: [WIP] Refactor FileInfo locking and refcounting out IndexPersistenceMgr
URL: https://github.com/apache/bookkeeper/pull/913#discussion_r158544101
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/IndexPersistenceMgr.java
 ##########
 @@ -80,15 +77,13 @@ public static final String getLedgerName(long ledgerId) {
     }
 
     // use two separate cache for write and read
-    final Cache<Long, FileInfo> writeFileInfoCache;
-    final Cache<Long, FileInfo> readFileInfoCache;
+    final Cache<Long, CachedFileInfo> writeFileInfoCache;
+    final Cache<Long, CachedFileInfo> readFileInfoCache;
+    final FileInfoBackingCache fileInfoBackingCache;
 
 Review comment:
   The change here is same as the original change I made using guava cache at Twitter. I did it using two guava cache with one backing concurrent map. However when I left twitter, Yiming found some bugs using this approach, which it made him remove the backing concurrent hashmap and use guava cache only.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services