You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@buildr.apache.org by "Antoine Toulme (JIRA)" <ji...@apache.org> on 2010/04/12 01:51:47 UTC
[jira] Resolved: (BUILDR-398) FileUtils#sh does not work correctly
on windows
[ https://issues.apache.org/jira/browse/BUILDR-398?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Antoine Toulme resolved BUILDR-398.
-----------------------------------
Resolution: Fixed
Fixed by Alex just now.
Applied fix to "else" portion of "if Buildr::Util.java_platform?" condition.
Sending lib/buildr/core/util.rb
Transmitting file data .
Committed revision 933023.
> FileUtils#sh does not work correctly on windows
> -----------------------------------------------
>
> Key: BUILDR-398
> URL: https://issues.apache.org/jira/browse/BUILDR-398
> Project: Buildr
> Issue Type: Bug
> Components: Core features
> Affects Versions: 1.3.5
> Reporter: Pepijn Van Eeckhoudt
> Assignee: Alex Boisvert
> Priority: Critical
> Fix For: 1.4
>
> Attachments: fileutils_sh.patch
>
>
> the sh method attempts to 'cd' to Dir.pwd before executing the actual command. This does not work correctly on Windows/JRuby 1.4. File::SEPARATOR returns '/' on this platform. When system tries to 'cd' to a path with a '/' on Windows the operation fails. The attached patch ensures the separators are '\' instead.
> Also cd on windows changes the current directory for a particular drive. When changing to another drive the '/d' option should be included. This is also included in the attached patch.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira