You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by "Bram de Kruijff (JIRA)" <ji...@apache.org> on 2012/05/30 17:15:22 UTC
[jira] [Updated] (FELIX-3526) DeploymentAdmin fails on windows due
to unclosed iostreams
[ https://issues.apache.org/jira/browse/FELIX-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bram de Kruijff updated FELIX-3526:
-----------------------------------
Attachment: FELIX-3526-closeStreams.patch
Patch attached. Added some logging too.
> DeploymentAdmin fails on windows due to unclosed iostreams
> ----------------------------------------------------------
>
> Key: FELIX-3526
> URL: https://issues.apache.org/jira/browse/FELIX-3526
> Project: Felix
> Issue Type: Bug
> Components: Deployment Admin
> Affects Versions: deploymentadmin-0.9.0
> Environment: Apache Maven 3.0.4 (r1232337; 2012-01-17 09:44:56+0100)
> Maven home: C:\Program Files\Apache Maven\apache-maven-3.0.4
> Java version: 1.7.0_02, vendor: Oracle Corporation
> Java home: C:\Program Files\Java\jdk1.7.0_02\jre
> Default locale: en_US, platform encoding: Cp1252
> OS name: "windows 7", version: "6.1", arch: "amd64", family: "windows"
> Reporter: Bram de Kruijff
> Attachments: FELIX-3526-closeStreams.patch
>
>
> DeploymentAdmin leaks a few inputstreams that cause it to fail on deletes and consequently the update. Attaching a patch that solves three possible cases:
> 1) ExplodingOutputtingInputStream#merge may hold a lock on the manifest file
> 2) UpdateCommand$UpdateBundleRunnable does not close its own stream (may be superfluous though)
> 3) DropBundleCommand$InstallBundleRunnable gets past an inpustream but does not close it (an may never even run). This one caused the error below.
> {code}
> [Error] [ ] Could not merge source fix package with target deployment package
> java.io.IOException: Could not delete .\felix-cache\bundle0\packages\bram2\contents\org.amdatu.multitenant.org.ops4j.pax.useradmin.pax-useradmin-service-1.0.0-RC3.jar
> at org.apache.felix.deploymentadmin.ExplodingOutputtingInputStream.merge(ExplodingOutputtingInputStream.java:310)
> at org.apache.felix.deploymentadmin.DeploymentAdminImpl.installDeploymentPackage(DeploymentAdminImpl.java:229)
> at org.apache.ace.deployment.deploymentadmin.DeploymentAdminDeployer.install(DeploymentAdminDeployer.java:51)
> at org.apache.ace.deployment.service.impl.DeploymentServiceImpl.installVersion(DeploymentServiceImpl.java:120)
> at org.apache.ace.deployment.task.DeploymentUpdateTask.run(DeploymentUpdateTask.java:57)
> at org.apache.ace.scheduler.Executer.run(Executer.java:92)
> at java.util.TimerThread.mainLoop(Timer.java:555)
> at java.util.TimerThread.run(Timer.java:505)
> [Error] [ ] Error installing update
> {code}
> ref: http://jira.amdatu.org/jira/browse/AMDATU-693
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira