[GitHub] [calcite] xy2953396112 commented on a change in pull request #2519: [CALCITE-3583] Support serialized to json and deserialized from json …

[GitBox <gi...@apache.org>]

xy2953396112 commented on a change in pull request #2519:
URL: https://github.com/apache/calcite/pull/2519#discussion_r712602107



##########
File path: core/src/main/java/org/apache/calcite/rel/RelDistributions.java
##########
@@ -88,6 +88,15 @@ private static ImmutableIntList normalizeKeys(Collection<? extends Number> keys)
     return list;
   }
 
+  /** Creates a distribution. */
+  public static RelDistribution distribution(

Review comment:
       Not necessary,There is already a [PR](https://issues.apache.org/jira/browse/CALCITE-3867) that supports serialization and deserialization.but when I tested the unit test `testExchange`, I got the message below.
   
   java.lang.NullPointerException: no entry for tag collation
   java.lang.RuntimeException: java.lang.NullPointerException: no entry for tag collation
   	at org.apache.calcite.tools.Frameworks.withPrepare(Frameworks.java:193)
   	at org.apache.calcite.tools.Frameworks.withPlanner(Frameworks.java:135)
   
   
    
   
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@calcite.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org