You are viewing a plain text version of this content. The canonical link for it is here.
Posted to test-commits@perl.apache.org by st...@apache.org on 2005/11/02 20:25:49 UTC

svn commit: r330319 - in /perl/Apache-Test/trunk: Changes lib/Apache/TestMM.pm

Author: stas
Date: Wed Nov  2 11:25:39 2005
New Revision: 330319

URL: http://svn.apache.org/viewcvs?rev=330319&view=rev
Log:
use which("cover") to find the cover utility from Devel::Cover and run
it only if found.

Modified:
    perl/Apache-Test/trunk/Changes
    perl/Apache-Test/trunk/lib/Apache/TestMM.pm

Modified: perl/Apache-Test/trunk/Changes
URL: http://svn.apache.org/viewcvs/perl/Apache-Test/trunk/Changes?rev=330319&r1=330318&r2=330319&view=diff
==============================================================================
--- perl/Apache-Test/trunk/Changes (original)
+++ perl/Apache-Test/trunk/Changes Wed Nov  2 11:25:39 2005
@@ -8,6 +8,9 @@
 
 =item 1.28-dev
 
+use which("cover") to find the cover utility from Devel::Cover and run
+it only if found. [Stas]
+
 Devel::Cover magic is now fully integrated.  no more modperl_extra.pl
 or extra.conf.in fiddling - 'make testcover' should be all you need
 to do now [Geoffrey Young]

Modified: perl/Apache-Test/trunk/lib/Apache/TestMM.pm
URL: http://svn.apache.org/viewcvs/perl/Apache-Test/trunk/lib/Apache/TestMM.pm?rev=330319&r1=330318&r2=330319&view=diff
==============================================================================
--- perl/Apache-Test/trunk/lib/Apache/TestMM.pm (original)
+++ perl/Apache-Test/trunk/lib/Apache/TestMM.pm Wed Nov  2 11:25:39 2005
@@ -64,14 +64,14 @@
     if (eval { require Devel::Cover }) {
         my $atdir = File::Spec->catfile($ENV{HOME}, '.apache-test');
 
-        $cover = <<"EOF"
+        my $cover_exec = Apache::TestConfig::which("cover");
 
-testcover :
-	-\@cover -delete
-	-HARNESS_PERL_SWITCHES=-MDevel::Cover=+inc,$atdir \\
-	APACHE_TEST_EXTRA_ARGS=-one-process \$(MAKE) test
-	-\@cover
-EOF
+        my @cover = ("", "testcover :", );
+        push @cover, "\t-\@$cover_exec -delete" if $cover_exec;
+        push @cover, "\t-HARNESS_PERL_SWITCHES=-MDevel::Cover=+inc,$atdir \\",
+            "\tAPACHE_TEST_EXTRA_ARGS=-one-process \$(MAKE) test";
+        push @cover, "\t-\@$cover_exec" if $cover_exec;
+        $cover = join "\n", @cover, "";
     }
     else {