[jira] [Comment Edited] (FLINK-10172) Inconsistentcy in ExpressionParser and ExpressionDsl for order by asc/desc

["Rong Rong (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-10172?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16586092#comment-16586092 ] 

Rong Rong edited comment on FLINK-10172 at 8/20/18 3:33 PM:
------------------------------------------------------------

[~fhueske] yes, there were specific handling for {{ASC}} and {{DESC}} in {{ExpressionParser}} in previous Flink releases but somehow it was deleted. See https://github.com/apache/flink/pull/1926/files. I was wondering if it is possible that some other inconsistencies could have slipped through during the restructuring fo the code recently.


was (Author: walterddr):
[~fhueske] yes, there were specific handling for {{ASC}} and {DESC}} in {{ExpressionParser}} in previous Flink releases but somehow it was deleted. See https://github.com/apache/flink/pull/1926/files. I was wondering if it is possible that some other inconsistencies could have slipped through during the restructuring fo the code recently.

> Inconsistentcy in ExpressionParser and ExpressionDsl for order by asc/desc
> --------------------------------------------------------------------------
>
>                 Key: FLINK-10172
>                 URL: https://issues.apache.org/jira/browse/FLINK-10172
>             Project: Flink
>          Issue Type: Bug
>          Components: Table API & SQL
>    Affects Versions: 1.6.0
>            Reporter: Rong Rong
>            Assignee: Rong Rong
>            Priority: Major
>
> The following expression throws an exception in parsing {{"id.asc"}} term.
> {code:java}
> Table allOrders = orderTable
>         .select("id,order_date,amount,customer_id")
>         .orderBy("id.asc");
> {code}
> while it is correctly parsed for Scala:
> {code:scala}
> val allOrders:Table = orderTable
>         .select('id, 'order_date, 'amount, 'customer_id)
>         .orderBy('id.asc)
> {code}
> Anticipated some inconsistency between ExpressionParser and ExpressionDsl



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)