You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@superset.apache.org by GitBox <gi...@apache.org> on 2018/04/03 23:04:48 UTC
[GitHub] codecov-io commented on issue #4746: Filtering out SQLLab views out of table list view by default
codecov-io commented on issue #4746: Filtering out SQLLab views out of table list view by default
URL: https://github.com/apache/incubator-superset/pull/4746#issuecomment-378426925
# [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=h1) Report
> Merging [#4746](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-superset/commit/f6fe11f76e0c890184ac37b25e1a4baf30bc94d1?src=pr&el=desc) will **increase** coverage by `0.01%`.
> The diff coverage is `93.33%`.
[](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4746 +/- ##
==========================================
+ Coverage 72.38% 72.39% +0.01%
==========================================
Files 205 205
Lines 15374 15385 +11
Branches 1182 1182
==========================================
+ Hits 11128 11138 +10
- Misses 4243 4244 +1
Partials 3 3
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [superset/views/core.py](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvdmlld3MvY29yZS5weQ==) | `71.09% <0%> (-0.06%)` | :arrow_down: |
| [.../assets/javascripts/addSlice/AddSliceContainer.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL2FkZFNsaWNlL0FkZFNsaWNlQ29udGFpbmVyLmpzeA==) | `89.28% <100%> (+0.39%)` | :arrow_up: |
| [superset/connectors/sqla/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL21vZGVscy5weQ==) | `77.43% <100%> (+0.14%)` | :arrow_up: |
| [superset/connectors/sqla/views.py](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9zcWxhL3ZpZXdzLnB5) | `71.84% <100%> (+0.27%)` | :arrow_up: |
| [superset/connectors/connector\_registry.py](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9jb25uZWN0b3JfcmVnaXN0cnkucHk=) | `89.74% <100%> (+0.85%)` | :arrow_up: |
| [superset/connectors/base/models.py](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvY29ubmVjdG9ycy9iYXNlL21vZGVscy5weQ==) | `91.11% <100%> (+0.13%)` | :arrow_up: |
| [...assets/javascripts/SqlLab/components/SqlEditor.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1NxbEVkaXRvci5qc3g=) | `77.88% <0%> (ø)` | :arrow_up: |
| [...scripts/SqlLab/components/RunQueryActionButton.jsx](https://codecov.io/gh/apache/incubator-superset/pull/4746/diff?src=pr&el=tree#diff-c3VwZXJzZXQvYXNzZXRzL2phdmFzY3JpcHRzL1NxbExhYi9jb21wb25lbnRzL1J1blF1ZXJ5QWN0aW9uQnV0dG9uLmpzeA==) | `88% <0%> (ø)` | :arrow_up: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=footer). Last update [f6fe11f...d1e8757](https://codecov.io/gh/apache/incubator-superset/pull/4746?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services