You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@felix.apache.org by Sten Roger Sandvik <sr...@x3m.com> on 2009/07/26 22:13:12 UTC
Felix HttpService improvement...
Hi.
I have looked at the HttpService implementation in Felix and I had some
thoughts on how to improve the functionality. Over the past year I have
looked long and hard for a solution that has the following features:
* Run inside a WAR on a 3rd part container.
* Run stand-alone (using jetty).
* Has servlet filter support.
* Using whiteboard pattern for registering servlets / filters.
The road led me to Pax Web (supports filters, but only as a stand-alone
service) and Equinox Servlet Bridge (does not support filters). Whiteboard
registering pattern is implemented by the Pax guys, but does not support
filters inside a "bridged" environment.
So, eventually I was tired of looking for a solution out there and created
my own. This supports servlets and filters in both stand-alone and bridged
mode (WAR). Now I have come to a fork in the road. Should I donate the code
or host my own. I prefer to donate the code. But is the right place under
Felix umbrella or Pax Web umbrella? I see that more and more is created
under Felix and this implementation would be (in my opinion) a great
addition.
So, what do you guys think?
BR,
Sten Roger Sandvik
Re: Felix HttpService improvement...
Posted by Felix Meschberger <fm...@gmail.com>.
Hi Sten
Sten Roger Sandvik schrieb:
> On Fri, Aug 28, 2009 at 10:30 PM, Felix Meschberger <fm...@gmail.com>wrote:
>
>> As part of the IP-process we also need an ICLA of you, Sten, on file. I
>> see there is one for Sten Roger Sanvik with email srs@xbm.com. Am I
>> correct to assume, that this is your ICLA ?
>
>
> Yes, but the email is wrong. It's srs@x3m.com. And the name Sten Roger
> Sandvik :-) Do I need another one?
Thanks for the confirmation.
I just crosschecked: It looks like there are two bugs ;-)
The wrong spelling on your last name is my fault: It is correct in the
registration. The wrong mail address stems from an incorrect
transmission from your ICLA fax submission (the fax clearly reads
srs@x3m.com. I will care to have this fixed.
Regards
Felix
>
>
>> Thanks again for your submission, I will now start the process of
>> getting this into Felix SVN.
>>
>> Regards
>> Felix
>>
>>
>> Sten Roger Sandvik schrieb:
>>> Attached the source in the jira task (
>>> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what
>> format
>>> that the attachement should be, but created a tar.gz file. Attached a md5
>>> checksum for the package.
>>>
>>> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik <sr...@x3m.com> wrote:
>>>
>>>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall <heavy@ungoverned.org
>>> wrote:
>>>>> On 8/28/09 4:36, Felix Meschberger wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Rob Walker schrieb:
>>>>>>
>>>>>>
>>>>>>> What do we need to do make this happen guys?
>>>>>>>
>>>>>>>
>>>>>> The next steps are IIRC the following:
>>>>>>
>>>>>> * Sten packages the source and attaches the package to
>>>>>> the issue and publishes a package checksum.
>>>>>>
>>>>>>
>>>>> I will add to this, removes any existing header/copyright notices from
>> the
>>>>> files and adds the standard Apache header (see any Felix Java file).
>> Package
>>>>> renaming is not necessary at this point.
>>>>>
>>>> Have added apache (2.0) on top of all files. Will now create a tarball
>> and
>>>> add it to the JIRA task. I'm also interested in getting committer rights
>> so
>>>> that I can still maintain the code. Will that be handled in a seperate
>> vote?
>>>>
>>>>> * We vote on accepting this submission
>>>>>> * We do the IP-clearance (filling out a form,
>>>>>> sending a mail to incubator@ and wait for 72h)
>>>>>> * Add the code into the SVN
>>>>>>
>>>>>> I think, we also need someone from the PMC to drive this process.
>>>>>>
>>>>>> Any volunteers (I could do it) ?
>>>>>>
>>>>>>
>>>>> I am happy to have you do it. :-)
>>>>>
>>>>> Of course, I can help if needed.
>>>>>
>>>>> -> richard
>>>>>
>>>>>
>>>>> Regards
>>>>>> Felix
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Sten - sounds like you've done a great job, kudos.
>>>>>>>
>>>>>>> Felix/Marcel - sounds like you guys are happy with the approach and
>> code
>>>>>>>> From our side, we can certainly run some "real world" compatibility
>>>>>>> tests - which isn't to say in fact that Sten's new service would be
>>>>>>> wrong and the current one right, just whether thenew version breaks
>>>>>>> anything present in the exisiting service. If it does, I'm sure it'll
>>>>>>> either be fixable, or something that's actually not correct in the
>>>>>>> current service - so not a major issue. It'll be useful though to be
>>>>>>> able to advise other Felix guys of anything that might differ and
>> need
>>>>>>> application changes. I'm happy to make time to look at this next
>> week.
>>>>>>> After that - do we just call a vote? I'm guessing Sten, we also need
>> to
>>>>>>> propose you as a committter for maintenance?
>>>>>>>
>>>>>>> Great progress though - the current Http service has served us pretty
>>>>>>> well, but it's always been on the list to have cleaner and fuller
>>>>>>> solution
>>>>>>>
>>>>>>> -- Rob
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
On Fri, Aug 28, 2009 at 10:30 PM, Felix Meschberger <fm...@gmail.com>wrote:
> Hi Sten,
>
> Looks bascially good (files as appropriate have the license headers, MD5
> checksum matches).
>
> Just two remarks:
>
> * The pom.xml should also have the license headers
> (this can probably be fixed when we import into SVN)
>
> * there is a runner folder containing scripts and the
> pax runner library.
> This should probably not be included, right ?
> (again, I think we can start the process and just omit
> this directory when importing into SVN)
Yes, just omit the runner folder. That was a mistake. Was only using that to
make quick tests.
>
> As part of the IP-process we also need an ICLA of you, Sten, on file. I
> see there is one for Sten Roger Sanvik with email srs@xbm.com. Am I
> correct to assume, that this is your ICLA ?
Yes, but the email is wrong. It's srs@x3m.com. And the name Sten Roger
Sandvik :-) Do I need another one?
> Thanks again for your submission, I will now start the process of
> getting this into Felix SVN.
>
> Regards
> Felix
>
>
> Sten Roger Sandvik schrieb:
> > Attached the source in the jira task (
> > https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what
> format
> > that the attachement should be, but created a tar.gz file. Attached a md5
> > checksum for the package.
> >
> > On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik <sr...@x3m.com> wrote:
> >
> >>
> >> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall <heavy@ungoverned.org
> >wrote:
> >>
> >>> On 8/28/09 4:36, Felix Meschberger wrote:
> >>>
> >>>> Hi,
> >>>>
> >>>> Rob Walker schrieb:
> >>>>
> >>>>
> >>>>> What do we need to do make this happen guys?
> >>>>>
> >>>>>
> >>>> The next steps are IIRC the following:
> >>>>
> >>>> * Sten packages the source and attaches the package to
> >>>> the issue and publishes a package checksum.
> >>>>
> >>>>
> >>> I will add to this, removes any existing header/copyright notices from
> the
> >>> files and adds the standard Apache header (see any Felix Java file).
> Package
> >>> renaming is not necessary at this point.
> >>>
> >> Have added apache (2.0) on top of all files. Will now create a tarball
> and
> >> add it to the JIRA task. I'm also interested in getting committer rights
> so
> >> that I can still maintain the code. Will that be handled in a seperate
> vote?
> >>
> >>
> >>>
> >>> * We vote on accepting this submission
> >>>> * We do the IP-clearance (filling out a form,
> >>>> sending a mail to incubator@ and wait for 72h)
> >>>> * Add the code into the SVN
> >>>>
> >>>> I think, we also need someone from the PMC to drive this process.
> >>>>
> >>>> Any volunteers (I could do it) ?
> >>>>
> >>>>
> >>> I am happy to have you do it. :-)
> >>>
> >>> Of course, I can help if needed.
> >>>
> >>> -> richard
> >>>
> >>>
> >>> Regards
> >>>> Felix
> >>>>
> >>>>
> >>>>
> >>>>> Sten - sounds like you've done a great job, kudos.
> >>>>>
> >>>>> Felix/Marcel - sounds like you guys are happy with the approach and
> code
> >>>>>
> >>>>>> From our side, we can certainly run some "real world" compatibility
> >>>>> tests - which isn't to say in fact that Sten's new service would be
> >>>>> wrong and the current one right, just whether thenew version breaks
> >>>>> anything present in the exisiting service. If it does, I'm sure it'll
> >>>>> either be fixable, or something that's actually not correct in the
> >>>>> current service - so not a major issue. It'll be useful though to be
> >>>>> able to advise other Felix guys of anything that might differ and
> need
> >>>>> application changes. I'm happy to make time to look at this next
> week.
> >>>>>
> >>>>> After that - do we just call a vote? I'm guessing Sten, we also need
> to
> >>>>> propose you as a committter for maintenance?
> >>>>>
> >>>>> Great progress though - the current Http service has served us pretty
> >>>>> well, but it's always been on the list to have cleaner and fuller
> >>>>> solution
> >>>>>
> >>>>> -- Rob
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >
>
Re: Felix HttpService improvement...
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 8/28/09 16:43, Richard S. Hall wrote:
> On 8/28/09 16:30, Felix Meschberger wrote:
>> Hi Sten,
>>
>> Looks bascially good (files as appropriate have the license headers, MD5
>> checksum matches).
>>
>> Just two remarks:
>>
>> * The pom.xml should also have the license headers
>> (this can probably be fixed when we import into SVN)
>>
>> * there is a runner folder containing scripts and the
>> pax runner library.
>> This should probably not be included, right ?
>> (again, I think we can start the process and just omit
>> this directory when importing into SVN)
>>
>> As part of the IP-process we also need an ICLA of you, Sten, on file. I
>> see there is one for Sten Roger Sanvik with email srs@xbm.com. Am I
>> correct to assume, that this is your ICLA ?
>>
>> Thanks again for your submission, I will now start the process of
>> getting this into Felix SVN.
>
> Which will require Sten to fill out a Software Grant, which may need
> to come from his employer if it is actually the employer who is
> contributing the code.
And of course, we still have to vote and accept it before any of this is
truly necessary...
-> richard
>
> -> richard
>
>> Regards
>> Felix
>>
>>
>> Sten Roger Sandvik schrieb:
>>> Attached the source in the jira task (
>>> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what
>>> format
>>> that the attachement should be, but created a tar.gz file. Attached
>>> a md5
>>> checksum for the package.
>>>
>>> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik<sr...@x3m.com>
>>> wrote:
>>>
>>>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S.
>>>> Hall<he...@ungoverned.org>wrote:
>>>>
>>>>> On 8/28/09 4:36, Felix Meschberger wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Rob Walker schrieb:
>>>>>>
>>>>>>
>>>>>>> What do we need to do make this happen guys?
>>>>>>>
>>>>>>>
>>>>>> The next steps are IIRC the following:
>>>>>>
>>>>>> * Sten packages the source and attaches the package to
>>>>>> the issue and publishes a package checksum.
>>>>>>
>>>>>>
>>>>> I will add to this, removes any existing header/copyright notices
>>>>> from the
>>>>> files and adds the standard Apache header (see any Felix Java
>>>>> file). Package
>>>>> renaming is not necessary at this point.
>>>>>
>>>> Have added apache (2.0) on top of all files. Will now create a
>>>> tarball and
>>>> add it to the JIRA task. I'm also interested in getting committer
>>>> rights so
>>>> that I can still maintain the code. Will that be handled in a
>>>> seperate vote?
>>>>
>>>>
>>>>> * We vote on accepting this submission
>>>>>> * We do the IP-clearance (filling out a form,
>>>>>> sending a mail to incubator@ and wait for 72h)
>>>>>> * Add the code into the SVN
>>>>>>
>>>>>> I think, we also need someone from the PMC to drive this process.
>>>>>>
>>>>>> Any volunteers (I could do it) ?
>>>>>>
>>>>>>
>>>>> I am happy to have you do it. :-)
>>>>>
>>>>> Of course, I can help if needed.
>>>>>
>>>>> -> richard
>>>>>
>>>>>
>>>>> Regards
>>>>>> Felix
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Sten - sounds like you've done a great job, kudos.
>>>>>>>
>>>>>>> Felix/Marcel - sounds like you guys are happy with the approach
>>>>>>> and code
>>>>>>>
>>>>>>>> From our side, we can certainly run some "real world"
>>>>>>>> compatibility
>>>>>>> tests - which isn't to say in fact that Sten's new service would be
>>>>>>> wrong and the current one right, just whether thenew version breaks
>>>>>>> anything present in the exisiting service. If it does, I'm sure
>>>>>>> it'll
>>>>>>> either be fixable, or something that's actually not correct in the
>>>>>>> current service - so not a major issue. It'll be useful though
>>>>>>> to be
>>>>>>> able to advise other Felix guys of anything that might differ
>>>>>>> and need
>>>>>>> application changes. I'm happy to make time to look at this
>>>>>>> next week.
>>>>>>>
>>>>>>> After that - do we just call a vote? I'm guessing Sten, we also
>>>>>>> need to
>>>>>>> propose you as a committter for maintenance?
>>>>>>>
>>>>>>> Great progress though - the current Http service has served us
>>>>>>> pretty
>>>>>>> well, but it's always been on the list to have cleaner and fuller
>>>>>>> solution
>>>>>>>
>>>>>>> -- Rob
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
Yes. Will fill it out on monday.
On Sat, Aug 29, 2009 at 12:31 AM, Felix Meschberger <fm...@gmail.com>wrote:
> Hi Sten,
>
> Sten Roger Sandvik schrieb:
> > Ah, ok. Actually my employer is paying for my involvement in projects,
> but
> > not the work done on this particular piece. Maybe I need to fax in a
> > Corporate CLA then?
>
> Hmm, ok. Maybe it would be better then -- it certainly does not hurt.
>
> Regards
> Felix
>
> >
> > On Fri, Aug 28, 2009 at 11:56 PM, Felix Meschberger <fmeschbe@gmail.com
> >wrote:
> >
> >> Hi,
> >>
> >> Sten Roger Sandvik schrieb:
> >>> On Fri, Aug 28, 2009 at 10:43 PM, Richard S. Hall <
> heavy@ungoverned.org
> >>> wrote:
> >>>
> >>>> On 8/28/09 16:30, Felix Meschberger wrote:
> >>>>
> >>>>> Hi Sten,
> >>>>>
> >>>>> Looks bascially good (files as appropriate have the license headers,
> >> MD5
> >>>>> checksum matches).
> >>>>>
> >>>>> Just two remarks:
> >>>>>
> >>>>> * The pom.xml should also have the license headers
> >>>>> (this can probably be fixed when we import into SVN)
> >>>>>
> >>>>> * there is a runner folder containing scripts and the
> >>>>> pax runner library.
> >>>>> This should probably not be included, right ?
> >>>>> (again, I think we can start the process and just omit
> >>>>> this directory when importing into SVN)
> >>>>>
> >>>>> As part of the IP-process we also need an ICLA of you, Sten, on file.
> I
> >>>>> see there is one for Sten Roger Sanvik with email srs@xbm.com. Am I
> >>>>> correct to assume, that this is your ICLA ?
> >>>>>
> >>>>> Thanks again for your submission, I will now start the process of
> >>>>> getting this into Felix SVN.
> >>>>>
> >>>>>
> >>>> Which will require Sten to fill out a Software Grant, which may need
> to
> >>>> come from his employer if it is actually the employer who is
> >> contributing
> >>>> the code.
> >>>
> >>> No, it does not need to be from my employer. Been coding this in my
> spare
> >>> time. It has been used at Enonic (my current workplace) in form of some
> >>> binaries. So a grant from Enonic is not neccessary. But will be happy
> to
> >>> provide one if you really need it.
> >> A Corporate CLA is only required if your employer pays your for working
> >> on Apache projects.
> >>
> >> But what we would probably need to be good for IP clearance is a
> >> software grant [1]. You may fax it to the same number as the ICLA.
> Thanks.
> >>
> >>
> >> Regards
> >> Felix
> >>
> >> [1] http://www.apache.org/licenses/software-grant.txt
> >>
> >>>
> >>>> -> richard
> >>>>
> >>>>
> >>>> Regards
> >>>>> Felix
> >>>>>
> >>>>>
> >>>>> Sten Roger Sandvik schrieb:
> >>>>>
> >>>>>
> >>>>>> Attached the source in the jira task (
> >>>>>> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what
> >>>>>> format
> >>>>>> that the attachement should be, but created a tar.gz file. Attached
> a
> >> md5
> >>>>>> checksum for the package.
> >>>>>>
> >>>>>> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik<sr...@x3m.com>
> >> wrote:
> >>>>>>
> >>>>>>
> >>>>>>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall<
> >> heavy@ungoverned.org
> >>>>>>>> wrote:
> >>>>>>>
> >>>>>>>> On 8/28/09 4:36, Felix Meschberger wrote:
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> Hi,
> >>>>>>>>>
> >>>>>>>>> Rob Walker schrieb:
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>> What do we need to do make this happen guys?
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>> The next steps are IIRC the following:
> >>>>>>>>>
> >>>>>>>>> * Sten packages the source and attaches the package to
> >>>>>>>>> the issue and publishes a package checksum.
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>> I will add to this, removes any existing header/copyright notices
> >> from
> >>>>>>>> the
> >>>>>>>> files and adds the standard Apache header (see any Felix Java
> file).
> >>>>>>>> Package
> >>>>>>>> renaming is not necessary at this point.
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>> Have added apache (2.0) on top of all files. Will now create a
> >> tarball
> >>>>>>> and
> >>>>>>> add it to the JIRA task. I'm also interested in getting committer
> >> rights
> >>>>>>> so
> >>>>>>> that I can still maintain the code. Will that be handled in a
> >> seperate
> >>>>>>> vote?
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> * We vote on accepting this submission
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> * We do the IP-clearance (filling out a form,
> >>>>>>>>> sending a mail to incubator@ and wait for 72h)
> >>>>>>>>> * Add the code into the SVN
> >>>>>>>>>
> >>>>>>>>> I think, we also need someone from the PMC to drive this process.
> >>>>>>>>>
> >>>>>>>>> Any volunteers (I could do it) ?
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>> I am happy to have you do it. :-)
> >>>>>>>>
> >>>>>>>> Of course, I can help if needed.
> >>>>>>>>
> >>>>>>>> -> richard
> >>>>>>>>
> >>>>>>>>
> >>>>>>>> Regards
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> Felix
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>>>> Sten - sounds like you've done a great job, kudos.
> >>>>>>>>>>
> >>>>>>>>>> Felix/Marcel - sounds like you guys are happy with the approach
> >> and
> >>>>>>>>>> code
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>> From our side, we can certainly run some "real world"
> >> compatibility
> >>>>>>>>>>>
> >>>>>>>>>> tests - which isn't to say in fact that Sten's new service would
> >> be
> >>>>>>>>>> wrong and the current one right, just whether thenew version
> >> breaks
> >>>>>>>>>> anything present in the exisiting service. If it does, I'm sure
> >> it'll
> >>>>>>>>>> either be fixable, or something that's actually not correct in
> the
> >>>>>>>>>> current service - so not a major issue. It'll be useful though
> to
> >> be
> >>>>>>>>>> able to advise other Felix guys of anything that might differ
> and
> >>>>>>>>>> need
> >>>>>>>>>> application changes. I'm happy to make time to look at this
> next
> >>>>>>>>>> week.
> >>>>>>>>>>
> >>>>>>>>>> After that - do we just call a vote? I'm guessing Sten, we also
> >> need
> >>>>>>>>>> to
> >>>>>>>>>> propose you as a committter for maintenance?
> >>>>>>>>>>
> >>>>>>>>>> Great progress though - the current Http service has served us
> >> pretty
> >>>>>>>>>> well, but it's always been on the list to have cleaner and
> fuller
> >>>>>>>>>> solution
> >>>>>>>>>>
> >>>>>>>>>> -- Rob
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >>>>>>>>>>
> >
>
Re: Felix HttpService improvement...
Posted by Felix Meschberger <fm...@gmail.com>.
Hi Sten,
Sten Roger Sandvik schrieb:
> Ah, ok. Actually my employer is paying for my involvement in projects, but
> not the work done on this particular piece. Maybe I need to fax in a
> Corporate CLA then?
Hmm, ok. Maybe it would be better then -- it certainly does not hurt.
Regards
Felix
>
> On Fri, Aug 28, 2009 at 11:56 PM, Felix Meschberger <fm...@gmail.com>wrote:
>
>> Hi,
>>
>> Sten Roger Sandvik schrieb:
>>> On Fri, Aug 28, 2009 at 10:43 PM, Richard S. Hall <heavy@ungoverned.org
>>> wrote:
>>>
>>>> On 8/28/09 16:30, Felix Meschberger wrote:
>>>>
>>>>> Hi Sten,
>>>>>
>>>>> Looks bascially good (files as appropriate have the license headers,
>> MD5
>>>>> checksum matches).
>>>>>
>>>>> Just two remarks:
>>>>>
>>>>> * The pom.xml should also have the license headers
>>>>> (this can probably be fixed when we import into SVN)
>>>>>
>>>>> * there is a runner folder containing scripts and the
>>>>> pax runner library.
>>>>> This should probably not be included, right ?
>>>>> (again, I think we can start the process and just omit
>>>>> this directory when importing into SVN)
>>>>>
>>>>> As part of the IP-process we also need an ICLA of you, Sten, on file. I
>>>>> see there is one for Sten Roger Sanvik with email srs@xbm.com. Am I
>>>>> correct to assume, that this is your ICLA ?
>>>>>
>>>>> Thanks again for your submission, I will now start the process of
>>>>> getting this into Felix SVN.
>>>>>
>>>>>
>>>> Which will require Sten to fill out a Software Grant, which may need to
>>>> come from his employer if it is actually the employer who is
>> contributing
>>>> the code.
>>>
>>> No, it does not need to be from my employer. Been coding this in my spare
>>> time. It has been used at Enonic (my current workplace) in form of some
>>> binaries. So a grant from Enonic is not neccessary. But will be happy to
>>> provide one if you really need it.
>> A Corporate CLA is only required if your employer pays your for working
>> on Apache projects.
>>
>> But what we would probably need to be good for IP clearance is a
>> software grant [1]. You may fax it to the same number as the ICLA. Thanks.
>>
>>
>> Regards
>> Felix
>>
>> [1] http://www.apache.org/licenses/software-grant.txt
>>
>>>
>>>> -> richard
>>>>
>>>>
>>>> Regards
>>>>> Felix
>>>>>
>>>>>
>>>>> Sten Roger Sandvik schrieb:
>>>>>
>>>>>
>>>>>> Attached the source in the jira task (
>>>>>> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what
>>>>>> format
>>>>>> that the attachement should be, but created a tar.gz file. Attached a
>> md5
>>>>>> checksum for the package.
>>>>>>
>>>>>> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik<sr...@x3m.com>
>> wrote:
>>>>>>
>>>>>>
>>>>>>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall<
>> heavy@ungoverned.org
>>>>>>>> wrote:
>>>>>>>
>>>>>>>> On 8/28/09 4:36, Felix Meschberger wrote:
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> Hi,
>>>>>>>>>
>>>>>>>>> Rob Walker schrieb:
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> What do we need to do make this happen guys?
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>> The next steps are IIRC the following:
>>>>>>>>>
>>>>>>>>> * Sten packages the source and attaches the package to
>>>>>>>>> the issue and publishes a package checksum.
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> I will add to this, removes any existing header/copyright notices
>> from
>>>>>>>> the
>>>>>>>> files and adds the standard Apache header (see any Felix Java file).
>>>>>>>> Package
>>>>>>>> renaming is not necessary at this point.
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> Have added apache (2.0) on top of all files. Will now create a
>> tarball
>>>>>>> and
>>>>>>> add it to the JIRA task. I'm also interested in getting committer
>> rights
>>>>>>> so
>>>>>>> that I can still maintain the code. Will that be handled in a
>> seperate
>>>>>>> vote?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> * We vote on accepting this submission
>>>>>>>>
>>>>>>>>
>>>>>>>>> * We do the IP-clearance (filling out a form,
>>>>>>>>> sending a mail to incubator@ and wait for 72h)
>>>>>>>>> * Add the code into the SVN
>>>>>>>>>
>>>>>>>>> I think, we also need someone from the PMC to drive this process.
>>>>>>>>>
>>>>>>>>> Any volunteers (I could do it) ?
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>> I am happy to have you do it. :-)
>>>>>>>>
>>>>>>>> Of course, I can help if needed.
>>>>>>>>
>>>>>>>> -> richard
>>>>>>>>
>>>>>>>>
>>>>>>>> Regards
>>>>>>>>
>>>>>>>>
>>>>>>>>> Felix
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>
>>>>>>>>>> Sten - sounds like you've done a great job, kudos.
>>>>>>>>>>
>>>>>>>>>> Felix/Marcel - sounds like you guys are happy with the approach
>> and
>>>>>>>>>> code
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>> From our side, we can certainly run some "real world"
>> compatibility
>>>>>>>>>>>
>>>>>>>>>> tests - which isn't to say in fact that Sten's new service would
>> be
>>>>>>>>>> wrong and the current one right, just whether thenew version
>> breaks
>>>>>>>>>> anything present in the exisiting service. If it does, I'm sure
>> it'll
>>>>>>>>>> either be fixable, or something that's actually not correct in the
>>>>>>>>>> current service - so not a major issue. It'll be useful though to
>> be
>>>>>>>>>> able to advise other Felix guys of anything that might differ and
>>>>>>>>>> need
>>>>>>>>>> application changes. I'm happy to make time to look at this next
>>>>>>>>>> week.
>>>>>>>>>>
>>>>>>>>>> After that - do we just call a vote? I'm guessing Sten, we also
>> need
>>>>>>>>>> to
>>>>>>>>>> propose you as a committter for maintenance?
>>>>>>>>>>
>>>>>>>>>> Great progress though - the current Http service has served us
>> pretty
>>>>>>>>>> well, but it's always been on the list to have cleaner and fuller
>>>>>>>>>> solution
>>>>>>>>>>
>>>>>>>>>> -- Rob
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>>>>>>>>>>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
Ah, ok. Actually my employer is paying for my involvement in projects, but
not the work done on this particular piece. Maybe I need to fax in a
Corporate CLA then?
On Fri, Aug 28, 2009 at 11:56 PM, Felix Meschberger <fm...@gmail.com>wrote:
> Hi,
>
> Sten Roger Sandvik schrieb:
> > On Fri, Aug 28, 2009 at 10:43 PM, Richard S. Hall <heavy@ungoverned.org
> >wrote:
> >
> >> On 8/28/09 16:30, Felix Meschberger wrote:
> >>
> >>> Hi Sten,
> >>>
> >>> Looks bascially good (files as appropriate have the license headers,
> MD5
> >>> checksum matches).
> >>>
> >>> Just two remarks:
> >>>
> >>> * The pom.xml should also have the license headers
> >>> (this can probably be fixed when we import into SVN)
> >>>
> >>> * there is a runner folder containing scripts and the
> >>> pax runner library.
> >>> This should probably not be included, right ?
> >>> (again, I think we can start the process and just omit
> >>> this directory when importing into SVN)
> >>>
> >>> As part of the IP-process we also need an ICLA of you, Sten, on file. I
> >>> see there is one for Sten Roger Sanvik with email srs@xbm.com. Am I
> >>> correct to assume, that this is your ICLA ?
> >>>
> >>> Thanks again for your submission, I will now start the process of
> >>> getting this into Felix SVN.
> >>>
> >>>
> >> Which will require Sten to fill out a Software Grant, which may need to
> >> come from his employer if it is actually the employer who is
> contributing
> >> the code.
> >
> >
> > No, it does not need to be from my employer. Been coding this in my spare
> > time. It has been used at Enonic (my current workplace) in form of some
> > binaries. So a grant from Enonic is not neccessary. But will be happy to
> > provide one if you really need it.
>
> A Corporate CLA is only required if your employer pays your for working
> on Apache projects.
>
> But what we would probably need to be good for IP clearance is a
> software grant [1]. You may fax it to the same number as the ICLA. Thanks.
>
>
> Regards
> Felix
>
> [1] http://www.apache.org/licenses/software-grant.txt
>
> >
> >
> >>
> >> -> richard
> >>
> >>
> >> Regards
> >>> Felix
> >>>
> >>>
> >>> Sten Roger Sandvik schrieb:
> >>>
> >>>
> >>>> Attached the source in the jira task (
> >>>> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what
> >>>> format
> >>>> that the attachement should be, but created a tar.gz file. Attached a
> md5
> >>>> checksum for the package.
> >>>>
> >>>> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik<sr...@x3m.com>
> wrote:
> >>>>
> >>>>
> >>>>
> >>>>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall<
> heavy@ungoverned.org
> >>>>>> wrote:
> >>>>>
> >>>>>
> >>>>>> On 8/28/09 4:36, Felix Meschberger wrote:
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>>>> Hi,
> >>>>>>>
> >>>>>>> Rob Walker schrieb:
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> What do we need to do make this happen guys?
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>> The next steps are IIRC the following:
> >>>>>>>
> >>>>>>> * Sten packages the source and attaches the package to
> >>>>>>> the issue and publishes a package checksum.
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>> I will add to this, removes any existing header/copyright notices
> from
> >>>>>> the
> >>>>>> files and adds the standard Apache header (see any Felix Java file).
> >>>>>> Package
> >>>>>> renaming is not necessary at this point.
> >>>>>>
> >>>>>>
> >>>>>>
> >>>>> Have added apache (2.0) on top of all files. Will now create a
> tarball
> >>>>> and
> >>>>> add it to the JIRA task. I'm also interested in getting committer
> rights
> >>>>> so
> >>>>> that I can still maintain the code. Will that be handled in a
> seperate
> >>>>> vote?
> >>>>>
> >>>>>
> >>>>>
> >>>>>
> >>>>>> * We vote on accepting this submission
> >>>>>>
> >>>>>>
> >>>>>>> * We do the IP-clearance (filling out a form,
> >>>>>>> sending a mail to incubator@ and wait for 72h)
> >>>>>>> * Add the code into the SVN
> >>>>>>>
> >>>>>>> I think, we also need someone from the PMC to drive this process.
> >>>>>>>
> >>>>>>> Any volunteers (I could do it) ?
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>> I am happy to have you do it. :-)
> >>>>>>
> >>>>>> Of course, I can help if needed.
> >>>>>>
> >>>>>> -> richard
> >>>>>>
> >>>>>>
> >>>>>> Regards
> >>>>>>
> >>>>>>
> >>>>>>> Felix
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>
> >>>>>>>> Sten - sounds like you've done a great job, kudos.
> >>>>>>>>
> >>>>>>>> Felix/Marcel - sounds like you guys are happy with the approach
> and
> >>>>>>>> code
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>> From our side, we can certainly run some "real world"
> compatibility
> >>>>>>>>>
> >>>>>>>>>
> >>>>>>>> tests - which isn't to say in fact that Sten's new service would
> be
> >>>>>>>> wrong and the current one right, just whether thenew version
> breaks
> >>>>>>>> anything present in the exisiting service. If it does, I'm sure
> it'll
> >>>>>>>> either be fixable, or something that's actually not correct in the
> >>>>>>>> current service - so not a major issue. It'll be useful though to
> be
> >>>>>>>> able to advise other Felix guys of anything that might differ and
> >>>>>>>> need
> >>>>>>>> application changes. I'm happy to make time to look at this next
> >>>>>>>> week.
> >>>>>>>>
> >>>>>>>> After that - do we just call a vote? I'm guessing Sten, we also
> need
> >>>>>>>> to
> >>>>>>>> propose you as a committter for maintenance?
> >>>>>>>>
> >>>>>>>> Great progress though - the current Http service has served us
> pretty
> >>>>>>>> well, but it's always been on the list to have cleaner and fuller
> >>>>>>>> solution
> >>>>>>>>
> >>>>>>>> -- Rob
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >>>>>>>>
> >
>
Re: Felix HttpService improvement...
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
Sten Roger Sandvik schrieb:
> On Fri, Aug 28, 2009 at 10:43 PM, Richard S. Hall <he...@ungoverned.org>wrote:
>
>> On 8/28/09 16:30, Felix Meschberger wrote:
>>
>>> Hi Sten,
>>>
>>> Looks bascially good (files as appropriate have the license headers, MD5
>>> checksum matches).
>>>
>>> Just two remarks:
>>>
>>> * The pom.xml should also have the license headers
>>> (this can probably be fixed when we import into SVN)
>>>
>>> * there is a runner folder containing scripts and the
>>> pax runner library.
>>> This should probably not be included, right ?
>>> (again, I think we can start the process and just omit
>>> this directory when importing into SVN)
>>>
>>> As part of the IP-process we also need an ICLA of you, Sten, on file. I
>>> see there is one for Sten Roger Sanvik with email srs@xbm.com. Am I
>>> correct to assume, that this is your ICLA ?
>>>
>>> Thanks again for your submission, I will now start the process of
>>> getting this into Felix SVN.
>>>
>>>
>> Which will require Sten to fill out a Software Grant, which may need to
>> come from his employer if it is actually the employer who is contributing
>> the code.
>
>
> No, it does not need to be from my employer. Been coding this in my spare
> time. It has been used at Enonic (my current workplace) in form of some
> binaries. So a grant from Enonic is not neccessary. But will be happy to
> provide one if you really need it.
A Corporate CLA is only required if your employer pays your for working
on Apache projects.
But what we would probably need to be good for IP clearance is a
software grant [1]. You may fax it to the same number as the ICLA. Thanks.
Regards
Felix
[1] http://www.apache.org/licenses/software-grant.txt
>
>
>>
>> -> richard
>>
>>
>> Regards
>>> Felix
>>>
>>>
>>> Sten Roger Sandvik schrieb:
>>>
>>>
>>>> Attached the source in the jira task (
>>>> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what
>>>> format
>>>> that the attachement should be, but created a tar.gz file. Attached a md5
>>>> checksum for the package.
>>>>
>>>> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik<sr...@x3m.com> wrote:
>>>>
>>>>
>>>>
>>>>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall<heavy@ungoverned.org
>>>>>> wrote:
>>>>>
>>>>>
>>>>>> On 8/28/09 4:36, Felix Meschberger wrote:
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Hi,
>>>>>>>
>>>>>>> Rob Walker schrieb:
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> What do we need to do make this happen guys?
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>> The next steps are IIRC the following:
>>>>>>>
>>>>>>> * Sten packages the source and attaches the package to
>>>>>>> the issue and publishes a package checksum.
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> I will add to this, removes any existing header/copyright notices from
>>>>>> the
>>>>>> files and adds the standard Apache header (see any Felix Java file).
>>>>>> Package
>>>>>> renaming is not necessary at this point.
>>>>>>
>>>>>>
>>>>>>
>>>>> Have added apache (2.0) on top of all files. Will now create a tarball
>>>>> and
>>>>> add it to the JIRA task. I'm also interested in getting committer rights
>>>>> so
>>>>> that I can still maintain the code. Will that be handled in a seperate
>>>>> vote?
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> * We vote on accepting this submission
>>>>>>
>>>>>>
>>>>>>> * We do the IP-clearance (filling out a form,
>>>>>>> sending a mail to incubator@ and wait for 72h)
>>>>>>> * Add the code into the SVN
>>>>>>>
>>>>>>> I think, we also need someone from the PMC to drive this process.
>>>>>>>
>>>>>>> Any volunteers (I could do it) ?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> I am happy to have you do it. :-)
>>>>>>
>>>>>> Of course, I can help if needed.
>>>>>>
>>>>>> -> richard
>>>>>>
>>>>>>
>>>>>> Regards
>>>>>>
>>>>>>
>>>>>>> Felix
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> Sten - sounds like you've done a great job, kudos.
>>>>>>>>
>>>>>>>> Felix/Marcel - sounds like you guys are happy with the approach and
>>>>>>>> code
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>> From our side, we can certainly run some "real world" compatibility
>>>>>>>>>
>>>>>>>>>
>>>>>>>> tests - which isn't to say in fact that Sten's new service would be
>>>>>>>> wrong and the current one right, just whether thenew version breaks
>>>>>>>> anything present in the exisiting service. If it does, I'm sure it'll
>>>>>>>> either be fixable, or something that's actually not correct in the
>>>>>>>> current service - so not a major issue. It'll be useful though to be
>>>>>>>> able to advise other Felix guys of anything that might differ and
>>>>>>>> need
>>>>>>>> application changes. I'm happy to make time to look at this next
>>>>>>>> week.
>>>>>>>>
>>>>>>>> After that - do we just call a vote? I'm guessing Sten, we also need
>>>>>>>> to
>>>>>>>> propose you as a committter for maintenance?
>>>>>>>>
>>>>>>>> Great progress though - the current Http service has served us pretty
>>>>>>>> well, but it's always been on the list to have cleaner and fuller
>>>>>>>> solution
>>>>>>>>
>>>>>>>> -- Rob
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>>>>>>>>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
On Fri, Aug 28, 2009 at 10:43 PM, Richard S. Hall <he...@ungoverned.org>wrote:
> On 8/28/09 16:30, Felix Meschberger wrote:
>
>> Hi Sten,
>>
>> Looks bascially good (files as appropriate have the license headers, MD5
>> checksum matches).
>>
>> Just two remarks:
>>
>> * The pom.xml should also have the license headers
>> (this can probably be fixed when we import into SVN)
>>
>> * there is a runner folder containing scripts and the
>> pax runner library.
>> This should probably not be included, right ?
>> (again, I think we can start the process and just omit
>> this directory when importing into SVN)
>>
>> As part of the IP-process we also need an ICLA of you, Sten, on file. I
>> see there is one for Sten Roger Sanvik with email srs@xbm.com. Am I
>> correct to assume, that this is your ICLA ?
>>
>> Thanks again for your submission, I will now start the process of
>> getting this into Felix SVN.
>>
>>
>
> Which will require Sten to fill out a Software Grant, which may need to
> come from his employer if it is actually the employer who is contributing
> the code.
No, it does not need to be from my employer. Been coding this in my spare
time. It has been used at Enonic (my current workplace) in form of some
binaries. So a grant from Enonic is not neccessary. But will be happy to
provide one if you really need it.
>
>
> -> richard
>
>
> Regards
>> Felix
>>
>>
>> Sten Roger Sandvik schrieb:
>>
>>
>>> Attached the source in the jira task (
>>> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what
>>> format
>>> that the attachement should be, but created a tar.gz file. Attached a md5
>>> checksum for the package.
>>>
>>> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik<sr...@x3m.com> wrote:
>>>
>>>
>>>
>>>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall<heavy@ungoverned.org
>>>> >wrote:
>>>>
>>>>
>>>>
>>>>> On 8/28/09 4:36, Felix Meschberger wrote:
>>>>>
>>>>>
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> Rob Walker schrieb:
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> What do we need to do make this happen guys?
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>> The next steps are IIRC the following:
>>>>>>
>>>>>> * Sten packages the source and attaches the package to
>>>>>> the issue and publishes a package checksum.
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> I will add to this, removes any existing header/copyright notices from
>>>>> the
>>>>> files and adds the standard Apache header (see any Felix Java file).
>>>>> Package
>>>>> renaming is not necessary at this point.
>>>>>
>>>>>
>>>>>
>>>> Have added apache (2.0) on top of all files. Will now create a tarball
>>>> and
>>>> add it to the JIRA task. I'm also interested in getting committer rights
>>>> so
>>>> that I can still maintain the code. Will that be handled in a seperate
>>>> vote?
>>>>
>>>>
>>>>
>>>>
>>>>> * We vote on accepting this submission
>>>>>
>>>>>
>>>>>> * We do the IP-clearance (filling out a form,
>>>>>> sending a mail to incubator@ and wait for 72h)
>>>>>> * Add the code into the SVN
>>>>>>
>>>>>> I think, we also need someone from the PMC to drive this process.
>>>>>>
>>>>>> Any volunteers (I could do it) ?
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> I am happy to have you do it. :-)
>>>>>
>>>>> Of course, I can help if needed.
>>>>>
>>>>> -> richard
>>>>>
>>>>>
>>>>> Regards
>>>>>
>>>>>
>>>>>> Felix
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>> Sten - sounds like you've done a great job, kudos.
>>>>>>>
>>>>>>> Felix/Marcel - sounds like you guys are happy with the approach and
>>>>>>> code
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>> From our side, we can certainly run some "real world" compatibility
>>>>>>>>
>>>>>>>>
>>>>>>> tests - which isn't to say in fact that Sten's new service would be
>>>>>>> wrong and the current one right, just whether thenew version breaks
>>>>>>> anything present in the exisiting service. If it does, I'm sure it'll
>>>>>>> either be fixable, or something that's actually not correct in the
>>>>>>> current service - so not a major issue. It'll be useful though to be
>>>>>>> able to advise other Felix guys of anything that might differ and
>>>>>>> need
>>>>>>> application changes. I'm happy to make time to look at this next
>>>>>>> week.
>>>>>>>
>>>>>>> After that - do we just call a vote? I'm guessing Sten, we also need
>>>>>>> to
>>>>>>> propose you as a committter for maintenance?
>>>>>>>
>>>>>>> Great progress though - the current Http service has served us pretty
>>>>>>> well, but it's always been on the list to have cleaner and fuller
>>>>>>> solution
>>>>>>>
>>>>>>> -- Rob
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>>
>>>>>>
>>>
>>
Re: Felix HttpService improvement...
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 8/28/09 16:30, Felix Meschberger wrote:
> Hi Sten,
>
> Looks bascially good (files as appropriate have the license headers, MD5
> checksum matches).
>
> Just two remarks:
>
> * The pom.xml should also have the license headers
> (this can probably be fixed when we import into SVN)
>
> * there is a runner folder containing scripts and the
> pax runner library.
> This should probably not be included, right ?
> (again, I think we can start the process and just omit
> this directory when importing into SVN)
>
> As part of the IP-process we also need an ICLA of you, Sten, on file. I
> see there is one for Sten Roger Sanvik with email srs@xbm.com. Am I
> correct to assume, that this is your ICLA ?
>
> Thanks again for your submission, I will now start the process of
> getting this into Felix SVN.
>
Which will require Sten to fill out a Software Grant, which may need to
come from his employer if it is actually the employer who is
contributing the code.
-> richard
> Regards
> Felix
>
>
> Sten Roger Sandvik schrieb:
>
>> Attached the source in the jira task (
>> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what format
>> that the attachement should be, but created a tar.gz file. Attached a md5
>> checksum for the package.
>>
>> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik<sr...@x3m.com> wrote:
>>
>>
>>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall<he...@ungoverned.org>wrote:
>>>
>>>
>>>> On 8/28/09 4:36, Felix Meschberger wrote:
>>>>
>>>>
>>>>> Hi,
>>>>>
>>>>> Rob Walker schrieb:
>>>>>
>>>>>
>>>>>
>>>>>> What do we need to do make this happen guys?
>>>>>>
>>>>>>
>>>>>>
>>>>> The next steps are IIRC the following:
>>>>>
>>>>> * Sten packages the source and attaches the package to
>>>>> the issue and publishes a package checksum.
>>>>>
>>>>>
>>>>>
>>>> I will add to this, removes any existing header/copyright notices from the
>>>> files and adds the standard Apache header (see any Felix Java file). Package
>>>> renaming is not necessary at this point.
>>>>
>>>>
>>> Have added apache (2.0) on top of all files. Will now create a tarball and
>>> add it to the JIRA task. I'm also interested in getting committer rights so
>>> that I can still maintain the code. Will that be handled in a seperate vote?
>>>
>>>
>>>
>>>> * We vote on accepting this submission
>>>>
>>>>> * We do the IP-clearance (filling out a form,
>>>>> sending a mail to incubator@ and wait for 72h)
>>>>> * Add the code into the SVN
>>>>>
>>>>> I think, we also need someone from the PMC to drive this process.
>>>>>
>>>>> Any volunteers (I could do it) ?
>>>>>
>>>>>
>>>>>
>>>> I am happy to have you do it. :-)
>>>>
>>>> Of course, I can help if needed.
>>>>
>>>> -> richard
>>>>
>>>>
>>>> Regards
>>>>
>>>>> Felix
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>> Sten - sounds like you've done a great job, kudos.
>>>>>>
>>>>>> Felix/Marcel - sounds like you guys are happy with the approach and code
>>>>>>
>>>>>>
>>>>>>> From our side, we can certainly run some "real world" compatibility
>>>>>>>
>>>>>> tests - which isn't to say in fact that Sten's new service would be
>>>>>> wrong and the current one right, just whether thenew version breaks
>>>>>> anything present in the exisiting service. If it does, I'm sure it'll
>>>>>> either be fixable, or something that's actually not correct in the
>>>>>> current service - so not a major issue. It'll be useful though to be
>>>>>> able to advise other Felix guys of anything that might differ and need
>>>>>> application changes. I'm happy to make time to look at this next week.
>>>>>>
>>>>>> After that - do we just call a vote? I'm guessing Sten, we also need to
>>>>>> propose you as a committter for maintenance?
>>>>>>
>>>>>> Great progress though - the current Http service has served us pretty
>>>>>> well, but it's always been on the list to have cleaner and fuller
>>>>>> solution
>>>>>>
>>>>>> -- Rob
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>
Re: Felix HttpService improvement...
Posted by Felix Meschberger <fm...@gmail.com>.
Hi Sten,
Looks bascially good (files as appropriate have the license headers, MD5
checksum matches).
Just two remarks:
* The pom.xml should also have the license headers
(this can probably be fixed when we import into SVN)
* there is a runner folder containing scripts and the
pax runner library.
This should probably not be included, right ?
(again, I think we can start the process and just omit
this directory when importing into SVN)
As part of the IP-process we also need an ICLA of you, Sten, on file. I
see there is one for Sten Roger Sanvik with email srs@xbm.com. Am I
correct to assume, that this is your ICLA ?
Thanks again for your submission, I will now start the process of
getting this into Felix SVN.
Regards
Felix
Sten Roger Sandvik schrieb:
> Attached the source in the jira task (
> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what format
> that the attachement should be, but created a tar.gz file. Attached a md5
> checksum for the package.
>
> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik <sr...@x3m.com> wrote:
>
>>
>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall <he...@ungoverned.org>wrote:
>>
>>> On 8/28/09 4:36, Felix Meschberger wrote:
>>>
>>>> Hi,
>>>>
>>>> Rob Walker schrieb:
>>>>
>>>>
>>>>> What do we need to do make this happen guys?
>>>>>
>>>>>
>>>> The next steps are IIRC the following:
>>>>
>>>> * Sten packages the source and attaches the package to
>>>> the issue and publishes a package checksum.
>>>>
>>>>
>>> I will add to this, removes any existing header/copyright notices from the
>>> files and adds the standard Apache header (see any Felix Java file). Package
>>> renaming is not necessary at this point.
>>>
>> Have added apache (2.0) on top of all files. Will now create a tarball and
>> add it to the JIRA task. I'm also interested in getting committer rights so
>> that I can still maintain the code. Will that be handled in a seperate vote?
>>
>>
>>>
>>> * We vote on accepting this submission
>>>> * We do the IP-clearance (filling out a form,
>>>> sending a mail to incubator@ and wait for 72h)
>>>> * Add the code into the SVN
>>>>
>>>> I think, we also need someone from the PMC to drive this process.
>>>>
>>>> Any volunteers (I could do it) ?
>>>>
>>>>
>>> I am happy to have you do it. :-)
>>>
>>> Of course, I can help if needed.
>>>
>>> -> richard
>>>
>>>
>>> Regards
>>>> Felix
>>>>
>>>>
>>>>
>>>>> Sten - sounds like you've done a great job, kudos.
>>>>>
>>>>> Felix/Marcel - sounds like you guys are happy with the approach and code
>>>>>
>>>>>> From our side, we can certainly run some "real world" compatibility
>>>>> tests - which isn't to say in fact that Sten's new service would be
>>>>> wrong and the current one right, just whether thenew version breaks
>>>>> anything present in the exisiting service. If it does, I'm sure it'll
>>>>> either be fixable, or something that's actually not correct in the
>>>>> current service - so not a major issue. It'll be useful though to be
>>>>> able to advise other Felix guys of anything that might differ and need
>>>>> application changes. I'm happy to make time to look at this next week.
>>>>>
>>>>> After that - do we just call a vote? I'm guessing Sten, we also need to
>>>>> propose you as a committter for maintenance?
>>>>>
>>>>> Great progress though - the current Http service has served us pretty
>>>>> well, but it's always been on the list to have cleaner and fuller
>>>>> solution
>>>>>
>>>>> -- Rob
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>
Re: Felix HttpService improvement...
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 8/28/09 13:48, Sten Roger Sandvik wrote:
> Attached the source in the jira task (
> https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what format
> that the attachement should be, but created a tar.gz file. Attached a md5
> checksum for the package.
>
That's fine.
-> richard
> On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik<sr...@x3m.com> wrote:
>
>
>>
>> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall<he...@ungoverned.org>wrote:
>>
>>
>>> On 8/28/09 4:36, Felix Meschberger wrote:
>>>
>>>
>>>> Hi,
>>>>
>>>> Rob Walker schrieb:
>>>>
>>>>
>>>>
>>>>> What do we need to do make this happen guys?
>>>>>
>>>>>
>>>>>
>>>> The next steps are IIRC the following:
>>>>
>>>> * Sten packages the source and attaches the package to
>>>> the issue and publishes a package checksum.
>>>>
>>>>
>>>>
>>> I will add to this, removes any existing header/copyright notices from the
>>> files and adds the standard Apache header (see any Felix Java file). Package
>>> renaming is not necessary at this point.
>>>
>>>
>> Have added apache (2.0) on top of all files. Will now create a tarball and
>> add it to the JIRA task. I'm also interested in getting committer rights so
>> that I can still maintain the code. Will that be handled in a seperate vote?
>>
>>
>>
>>>
>>> * We vote on accepting this submission
>>>
>>>> * We do the IP-clearance (filling out a form,
>>>> sending a mail to incubator@ and wait for 72h)
>>>> * Add the code into the SVN
>>>>
>>>>
>>>
>>>> I think, we also need someone from the PMC to drive this process.
>>>>
>>>> Any volunteers (I could do it) ?
>>>>
>>>>
>>>>
>>> I am happy to have you do it. :-)
>>>
>>> Of course, I can help if needed.
>>>
>>> -> richard
>>>
>>>
>>> Regards
>>>
>>>> Felix
>>>>
>>>>
>>>>
>>>>
>>>>> Sten - sounds like you've done a great job, kudos.
>>>>>
>>>>> Felix/Marcel - sounds like you guys are happy with the approach and code
>>>>>
>>>>>
>>>>>> From our side, we can certainly run some "real world" compatibility
>>>>>>
>>>>> tests - which isn't to say in fact that Sten's new service would be
>>>>> wrong and the current one right, just whether thenew version breaks
>>>>> anything present in the exisiting service. If it does, I'm sure it'll
>>>>> either be fixable, or something that's actually not correct in the
>>>>> current service - so not a major issue. It'll be useful though to be
>>>>> able to advise other Felix guys of anything that might differ and need
>>>>> application changes. I'm happy to make time to look at this next week.
>>>>>
>>>>> After that - do we just call a vote? I'm guessing Sten, we also need to
>>>>> propose you as a committter for maintenance?
>>>>>
>>>>> Great progress though - the current Http service has served us pretty
>>>>> well, but it's always been on the list to have cleaner and fuller
>>>>> solution
>>>>>
>>>>> -- Rob
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>>
>>>>
>>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
Attached the source in the jira task (
https://issues.apache.org/jira/browse/FELIX-1456). Not sure on what format
that the attachement should be, but created a tar.gz file. Attached a md5
checksum for the package.
On Fri, Aug 28, 2009 at 7:29 PM, Sten Roger Sandvik <sr...@x3m.com> wrote:
>
>
> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall <he...@ungoverned.org>wrote:
>
>> On 8/28/09 4:36, Felix Meschberger wrote:
>>
>>> Hi,
>>>
>>> Rob Walker schrieb:
>>>
>>>
>>>> What do we need to do make this happen guys?
>>>>
>>>>
>>> The next steps are IIRC the following:
>>>
>>> * Sten packages the source and attaches the package to
>>> the issue and publishes a package checksum.
>>>
>>>
>>
>> I will add to this, removes any existing header/copyright notices from the
>> files and adds the standard Apache header (see any Felix Java file). Package
>> renaming is not necessary at this point.
>>
>
> Have added apache (2.0) on top of all files. Will now create a tarball and
> add it to the JIRA task. I'm also interested in getting committer rights so
> that I can still maintain the code. Will that be handled in a seperate vote?
>
>
>>
>>
>> * We vote on accepting this submission
>>> * We do the IP-clearance (filling out a form,
>>> sending a mail to incubator@ and wait for 72h)
>>> * Add the code into the SVN
>>>
>>
>>> I think, we also need someone from the PMC to drive this process.
>>>
>>> Any volunteers (I could do it) ?
>>>
>>>
>>
>> I am happy to have you do it. :-)
>>
>> Of course, I can help if needed.
>>
>> -> richard
>>
>>
>> Regards
>>> Felix
>>>
>>>
>>>
>>>> Sten - sounds like you've done a great job, kudos.
>>>>
>>>> Felix/Marcel - sounds like you guys are happy with the approach and code
>>>>
>>>> > From our side, we can certainly run some "real world" compatibility
>>>> tests - which isn't to say in fact that Sten's new service would be
>>>> wrong and the current one right, just whether thenew version breaks
>>>> anything present in the exisiting service. If it does, I'm sure it'll
>>>> either be fixable, or something that's actually not correct in the
>>>> current service - so not a major issue. It'll be useful though to be
>>>> able to advise other Felix guys of anything that might differ and need
>>>> application changes. I'm happy to make time to look at this next week.
>>>>
>>>> After that - do we just call a vote? I'm guessing Sten, we also need to
>>>> propose you as a committter for maintenance?
>>>>
>>>> Great progress though - the current Http service has served us pretty
>>>> well, but it's always been on the list to have cleaner and fuller
>>>> solution
>>>>
>>>> -- Rob
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>
Re: Felix HttpService improvement...
Posted by Felix Meschberger <fm...@gmail.com>.
Hi Sten,
Sten Roger Sandvik schrieb:
> I think you can move forward with the current CLA that has been submitted
> since this code is done outside the company. But for further work I have
> requested that the company send in a CLA (this will be done today or
> tomorrow). Is that ok?
Excellent.
And, yes, I planned launching the vote today.
Regards
Felix
>
> On Sun, Aug 30, 2009 at 6:36 PM, Felix Meschberger <fm...@gmail.com>wrote:
>
>> Hi Sten,
>>
>> Excellent. Thanks. I quickly checked it and confirm it is ok now.
>>
>> Regards
>> Felix
>>
>> Sten Roger Sandvik schrieb:
>>> Modified the inclusion slightly. Added missing license headers to
>> pom.xml's.
>>> Removed pax-runner binaries and directory. Deleted old attachements from
>>> jira so the current is the only one there.
>>>
>>> On Sat, Aug 29, 2009 at 10:53 PM, Felix Meschberger <fmeschbe@gmail.com
>>> wrote:
>>>
>>>> Hi Filippo,
>>>>
>>>> Filippo Diotalevi schrieb:
>>>>> On Fri, Aug 28, 2009 at 10:36 AM, Felix Meschberger<fmeschbe@gmail.com
>>>> wrote:
>>>>>> Hi,
>>>>>>
>>>>>> Rob Walker schrieb:
>>>>>>> What do we need to do make this happen guys?
>>>>>> The next steps are IIRC the following:
>>>>>> [...]
>>>>>> I think, we also need someone from the PMC to drive this process.
>>>>>>
>>>>>> Any volunteers (I could do it) ?
>>>>> Hi Felix,
>>>>> I'm no PMC member, but I have commit rights (and some applications
>>>>> using Pax-Web and the current Felix HTTP Service that I'd like to try
>>>>> with the new bundle). So I'll be glad to help as soon as the code
>>>>> donation is approved.
>>>> Cool. Thanks. Any help is welcome.
>>>>
>>>> I will come back to you after the IP-clearance has been done (this must
>>>> be done by the PMC Chair or an ASF member).
>>>>
>>>> Regards
>>>> Felix
>>>>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
I think you can move forward with the current CLA that has been submitted
since this code is done outside the company. But for further work I have
requested that the company send in a CLA (this will be done today or
tomorrow). Is that ok?
On Sun, Aug 30, 2009 at 6:36 PM, Felix Meschberger <fm...@gmail.com>wrote:
> Hi Sten,
>
> Excellent. Thanks. I quickly checked it and confirm it is ok now.
>
> Regards
> Felix
>
> Sten Roger Sandvik schrieb:
> > Modified the inclusion slightly. Added missing license headers to
> pom.xml's.
> > Removed pax-runner binaries and directory. Deleted old attachements from
> > jira so the current is the only one there.
> >
> > On Sat, Aug 29, 2009 at 10:53 PM, Felix Meschberger <fmeschbe@gmail.com
> >wrote:
> >
> >> Hi Filippo,
> >>
> >> Filippo Diotalevi schrieb:
> >>> On Fri, Aug 28, 2009 at 10:36 AM, Felix Meschberger<fmeschbe@gmail.com
> >
> >> wrote:
> >>>> Hi,
> >>>>
> >>>> Rob Walker schrieb:
> >>>>> What do we need to do make this happen guys?
> >>>> The next steps are IIRC the following:
> >>>> [...]
> >>>> I think, we also need someone from the PMC to drive this process.
> >>>>
> >>>> Any volunteers (I could do it) ?
> >>> Hi Felix,
> >>> I'm no PMC member, but I have commit rights (and some applications
> >>> using Pax-Web and the current Felix HTTP Service that I'd like to try
> >>> with the new bundle). So I'll be glad to help as soon as the code
> >>> donation is approved.
> >> Cool. Thanks. Any help is welcome.
> >>
> >> I will come back to you after the IP-clearance has been done (this must
> >> be done by the PMC Chair or an ASF member).
> >>
> >> Regards
> >> Felix
> >>
> >
>
Re: Felix HttpService improvement...
Posted by Felix Meschberger <fm...@gmail.com>.
Hi Sten,
Excellent. Thanks. I quickly checked it and confirm it is ok now.
Regards
Felix
Sten Roger Sandvik schrieb:
> Modified the inclusion slightly. Added missing license headers to pom.xml's.
> Removed pax-runner binaries and directory. Deleted old attachements from
> jira so the current is the only one there.
>
> On Sat, Aug 29, 2009 at 10:53 PM, Felix Meschberger <fm...@gmail.com>wrote:
>
>> Hi Filippo,
>>
>> Filippo Diotalevi schrieb:
>>> On Fri, Aug 28, 2009 at 10:36 AM, Felix Meschberger<fm...@gmail.com>
>> wrote:
>>>> Hi,
>>>>
>>>> Rob Walker schrieb:
>>>>> What do we need to do make this happen guys?
>>>> The next steps are IIRC the following:
>>>> [...]
>>>> I think, we also need someone from the PMC to drive this process.
>>>>
>>>> Any volunteers (I could do it) ?
>>> Hi Felix,
>>> I'm no PMC member, but I have commit rights (and some applications
>>> using Pax-Web and the current Felix HTTP Service that I'd like to try
>>> with the new bundle). So I'll be glad to help as soon as the code
>>> donation is approved.
>> Cool. Thanks. Any help is welcome.
>>
>> I will come back to you after the IP-clearance has been done (this must
>> be done by the PMC Chair or an ASF member).
>>
>> Regards
>> Felix
>>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
Modified the inclusion slightly. Added missing license headers to pom.xml's.
Removed pax-runner binaries and directory. Deleted old attachements from
jira so the current is the only one there.
On Sat, Aug 29, 2009 at 10:53 PM, Felix Meschberger <fm...@gmail.com>wrote:
> Hi Filippo,
>
> Filippo Diotalevi schrieb:
> > On Fri, Aug 28, 2009 at 10:36 AM, Felix Meschberger<fm...@gmail.com>
> wrote:
> >> Hi,
> >>
> >> Rob Walker schrieb:
> >>> What do we need to do make this happen guys?
> >> The next steps are IIRC the following:
> >> [...]
> >> I think, we also need someone from the PMC to drive this process.
> >>
> >> Any volunteers (I could do it) ?
> >
> > Hi Felix,
> > I'm no PMC member, but I have commit rights (and some applications
> > using Pax-Web and the current Felix HTTP Service that I'd like to try
> > with the new bundle). So I'll be glad to help as soon as the code
> > donation is approved.
>
> Cool. Thanks. Any help is welcome.
>
> I will come back to you after the IP-clearance has been done (this must
> be done by the PMC Chair or an ASF member).
>
> Regards
> Felix
>
Re: Felix HttpService improvement...
Posted by Felix Meschberger <fm...@gmail.com>.
Hi Filippo,
Filippo Diotalevi schrieb:
> On Fri, Aug 28, 2009 at 10:36 AM, Felix Meschberger<fm...@gmail.com> wrote:
>> Hi,
>>
>> Rob Walker schrieb:
>>> What do we need to do make this happen guys?
>> The next steps are IIRC the following:
>> [...]
>> I think, we also need someone from the PMC to drive this process.
>>
>> Any volunteers (I could do it) ?
>
> Hi Felix,
> I'm no PMC member, but I have commit rights (and some applications
> using Pax-Web and the current Felix HTTP Service that I'd like to try
> with the new bundle). So I'll be glad to help as soon as the code
> donation is approved.
Cool. Thanks. Any help is welcome.
I will come back to you after the IP-clearance has been done (this must
be done by the PMC Chair or an ASF member).
Regards
Felix
Re: Felix HttpService improvement...
Posted by Filippo Diotalevi <fi...@gmail.com>.
On Fri, Aug 28, 2009 at 10:36 AM, Felix Meschberger<fm...@gmail.com> wrote:
> Hi,
>
> Rob Walker schrieb:
>> What do we need to do make this happen guys?
>
> The next steps are IIRC the following:
> [...]
> I think, we also need someone from the PMC to drive this process.
>
> Any volunteers (I could do it) ?
Hi Felix,
I'm no PMC member, but I have commit rights (and some applications
using Pax-Web and the current Felix HTTP Service that I'd like to try
with the new bundle). So I'll be glad to help as soon as the code
donation is approved.
--
Filippo Diotalevi
Re: Felix HttpService improvement...
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 8/28/09 13:29, Sten Roger Sandvik wrote:
> On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall<he...@ungoverned.org>wrote:
>
>
>> On 8/28/09 4:36, Felix Meschberger wrote:
>>
>>
>>> Hi,
>>>
>>> Rob Walker schrieb:
>>>
>>>
>>>
>>>> What do we need to do make this happen guys?
>>>>
>>>>
>>>>
>>> The next steps are IIRC the following:
>>>
>>> * Sten packages the source and attaches the package to
>>> the issue and publishes a package checksum.
>>>
>>>
>>>
>> I will add to this, removes any existing header/copyright notices from the
>> files and adds the standard Apache header (see any Felix Java file). Package
>> renaming is not necessary at this point.
>>
>>
> Have added apache (2.0) on top of all files. Will now create a tarball and
> add it to the JIRA task. I'm also interested in getting committer rights so
> that I can still maintain the code. Will that be handled in a seperate vote?
>
Yes, on the private mailing list.
-> richard
>
>
>>
>> * We vote on accepting this submission
>>
>>> * We do the IP-clearance (filling out a form,
>>> sending a mail to incubator@ and wait for 72h)
>>> * Add the code into the SVN
>>>
>>>
>>
>>> I think, we also need someone from the PMC to drive this process.
>>>
>>> Any volunteers (I could do it) ?
>>>
>>>
>>>
>> I am happy to have you do it. :-)
>>
>> Of course, I can help if needed.
>>
>> -> richard
>>
>>
>> Regards
>>
>>> Felix
>>>
>>>
>>>
>>>
>>>> Sten - sounds like you've done a great job, kudos.
>>>>
>>>> Felix/Marcel - sounds like you guys are happy with the approach and code
>>>>
>>>>
>>>>> From our side, we can certainly run some "real world" compatibility
>>>>>
>>>> tests - which isn't to say in fact that Sten's new service would be
>>>> wrong and the current one right, just whether thenew version breaks
>>>> anything present in the exisiting service. If it does, I'm sure it'll
>>>> either be fixable, or something that's actually not correct in the
>>>> current service - so not a major issue. It'll be useful though to be
>>>> able to advise other Felix guys of anything that might differ and need
>>>> application changes. I'm happy to make time to look at this next week.
>>>>
>>>> After that - do we just call a vote? I'm guessing Sten, we also need to
>>>> propose you as a committter for maintenance?
>>>>
>>>> Great progress though - the current Http service has served us pretty
>>>> well, but it's always been on the list to have cleaner and fuller
>>>> solution
>>>>
>>>> -- Rob
>>>>
>>>>
>>>>
>>>>
>>>>
>>>>
>>>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
On Fri, Aug 28, 2009 at 4:05 PM, Richard S. Hall <he...@ungoverned.org>wrote:
> On 8/28/09 4:36, Felix Meschberger wrote:
>
>> Hi,
>>
>> Rob Walker schrieb:
>>
>>
>>> What do we need to do make this happen guys?
>>>
>>>
>> The next steps are IIRC the following:
>>
>> * Sten packages the source and attaches the package to
>> the issue and publishes a package checksum.
>>
>>
>
> I will add to this, removes any existing header/copyright notices from the
> files and adds the standard Apache header (see any Felix Java file). Package
> renaming is not necessary at this point.
>
Have added apache (2.0) on top of all files. Will now create a tarball and
add it to the JIRA task. I'm also interested in getting committer rights so
that I can still maintain the code. Will that be handled in a seperate vote?
>
>
> * We vote on accepting this submission
>> * We do the IP-clearance (filling out a form,
>> sending a mail to incubator@ and wait for 72h)
>> * Add the code into the SVN
>>
>
>> I think, we also need someone from the PMC to drive this process.
>>
>> Any volunteers (I could do it) ?
>>
>>
>
> I am happy to have you do it. :-)
>
> Of course, I can help if needed.
>
> -> richard
>
>
> Regards
>> Felix
>>
>>
>>
>>> Sten - sounds like you've done a great job, kudos.
>>>
>>> Felix/Marcel - sounds like you guys are happy with the approach and code
>>>
>>> > From our side, we can certainly run some "real world" compatibility
>>> tests - which isn't to say in fact that Sten's new service would be
>>> wrong and the current one right, just whether thenew version breaks
>>> anything present in the exisiting service. If it does, I'm sure it'll
>>> either be fixable, or something that's actually not correct in the
>>> current service - so not a major issue. It'll be useful though to be
>>> able to advise other Felix guys of anything that might differ and need
>>> application changes. I'm happy to make time to look at this next week.
>>>
>>> After that - do we just call a vote? I'm guessing Sten, we also need to
>>> propose you as a committter for maintenance?
>>>
>>> Great progress though - the current Http service has served us pretty
>>> well, but it's always been on the list to have cleaner and fuller
>>> solution
>>>
>>> -- Rob
>>>
>>>
>>>
>>>
>>>
>>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
Will look at that and see how to include it. It's not going in right now,
since my first priority is to get it up in felix svn.
BR,
Sten Roger
On Fri, Aug 28, 2009 at 5:46 PM, Clement Escoffier <
clement.escoffier@gmail.com> wrote:
> Hi,
>
> Here is what we did :
> http://clement.plop-plop.net/comet/
>
> As you will see, it's quite simple, but has quite well worked.
>
> Regards,
>
> Clement
>
>
>
>
> On 28.08.2009, at 09:26, Sten Roger Sandvik wrote:
>
> Looked quickly at cometd and especially cometd-java. It looks to me that
>> this is trivial to include in the http service implementation. Will look
>> into this.
>>
>> On Fri, Aug 28, 2009 at 9:03 AM, Sten Roger Sandvik <sr...@x3m.com> wrote:
>>
>> The new http service is not testet alot. It's only been used in our own
>>> projects for now, but I will need to create more unit tests and some
>>> integration tests. As for comet support - I have tought of it, but have
>>> not
>>> come around to do it. I will gladly look at the "current" comet support
>>> to
>>> see if it's a trivial ting to include.
>>>
>>> Yes, it would be great to be included as a committer. I really like the
>>> Felix project and are really committed to create the best http service
>>> implementation out there :-)
>>>
>>> BR,
>>> Sten Roger
>>>
>>>
>>>
>>> On Fri, Aug 28, 2009 at 8:52 AM, Rob Walker <ro...@ascert.com> wrote:
>>>
>>> Good point - we also have a "home grown" cometd approach which we use
>>>> for
>>>> server push to our GWT application, so something built into the http
>>>> server
>>>> would definitely be of interest
>>>> - R
>>>>
>>>>
>>>> Clement Escoffier wrote:
>>>>
>>>> Hi,
>>>>>
>>>>> Just my 2 cents.
>>>>> any plan to support Cometd ?
>>>>>
>>>>> We slightly change the current HTTP Service to support Cometd. I don't
>>>>> see any issue to do the same on Sten's version.
>>>>> (of course, I can send what we quickly did).
>>>>>
>>>>>
>>>>> As a reminder, Cometd is an HTTP based MOM, allowing (after a
>>>>> handshake)
>>>>> a server to notify browser. In Ajax-based interaction, the client
>>>>> (periodically) query the server. With Comet, the server notifies the
>>>>> clients.
>>>>> As you can imagine, this is definitely important for dynamic web
>>>>> application.
>>>>>
>>>>> Regards,
>>>>>
>>>>> Clement
>>>>>
>>>>>
>>>>> On 28.08.2009, at 08:40, Rob Walker wrote:
>>>>>
>>>>> What do we need to do make this happen guys?
>>>>>
>>>>>>
>>>>>> Sten - sounds like you've done a great job, kudos.
>>>>>>
>>>>>> Felix/Marcel - sounds like you guys are happy with the approach and
>>>>>> code
>>>>>>
>>>>>> From our side, we can certainly run some "real world" compatibility
>>>>>>>
>>>>>> tests - which isn't to say in fact that Sten's new service would be
>>>>>> wrong
>>>>>> and the current one right, just whether thenew version breaks anything
>>>>>> present in the exisiting service. If it does, I'm sure it'll either be
>>>>>> fixable, or something that's actually not correct in the current
>>>>>> service -
>>>>>> so not a major issue. It'll be useful though to be able to advise
>>>>>> other
>>>>>> Felix guys of anything that might differ and need application changes.
>>>>>> I'm
>>>>>> happy to make time to look at this next week.
>>>>>>
>>>>>> After that - do we just call a vote? I'm guessing Sten, we also need
>>>>>> to
>>>>>> propose you as a committter for maintenance?
>>>>>>
>>>>>> Great progress though - the current Http service has served us pretty
>>>>>> well, but it's always been on the list to have cleaner and fuller
>>>>>> solution
>>>>>>
>>>>>> -- Rob
>>>>>>
>>>>>>
>>>>>>
>>>>>>
>>>>> --
>>>>
>>>>
>>>> Ascert - Taking systems to the Edge
>>>> robw@ascert.com
>>>> +44 (0)20 7488 3470
>>>> www.ascert.com
>>>>
>>>>
>>>>
>>>
>
Re: Felix HttpService improvement...
Posted by Clement Escoffier <cl...@gmail.com>.
Hi,
Here is what we did :
http://clement.plop-plop.net/comet/
As you will see, it's quite simple, but has quite well worked.
Regards,
Clement
On 28.08.2009, at 09:26, Sten Roger Sandvik wrote:
> Looked quickly at cometd and especially cometd-java. It looks to me
> that
> this is trivial to include in the http service implementation. Will
> look
> into this.
>
> On Fri, Aug 28, 2009 at 9:03 AM, Sten Roger Sandvik <sr...@x3m.com>
> wrote:
>
>> The new http service is not testet alot. It's only been used in our
>> own
>> projects for now, but I will need to create more unit tests and some
>> integration tests. As for comet support - I have tought of it, but
>> have not
>> come around to do it. I will gladly look at the "current" comet
>> support to
>> see if it's a trivial ting to include.
>>
>> Yes, it would be great to be included as a committer. I really like
>> the
>> Felix project and are really committed to create the best http
>> service
>> implementation out there :-)
>>
>> BR,
>> Sten Roger
>>
>>
>>
>> On Fri, Aug 28, 2009 at 8:52 AM, Rob Walker <ro...@ascert.com> wrote:
>>
>>> Good point - we also have a "home grown" cometd approach which we
>>> use for
>>> server push to our GWT application, so something built into the
>>> http server
>>> would definitely be of interest
>>> - R
>>>
>>>
>>> Clement Escoffier wrote:
>>>
>>>> Hi,
>>>>
>>>> Just my 2 cents.
>>>> any plan to support Cometd ?
>>>>
>>>> We slightly change the current HTTP Service to support Cometd. I
>>>> don't
>>>> see any issue to do the same on Sten's version.
>>>> (of course, I can send what we quickly did).
>>>>
>>>>
>>>> As a reminder, Cometd is an HTTP based MOM, allowing (after a
>>>> handshake)
>>>> a server to notify browser. In Ajax-based interaction, the client
>>>> (periodically) query the server. With Comet, the server notifies
>>>> the
>>>> clients.
>>>> As you can imagine, this is definitely important for dynamic web
>>>> application.
>>>>
>>>> Regards,
>>>>
>>>> Clement
>>>>
>>>>
>>>> On 28.08.2009, at 08:40, Rob Walker wrote:
>>>>
>>>> What do we need to do make this happen guys?
>>>>>
>>>>> Sten - sounds like you've done a great job, kudos.
>>>>>
>>>>> Felix/Marcel - sounds like you guys are happy with the approach
>>>>> and code
>>>>>
>>>>>> From our side, we can certainly run some "real world"
>>>>>> compatibility
>>>>> tests - which isn't to say in fact that Sten's new service would
>>>>> be wrong
>>>>> and the current one right, just whether thenew version breaks
>>>>> anything
>>>>> present in the exisiting service. If it does, I'm sure it'll
>>>>> either be
>>>>> fixable, or something that's actually not correct in the current
>>>>> service -
>>>>> so not a major issue. It'll be useful though to be able to
>>>>> advise other
>>>>> Felix guys of anything that might differ and need application
>>>>> changes. I'm
>>>>> happy to make time to look at this next week.
>>>>>
>>>>> After that - do we just call a vote? I'm guessing Sten, we also
>>>>> need to
>>>>> propose you as a committter for maintenance?
>>>>>
>>>>> Great progress though - the current Http service has served us
>>>>> pretty
>>>>> well, but it's always been on the list to have cleaner and
>>>>> fuller solution
>>>>>
>>>>> -- Rob
>>>>>
>>>>>
>>>>>
>>>>
>>> --
>>>
>>>
>>> Ascert - Taking systems to the Edge
>>> robw@ascert.com
>>> +44 (0)20 7488 3470
>>> www.ascert.com
>>>
>>>
>>
RE: Felix HttpService improvement...
Posted by "Moloney, Tim M" <Ti...@ManTech.com>.
Our application uses cometd so including this would be a welcomed
feature.
Tim Moloney The reasonable man adapts himself to
MRSL the world; the unreasonable one persists
2015 Cattlemen Road in trying to adapt the world to himself.
Sarasota, FL 34232 Therefore all progress depends on the
(941) 377-6775 x208 unreasonable man. George Bernard Shaw
> -----Original Message-----
> From: Sten Roger Sandvik [mailto:srs@x3m.com]
> Sent: Friday, August 28, 2009 03:27
> To: dev@felix.apache.org
> Subject: Re: Felix HttpService improvement...
>
> Looked quickly at cometd and especially cometd-java. It looks
> to me that
> this is trivial to include in the http service
> implementation. Will look
> into this.
>
> On Fri, Aug 28, 2009 at 9:03 AM, Sten Roger Sandvik
> <sr...@x3m.com> wrote:
>
> > The new http service is not testet alot. It's only been
> used in our own
> > projects for now, but I will need to create more unit tests and some
> > integration tests. As for comet support - I have tought of
> it, but have not
> > come around to do it. I will gladly look at the "current"
> comet support to
> > see if it's a trivial ting to include.
> >
> > Yes, it would be great to be included as a committer. I
> really like the
> > Felix project and are really committed to create the best
> http service
> > implementation out there :-)
> >
> > BR,
> > Sten Roger
> >
> >
> >
> > On Fri, Aug 28, 2009 at 8:52 AM, Rob Walker <ro...@ascert.com> wrote:
> >
> >> Good point - we also have a "home grown" cometd approach
> which we use for
> >> server push to our GWT application, so something built
> into the http server
> >> would definitely be of interest
> >> - R
> >>
> >>
> >> Clement Escoffier wrote:
> >>
> >>> Hi,
> >>>
> >>> Just my 2 cents.
> >>> any plan to support Cometd ?
> >>>
> >>> We slightly change the current HTTP Service to support
> Cometd. I don't
> >>> see any issue to do the same on Sten's version.
> >>> (of course, I can send what we quickly did).
> >>>
> >>>
> >>> As a reminder, Cometd is an HTTP based MOM, allowing
> (after a handshake)
> >>> a server to notify browser. In Ajax-based interaction, the client
> >>> (periodically) query the server. With Comet, the server
> notifies the
> >>> clients.
> >>> As you can imagine, this is definitely important for dynamic web
> >>> application.
> >>>
> >>> Regards,
> >>>
> >>> Clement
> >>>
> >>>
> >>> On 28.08.2009, at 08:40, Rob Walker wrote:
> >>>
> >>> What do we need to do make this happen guys?
> >>>>
> >>>> Sten - sounds like you've done a great job, kudos.
> >>>>
> >>>> Felix/Marcel - sounds like you guys are happy with the
> approach and code
> >>>>
> >>>> >From our side, we can certainly run some "real world"
> compatibility
> >>>> tests - which isn't to say in fact that Sten's new
> service would be wrong
> >>>> and the current one right, just whether thenew version
> breaks anything
> >>>> present in the exisiting service. If it does, I'm sure
> it'll either be
> >>>> fixable, or something that's actually not correct in the
> current service -
> >>>> so not a major issue. It'll be useful though to be able
> to advise other
> >>>> Felix guys of anything that might differ and need
> application changes. I'm
> >>>> happy to make time to look at this next week.
> >>>>
> >>>> After that - do we just call a vote? I'm guessing Sten,
> we also need to
> >>>> propose you as a committter for maintenance?
> >>>>
> >>>> Great progress though - the current Http service has
> served us pretty
> >>>> well, but it's always been on the list to have cleaner
> and fuller solution
> >>>>
> >>>> -- Rob
> >>>>
> >>>>
> >>>>
> >>>
> >> --
> >>
> >>
> >> Ascert - Taking systems to the Edge
> >> robw@ascert.com
> >> +44 (0)20 7488 3470
> >> www.ascert.com
> >>
> >>
> >
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
Looked quickly at cometd and especially cometd-java. It looks to me that
this is trivial to include in the http service implementation. Will look
into this.
On Fri, Aug 28, 2009 at 9:03 AM, Sten Roger Sandvik <sr...@x3m.com> wrote:
> The new http service is not testet alot. It's only been used in our own
> projects for now, but I will need to create more unit tests and some
> integration tests. As for comet support - I have tought of it, but have not
> come around to do it. I will gladly look at the "current" comet support to
> see if it's a trivial ting to include.
>
> Yes, it would be great to be included as a committer. I really like the
> Felix project and are really committed to create the best http service
> implementation out there :-)
>
> BR,
> Sten Roger
>
>
>
> On Fri, Aug 28, 2009 at 8:52 AM, Rob Walker <ro...@ascert.com> wrote:
>
>> Good point - we also have a "home grown" cometd approach which we use for
>> server push to our GWT application, so something built into the http server
>> would definitely be of interest
>> - R
>>
>>
>> Clement Escoffier wrote:
>>
>>> Hi,
>>>
>>> Just my 2 cents.
>>> any plan to support Cometd ?
>>>
>>> We slightly change the current HTTP Service to support Cometd. I don't
>>> see any issue to do the same on Sten's version.
>>> (of course, I can send what we quickly did).
>>>
>>>
>>> As a reminder, Cometd is an HTTP based MOM, allowing (after a handshake)
>>> a server to notify browser. In Ajax-based interaction, the client
>>> (periodically) query the server. With Comet, the server notifies the
>>> clients.
>>> As you can imagine, this is definitely important for dynamic web
>>> application.
>>>
>>> Regards,
>>>
>>> Clement
>>>
>>>
>>> On 28.08.2009, at 08:40, Rob Walker wrote:
>>>
>>> What do we need to do make this happen guys?
>>>>
>>>> Sten - sounds like you've done a great job, kudos.
>>>>
>>>> Felix/Marcel - sounds like you guys are happy with the approach and code
>>>>
>>>> >From our side, we can certainly run some "real world" compatibility
>>>> tests - which isn't to say in fact that Sten's new service would be wrong
>>>> and the current one right, just whether thenew version breaks anything
>>>> present in the exisiting service. If it does, I'm sure it'll either be
>>>> fixable, or something that's actually not correct in the current service -
>>>> so not a major issue. It'll be useful though to be able to advise other
>>>> Felix guys of anything that might differ and need application changes. I'm
>>>> happy to make time to look at this next week.
>>>>
>>>> After that - do we just call a vote? I'm guessing Sten, we also need to
>>>> propose you as a committter for maintenance?
>>>>
>>>> Great progress though - the current Http service has served us pretty
>>>> well, but it's always been on the list to have cleaner and fuller solution
>>>>
>>>> -- Rob
>>>>
>>>>
>>>>
>>>
>> --
>>
>>
>> Ascert - Taking systems to the Edge
>> robw@ascert.com
>> +44 (0)20 7488 3470
>> www.ascert.com
>>
>>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
The new http service is not testet alot. It's only been used in our own
projects for now, but I will need to create more unit tests and some
integration tests. As for comet support - I have tought of it, but have not
come around to do it. I will gladly look at the "current" comet support to
see if it's a trivial ting to include.
Yes, it would be great to be included as a committer. I really like the
Felix project and are really committed to create the best http service
implementation out there :-)
BR,
Sten Roger
On Fri, Aug 28, 2009 at 8:52 AM, Rob Walker <ro...@ascert.com> wrote:
> Good point - we also have a "home grown" cometd approach which we use for
> server push to our GWT application, so something built into the http server
> would definitely be of interest
> - R
>
>
> Clement Escoffier wrote:
>
>> Hi,
>>
>> Just my 2 cents.
>> any plan to support Cometd ?
>>
>> We slightly change the current HTTP Service to support Cometd. I don't see
>> any issue to do the same on Sten's version.
>> (of course, I can send what we quickly did).
>>
>>
>> As a reminder, Cometd is an HTTP based MOM, allowing (after a handshake) a
>> server to notify browser. In Ajax-based interaction, the client
>> (periodically) query the server. With Comet, the server notifies the
>> clients.
>> As you can imagine, this is definitely important for dynamic web
>> application.
>>
>> Regards,
>>
>> Clement
>>
>>
>> On 28.08.2009, at 08:40, Rob Walker wrote:
>>
>> What do we need to do make this happen guys?
>>>
>>> Sten - sounds like you've done a great job, kudos.
>>>
>>> Felix/Marcel - sounds like you guys are happy with the approach and code
>>>
>>> >From our side, we can certainly run some "real world" compatibility
>>> tests - which isn't to say in fact that Sten's new service would be wrong
>>> and the current one right, just whether thenew version breaks anything
>>> present in the exisiting service. If it does, I'm sure it'll either be
>>> fixable, or something that's actually not correct in the current service -
>>> so not a major issue. It'll be useful though to be able to advise other
>>> Felix guys of anything that might differ and need application changes. I'm
>>> happy to make time to look at this next week.
>>>
>>> After that - do we just call a vote? I'm guessing Sten, we also need to
>>> propose you as a committter for maintenance?
>>>
>>> Great progress though - the current Http service has served us pretty
>>> well, but it's always been on the list to have cleaner and fuller solution
>>>
>>> -- Rob
>>>
>>>
>>>
>>
> --
>
>
> Ascert - Taking systems to the Edge
> robw@ascert.com
> +44 (0)20 7488 3470
> www.ascert.com
>
>
Re: Felix HttpService improvement...
Posted by Rob Walker <ro...@ascert.com>.
Good point - we also have a "home grown" cometd approach which we use
for server push to our GWT application, so something built into the http
server would definitely be of interest
- R
Clement Escoffier wrote:
> Hi,
>
> Just my 2 cents.
> any plan to support Cometd ?
>
> We slightly change the current HTTP Service to support Cometd. I don't
> see any issue to do the same on Sten's version.
> (of course, I can send what we quickly did).
>
>
> As a reminder, Cometd is an HTTP based MOM, allowing (after a
> handshake) a server to notify browser. In Ajax-based interaction, the
> client (periodically) query the server. With Comet, the server
> notifies the clients.
> As you can imagine, this is definitely important for dynamic web
> application.
>
> Regards,
>
> Clement
>
>
> On 28.08.2009, at 08:40, Rob Walker wrote:
>
>> What do we need to do make this happen guys?
>>
>> Sten - sounds like you've done a great job, kudos.
>>
>> Felix/Marcel - sounds like you guys are happy with the approach and code
>>
>> >From our side, we can certainly run some "real world" compatibility
>> tests - which isn't to say in fact that Sten's new service would be
>> wrong and the current one right, just whether thenew version breaks
>> anything present in the exisiting service. If it does, I'm sure it'll
>> either be fixable, or something that's actually not correct in the
>> current service - so not a major issue. It'll be useful though to be
>> able to advise other Felix guys of anything that might differ and
>> need application changes. I'm happy to make time to look at this
>> next week.
>>
>> After that - do we just call a vote? I'm guessing Sten, we also need
>> to propose you as a committter for maintenance?
>>
>> Great progress though - the current Http service has served us pretty
>> well, but it's always been on the list to have cleaner and fuller
>> solution
>>
>> -- Rob
>>
>>
>
--
Ascert - Taking systems to the Edge
robw@ascert.com
+44 (0)20 7488 3470
www.ascert.com
Re: Felix HttpService improvement...
Posted by Clement Escoffier <cl...@gmail.com>.
Hi,
Just my 2 cents.
any plan to support Cometd ?
We slightly change the current HTTP Service to support Cometd. I don't
see any issue to do the same on Sten's version.
(of course, I can send what we quickly did).
As a reminder, Cometd is an HTTP based MOM, allowing (after a
handshake) a server to notify browser. In Ajax-based interaction, the
client (periodically) query the server. With Comet, the server
notifies the clients.
As you can imagine, this is definitely important for dynamic web
application.
Regards,
Clement
On 28.08.2009, at 08:40, Rob Walker wrote:
> What do we need to do make this happen guys?
>
> Sten - sounds like you've done a great job, kudos.
>
> Felix/Marcel - sounds like you guys are happy with the approach and
> code
>
> >From our side, we can certainly run some "real world" compatibility
> tests - which isn't to say in fact that Sten's new service would be
> wrong and the current one right, just whether thenew version breaks
> anything present in the exisiting service. If it does, I'm sure
> it'll either be fixable, or something that's actually not correct in
> the current service - so not a major issue. It'll be useful though
> to be able to advise other Felix guys of anything that might differ
> and need application changes. I'm happy to make time to look at
> this next week.
>
> After that - do we just call a vote? I'm guessing Sten, we also need
> to propose you as a committter for maintenance?
>
> Great progress though - the current Http service has served us
> pretty well, but it's always been on the list to have cleaner and
> fuller solution
>
> -- Rob
>
>
Re: Felix HttpService improvement...
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 8/28/09 4:36, Felix Meschberger wrote:
> Hi,
>
> Rob Walker schrieb:
>
>> What do we need to do make this happen guys?
>>
> The next steps are IIRC the following:
>
> * Sten packages the source and attaches the package to
> the issue and publishes a package checksum.
>
I will add to this, removes any existing header/copyright notices from
the files and adds the standard Apache header (see any Felix Java file).
Package renaming is not necessary at this point.
> * We vote on accepting this submission
> * We do the IP-clearance (filling out a form,
> sending a mail to incubator@ and wait for 72h)
> * Add the code into the SVN
>
> I think, we also need someone from the PMC to drive this process.
>
> Any volunteers (I could do it) ?
>
I am happy to have you do it. :-)
Of course, I can help if needed.
-> richard
> Regards
> Felix
>
>
>> Sten - sounds like you've done a great job, kudos.
>>
>> Felix/Marcel - sounds like you guys are happy with the approach and code
>>
>> > From our side, we can certainly run some "real world" compatibility
>> tests - which isn't to say in fact that Sten's new service would be
>> wrong and the current one right, just whether thenew version breaks
>> anything present in the exisiting service. If it does, I'm sure it'll
>> either be fixable, or something that's actually not correct in the
>> current service - so not a major issue. It'll be useful though to be
>> able to advise other Felix guys of anything that might differ and need
>> application changes. I'm happy to make time to look at this next week.
>>
>> After that - do we just call a vote? I'm guessing Sten, we also need to
>> propose you as a committter for maintenance?
>>
>> Great progress though - the current Http service has served us pretty
>> well, but it's always been on the list to have cleaner and fuller solution
>>
>> -- Rob
>>
>>
>>
>>
Re: Felix HttpService improvement...
Posted by Rob Walker <ro...@ascert.com>.
What do we need to do make this happen guys?
Sten - sounds like you've done a great job, kudos.
Felix/Marcel - sounds like you guys are happy with the approach and code
>From our side, we can certainly run some "real world" compatibility
tests - which isn't to say in fact that Sten's new service would be
wrong and the current one right, just whether thenew version breaks
anything present in the exisiting service. If it does, I'm sure it'll
either be fixable, or something that's actually not correct in the
current service - so not a major issue. It'll be useful though to be
able to advise other Felix guys of anything that might differ and need
application changes. I'm happy to make time to look at this next week.
After that - do we just call a vote? I'm guessing Sten, we also need to
propose you as a committter for maintenance?
Great progress though - the current Http service has served us pretty
well, but it's always been on the list to have cleaner and fuller solution
-- Rob
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
Kind words :-) I know sling would benefit from this implementation. Working
on a OSGi project too that is in need for such a service. One http bundle
that fit's every deployment method makes the distribution a little easier
:-)
BR,
Sten Roger
On Fri, Aug 28, 2009 at 12:19 AM, Felix Meschberger <fm...@gmail.com>wrote:
> Hi,
>
> Sorry for the delay ...
>
> I have looked at it and I am kind of impressed. This looks exactly like
> something which has been turning in my head for some months now, too...
>
> Good stuff and -- as Marcel said -- clearly structured. I would
> definitely welcome this as a contribution to Apache Felix
>
> .. and I could even imagine, that in Apache Sling we would strongly
> consider migrating to this, too (as you hinted in the issue ;-) ).
>
> Regards
> Felix
>
> Sten Roger Sandvik schrieb:
> > Now I'm back from vacation and has brushed up the code. I have submitted
> a
> > Jira task with the details (FELIX-1456). Since I really hate Jira as a
> patch
> > repository and I do not have commit rights I have uploaded the source and
> > binaries at a google hosted repository. It's two examples inside to show
> how
> > to use the bridged implementation. Tell me what you think :-)
> >
> > BR,
> > Sten Roger
> >
> > On Wed, Jul 29, 2009 at 6:36 PM, Sten Roger Sandvik <sr...@x3m.com> wrote:
> >
> >> Great. I am on a vacation right now, but when I'm back I will make
> >> available the code and binaries so that others can play with it.
> >>
> >> // srs
> >>
> >>
> >> On Tue, Jul 28, 2009 at 4:39 PM, Richard S. Hall <heavy@ungoverned.org
> >wrote:
> >>
> >>> On 7/28/09 2:44 AM, Rob Walker wrote:
> >>>
> >>>> We're a big user of the current felix Jetty http.
> >>>>
> >>>> Would definitely welcome any improvement/enhancement - personally I'd
> >>>> like to see it as a parallel implementation initially, so we can look
> at
> >>>> both side by side. And then later, if/when everyone is happy and has
> moved
> >>>> across then we could look to deprecate the existing one.
> >>>>
> >>>> My motives are purely selfish here - we have a lot of live users on
> the
> >>>> current implementation, and have had a couple of issues in the past
> where
> >>>> changes broke these implementations. So it'd be good to be able to
> stage any
> >>>> migration.
> >>>>
> >>> Even if we replace the existing impl, the old binary and source
> releases
> >>> do not go away, so no one would be forced to upgrade before they were
> >>> ready...of course, if there is some irreconcilable incompatibility
> between
> >>> the two then we'd have an issue, but I doubt that would be the case
> since
> >>> they are supposed to be implementing the same spec.
> >>>
> >>> Well, it sounds like there is sufficient interest, so it would be great
> if
> >>> Sten could make it available for people to play with via JIRA.
> >>>
> >>> What do you think, Sten?
> >>>
> >>> -> richard
> >>>
> >>>
> >>>
> >>>> On the plus note - although our usage is quite basic, we do stick
> >>>> strictly to what OSGi exposes as the HttpService API layer and use no
> other
> >>>> features. So we make quite a good test site to ensure the fundamentals
> of
> >>>> the base API are working as per the spec.
> >>>>
> >>>> Regards
> >>>>
> >>>> -- Rob
> >>>>
> >>>>
> >>>>
> >
>
Re: Felix HttpService improvement...
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
Sorry for the delay ...
I have looked at it and I am kind of impressed. This looks exactly like
something which has been turning in my head for some months now, too...
Good stuff and -- as Marcel said -- clearly structured. I would
definitely welcome this as a contribution to Apache Felix
.. and I could even imagine, that in Apache Sling we would strongly
consider migrating to this, too (as you hinted in the issue ;-) ).
Regards
Felix
Sten Roger Sandvik schrieb:
> Now I'm back from vacation and has brushed up the code. I have submitted a
> Jira task with the details (FELIX-1456). Since I really hate Jira as a patch
> repository and I do not have commit rights I have uploaded the source and
> binaries at a google hosted repository. It's two examples inside to show how
> to use the bridged implementation. Tell me what you think :-)
>
> BR,
> Sten Roger
>
> On Wed, Jul 29, 2009 at 6:36 PM, Sten Roger Sandvik <sr...@x3m.com> wrote:
>
>> Great. I am on a vacation right now, but when I'm back I will make
>> available the code and binaries so that others can play with it.
>>
>> // srs
>>
>>
>> On Tue, Jul 28, 2009 at 4:39 PM, Richard S. Hall <he...@ungoverned.org>wrote:
>>
>>> On 7/28/09 2:44 AM, Rob Walker wrote:
>>>
>>>> We're a big user of the current felix Jetty http.
>>>>
>>>> Would definitely welcome any improvement/enhancement - personally I'd
>>>> like to see it as a parallel implementation initially, so we can look at
>>>> both side by side. And then later, if/when everyone is happy and has moved
>>>> across then we could look to deprecate the existing one.
>>>>
>>>> My motives are purely selfish here - we have a lot of live users on the
>>>> current implementation, and have had a couple of issues in the past where
>>>> changes broke these implementations. So it'd be good to be able to stage any
>>>> migration.
>>>>
>>> Even if we replace the existing impl, the old binary and source releases
>>> do not go away, so no one would be forced to upgrade before they were
>>> ready...of course, if there is some irreconcilable incompatibility between
>>> the two then we'd have an issue, but I doubt that would be the case since
>>> they are supposed to be implementing the same spec.
>>>
>>> Well, it sounds like there is sufficient interest, so it would be great if
>>> Sten could make it available for people to play with via JIRA.
>>>
>>> What do you think, Sten?
>>>
>>> -> richard
>>>
>>>
>>>
>>>> On the plus note - although our usage is quite basic, we do stick
>>>> strictly to what OSGi exposes as the HttpService API layer and use no other
>>>> features. So we make quite a good test site to ensure the fundamentals of
>>>> the base API are working as per the spec.
>>>>
>>>> Regards
>>>>
>>>> -- Rob
>>>>
>>>>
>>>>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
Now I'm back from vacation and has brushed up the code. I have submitted a
Jira task with the details (FELIX-1456). Since I really hate Jira as a patch
repository and I do not have commit rights I have uploaded the source and
binaries at a google hosted repository. It's two examples inside to show how
to use the bridged implementation. Tell me what you think :-)
BR,
Sten Roger
On Wed, Jul 29, 2009 at 6:36 PM, Sten Roger Sandvik <sr...@x3m.com> wrote:
> Great. I am on a vacation right now, but when I'm back I will make
> available the code and binaries so that others can play with it.
>
> // srs
>
>
> On Tue, Jul 28, 2009 at 4:39 PM, Richard S. Hall <he...@ungoverned.org>wrote:
>
>> On 7/28/09 2:44 AM, Rob Walker wrote:
>>
>>> We're a big user of the current felix Jetty http.
>>>
>>> Would definitely welcome any improvement/enhancement - personally I'd
>>> like to see it as a parallel implementation initially, so we can look at
>>> both side by side. And then later, if/when everyone is happy and has moved
>>> across then we could look to deprecate the existing one.
>>>
>>> My motives are purely selfish here - we have a lot of live users on the
>>> current implementation, and have had a couple of issues in the past where
>>> changes broke these implementations. So it'd be good to be able to stage any
>>> migration.
>>>
>>
>> Even if we replace the existing impl, the old binary and source releases
>> do not go away, so no one would be forced to upgrade before they were
>> ready...of course, if there is some irreconcilable incompatibility between
>> the two then we'd have an issue, but I doubt that would be the case since
>> they are supposed to be implementing the same spec.
>>
>> Well, it sounds like there is sufficient interest, so it would be great if
>> Sten could make it available for people to play with via JIRA.
>>
>> What do you think, Sten?
>>
>> -> richard
>>
>>
>>
>>> On the plus note - although our usage is quite basic, we do stick
>>> strictly to what OSGi exposes as the HttpService API layer and use no other
>>> features. So we make quite a good test site to ensure the fundamentals of
>>> the base API are working as per the spec.
>>>
>>> Regards
>>>
>>> -- Rob
>>>
>>>
>>>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
Great. I am on a vacation right now, but when I'm back I will make available
the code and binaries so that others can play with it.
// srs
On Tue, Jul 28, 2009 at 4:39 PM, Richard S. Hall <he...@ungoverned.org>wrote:
> On 7/28/09 2:44 AM, Rob Walker wrote:
>
>> We're a big user of the current felix Jetty http.
>>
>> Would definitely welcome any improvement/enhancement - personally I'd like
>> to see it as a parallel implementation initially, so we can look at both
>> side by side. And then later, if/when everyone is happy and has moved across
>> then we could look to deprecate the existing one.
>>
>> My motives are purely selfish here - we have a lot of live users on the
>> current implementation, and have had a couple of issues in the past where
>> changes broke these implementations. So it'd be good to be able to stage any
>> migration.
>>
>
> Even if we replace the existing impl, the old binary and source releases do
> not go away, so no one would be forced to upgrade before they were
> ready...of course, if there is some irreconcilable incompatibility between
> the two then we'd have an issue, but I doubt that would be the case since
> they are supposed to be implementing the same spec.
>
> Well, it sounds like there is sufficient interest, so it would be great if
> Sten could make it available for people to play with via JIRA.
>
> What do you think, Sten?
>
> -> richard
>
>
>
>> On the plus note - although our usage is quite basic, we do stick strictly
>> to what OSGi exposes as the HttpService API layer and use no other features.
>> So we make quite a good test site to ensure the fundamentals of the base API
>> are working as per the spec.
>>
>> Regards
>>
>> -- Rob
>>
>>
>>
Re: Felix HttpService improvement...
Posted by "Richard S. Hall" <he...@ungoverned.org>.
On 7/28/09 2:44 AM, Rob Walker wrote:
> We're a big user of the current felix Jetty http.
>
> Would definitely welcome any improvement/enhancement - personally I'd
> like to see it as a parallel implementation initially, so we can look
> at both side by side. And then later, if/when everyone is happy and
> has moved across then we could look to deprecate the existing one.
>
> My motives are purely selfish here - we have a lot of live users on
> the current implementation, and have had a couple of issues in the
> past where changes broke these implementations. So it'd be good to be
> able to stage any migration.
Even if we replace the existing impl, the old binary and source releases
do not go away, so no one would be forced to upgrade before they were
ready...of course, if there is some irreconcilable incompatibility
between the two then we'd have an issue, but I doubt that would be the
case since they are supposed to be implementing the same spec.
Well, it sounds like there is sufficient interest, so it would be great
if Sten could make it available for people to play with via JIRA.
What do you think, Sten?
-> richard
>
> On the plus note - although our usage is quite basic, we do stick
> strictly to what OSGi exposes as the HttpService API layer and use no
> other features. So we make quite a good test site to ensure the
> fundamentals of the base API are working as per the spec.
>
> Regards
>
> -- Rob
>
>
Re: Felix HttpService improvement...
Posted by Rob Walker <ro...@ascert.com>.
We're a big user of the current felix Jetty http.
Would definitely welcome any improvement/enhancement - personally I'd
like to see it as a parallel implementation initially, so we can look at
both side by side. And then later, if/when everyone is happy and has
moved across then we could look to deprecate the existing one.
My motives are purely selfish here - we have a lot of live users on the
current implementation, and have had a couple of issues in the past
where changes broke these implementations. So it'd be good to be able to
stage any migration.
On the plus note - although our usage is quite basic, we do stick
strictly to what OSGi exposes as the HttpService API layer and use no
other features. So we make quite a good test site to ensure the
fundamentals of the base API are working as per the spec.
Regards
-- Rob
Re: Felix HttpService improvement...
Posted by Karl Pauls <ka...@gmail.com>.
I agree, something like this would be very much welcomed.
regards,
Karl
On Mon, Jul 27, 2009 at 8:36 AM, Felix Meschberger<fm...@gmail.com> wrote:
> Hi,
>
> I would welcome a one-stop-shop solution for a standalone and bridged
> environment. Currently, in Apache Sling, we are using either the
> standalone Jetty based implementation or the Eclipse bridge depending on
> how we build.
>
> Having a single-solution might come very handy.
>
> So to second Richard, I suggest you create a JIRA (ensure to check the
> "ASF inclusion permission box" when uploading the tar or patch) so that
> we can have a look and then discuss on how to proceed ?
>
> Thanks and Regards
> Felix
>
> Richard S. Hall schrieb:
>> I would certainly be happy to consider it for a replacement to the
>> existing impl. However, since I am not a big user of the existing impl
>> (even though I started it a long, long time ago), I guess we need to
>> hear from people who work and rely on the current impl.
>>
>> What would be cool, is if you could create a tar ball and make it
>> available so people could play with it. You could always create a JIRA
>> issue and attach it to that...that's the best way to get the ball
>> rolling to see if there is interest here for accepting it as a
>> contribution.
>>
>> Thanks.
>>
>> -> richard
>>
>> On 7/26/09 4:13 PM, Sten Roger Sandvik wrote:
>>> Hi.
>>>
>>> I have looked at the HttpService implementation in Felix and I had some
>>> thoughts on how to improve the functionality. Over the past year I have
>>> looked long and hard for a solution that has the following features:
>>>
>>> * Run inside a WAR on a 3rd part container.
>>> * Run stand-alone (using jetty).
>>> * Has servlet filter support.
>>> * Using whiteboard pattern for registering servlets / filters.
>>>
>>> The road led me to Pax Web (supports filters, but only as a stand-alone
>>> service) and Equinox Servlet Bridge (does not support filters).
>>> Whiteboard
>>> registering pattern is implemented by the Pax guys, but does not support
>>> filters inside a "bridged" environment.
>>>
>>> So, eventually I was tired of looking for a solution out there and
>>> created
>>> my own. This supports servlets and filters in both stand-alone and
>>> bridged
>>> mode (WAR). Now I have come to a fork in the road. Should I donate the
>>> code
>>> or host my own. I prefer to donate the code. But is the right place under
>>> Felix umbrella or Pax Web umbrella? I see that more and more is created
>>> under Felix and this implementation would be (in my opinion) a great
>>> addition.
>>>
>>> So, what do you guys think?
>>>
>>> BR,
>>> Sten Roger Sandvik
>>>
>>>
>>
>
--
Karl Pauls
karlpauls@gmail.com
Re: Felix HttpService improvement...
Posted by Felix Meschberger <fm...@gmail.com>.
Hi,
I would welcome a one-stop-shop solution for a standalone and bridged
environment. Currently, in Apache Sling, we are using either the
standalone Jetty based implementation or the Eclipse bridge depending on
how we build.
Having a single-solution might come very handy.
So to second Richard, I suggest you create a JIRA (ensure to check the
"ASF inclusion permission box" when uploading the tar or patch) so that
we can have a look and then discuss on how to proceed ?
Thanks and Regards
Felix
Richard S. Hall schrieb:
> I would certainly be happy to consider it for a replacement to the
> existing impl. However, since I am not a big user of the existing impl
> (even though I started it a long, long time ago), I guess we need to
> hear from people who work and rely on the current impl.
>
> What would be cool, is if you could create a tar ball and make it
> available so people could play with it. You could always create a JIRA
> issue and attach it to that...that's the best way to get the ball
> rolling to see if there is interest here for accepting it as a
> contribution.
>
> Thanks.
>
> -> richard
>
> On 7/26/09 4:13 PM, Sten Roger Sandvik wrote:
>> Hi.
>>
>> I have looked at the HttpService implementation in Felix and I had some
>> thoughts on how to improve the functionality. Over the past year I have
>> looked long and hard for a solution that has the following features:
>>
>> * Run inside a WAR on a 3rd part container.
>> * Run stand-alone (using jetty).
>> * Has servlet filter support.
>> * Using whiteboard pattern for registering servlets / filters.
>>
>> The road led me to Pax Web (supports filters, but only as a stand-alone
>> service) and Equinox Servlet Bridge (does not support filters).
>> Whiteboard
>> registering pattern is implemented by the Pax guys, but does not support
>> filters inside a "bridged" environment.
>>
>> So, eventually I was tired of looking for a solution out there and
>> created
>> my own. This supports servlets and filters in both stand-alone and
>> bridged
>> mode (WAR). Now I have come to a fork in the road. Should I donate the
>> code
>> or host my own. I prefer to donate the code. But is the right place under
>> Felix umbrella or Pax Web umbrella? I see that more and more is created
>> under Felix and this implementation would be (in my opinion) a great
>> addition.
>>
>> So, what do you guys think?
>>
>> BR,
>> Sten Roger Sandvik
>>
>>
>
Re: Felix HttpService improvement...
Posted by "Richard S. Hall" <he...@ungoverned.org>.
I would certainly be happy to consider it for a replacement to the
existing impl. However, since I am not a big user of the existing impl
(even though I started it a long, long time ago), I guess we need to
hear from people who work and rely on the current impl.
What would be cool, is if you could create a tar ball and make it
available so people could play with it. You could always create a JIRA
issue and attach it to that...that's the best way to get the ball
rolling to see if there is interest here for accepting it as a contribution.
Thanks.
-> richard
On 7/26/09 4:13 PM, Sten Roger Sandvik wrote:
> Hi.
>
> I have looked at the HttpService implementation in Felix and I had some
> thoughts on how to improve the functionality. Over the past year I have
> looked long and hard for a solution that has the following features:
>
> * Run inside a WAR on a 3rd part container.
> * Run stand-alone (using jetty).
> * Has servlet filter support.
> * Using whiteboard pattern for registering servlets / filters.
>
> The road led me to Pax Web (supports filters, but only as a stand-alone
> service) and Equinox Servlet Bridge (does not support filters). Whiteboard
> registering pattern is implemented by the Pax guys, but does not support
> filters inside a "bridged" environment.
>
> So, eventually I was tired of looking for a solution out there and created
> my own. This supports servlets and filters in both stand-alone and bridged
> mode (WAR). Now I have come to a fork in the road. Should I donate the code
> or host my own. I prefer to donate the code. But is the right place under
> Felix umbrella or Pax Web umbrella? I see that more and more is created
> under Felix and this implementation would be (in my opinion) a great
> addition.
>
> So, what do you guys think?
>
> BR,
> Sten Roger Sandvik
>
>
Re: Felix HttpService improvement...
Posted by Sten Roger Sandvik <sr...@x3m.com>.
The Java 5 features can be skipped. It's not that much work to make it Java
1.4 compatible. I will like to donate the code so it will have a good home.
Would also be active in the maintainance of the http service and
webcontainer (work in progress) if it's migrated into felix.
BR,
Sten Roger
On Thu, Aug 27, 2009 at 11:38 PM, Marcel Offermans <
marcel.offermans@luminis.nl> wrote:
> Hello Sten,
>
> On Jul 26, 2009, at 22:13 , Sten Roger Sandvik wrote:
>
> I have looked at the HttpService implementation in Felix and I had some
>> thoughts on how to improve the functionality. Over the past year I have
>> looked long and hard for a solution that has the following features:
>>
>> * Run inside a WAR on a 3rd part container.
>> * Run stand-alone (using jetty).
>> * Has servlet filter support.
>> * Using whiteboard pattern for registering servlets / filters.
>>
>> The road led me to Pax Web (supports filters, but only as a stand-alone
>> service) and Equinox Servlet Bridge (does not support filters). Whiteboard
>> registering pattern is implemented by the Pax guys, but does not support
>> filters inside a "bridged" environment.
>>
>
> I very much agree with the comments from other people on the list that it
> makes a lot of sense to have a single implementation that combines all these
> features. I looked at the code you linked to in the Jira issue and like the
> clean and modular design of it. You do use some Java 5 features, but I'm not
> too troubled by that. For really constrained environments in embedded
> devices, you probably don't want to use Jetty for example at all.
>
> So, eventually I was tired of looking for a solution out there and created
>> my own. This supports servlets and filters in both stand-alone and bridged
>> mode (WAR). Now I have come to a fork in the road. Should I donate the
>> code
>> or host my own. I prefer to donate the code. But is the right place under
>> Felix umbrella or Pax Web umbrella? I see that more and more is created
>> under Felix and this implementation would be (in my opinion) a great
>> addition.
>>
>
> My personal opinion on this is that I would like to see all these efforts
> being merged in the future. To directly answer your question, I would prefer
> you donate the code, and I would welcome that even more if you also have the
> time to keep supporting it. Felix is a good home for it!
>
> Greetings, Marcel
>
>
Re: Felix HttpService improvement...
Posted by Marcel Offermans <ma...@luminis.nl>.
Hello Sten,
On Jul 26, 2009, at 22:13 , Sten Roger Sandvik wrote:
> I have looked at the HttpService implementation in Felix and I had
> some
> thoughts on how to improve the functionality. Over the past year I
> have
> looked long and hard for a solution that has the following features:
>
> * Run inside a WAR on a 3rd part container.
> * Run stand-alone (using jetty).
> * Has servlet filter support.
> * Using whiteboard pattern for registering servlets / filters.
>
> The road led me to Pax Web (supports filters, but only as a stand-
> alone
> service) and Equinox Servlet Bridge (does not support filters).
> Whiteboard
> registering pattern is implemented by the Pax guys, but does not
> support
> filters inside a "bridged" environment.
I very much agree with the comments from other people on the list that
it makes a lot of sense to have a single implementation that combines
all these features. I looked at the code you linked to in the Jira
issue and like the clean and modular design of it. You do use some
Java 5 features, but I'm not too troubled by that. For really
constrained environments in embedded devices, you probably don't want
to use Jetty for example at all.
> So, eventually I was tired of looking for a solution out there and
> created
> my own. This supports servlets and filters in both stand-alone and
> bridged
> mode (WAR). Now I have come to a fork in the road. Should I donate
> the code
> or host my own. I prefer to donate the code. But is the right place
> under
> Felix umbrella or Pax Web umbrella? I see that more and more is
> created
> under Felix and this implementation would be (in my opinion) a great
> addition.
My personal opinion on this is that I would like to see all these
efforts being merged in the future. To directly answer your question,
I would prefer you donate the code, and I would welcome that even more
if you also have the time to keep supporting it. Felix is a good home
for it!
Greetings, Marcel