You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2019/07/25 17:46:23 UTC

[GitHub] [flink] xuefuz commented on issue #9229: [FLINK-13279][table-sql-client] Fully qualify sink name in sql-client

xuefuz commented on issue #9229:  [FLINK-13279][table-sql-client] Fully qualify sink name in sql-client 
URL: https://github.com/apache/flink/pull/9229#issuecomment-515144417
 
 
   Thanks to @dawidwys for the fix, which seems good to me. Here I'd like to reemphasize an observation for future consideration.
   
   In our original design of CatalogManager, we wanted it to be only aware of multiple catalogs with one being the current. CatalogManager doesn't need to treat any one of them specially. Each catalog may has its own capability and restriction, but upper layers doesn't need to care about. This design would avoid such pervasive, special treatment of the built-in catalog as we see in this PR.
   
   While it's too late to revisit this, I'd suggest we open up the discussion again post 1.9.
   
   Thanks!

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services