[GitHub] [shardingsphere] xinglijun1973 commented on a diff in pull request #20257: Fix Oracle pagination and sorting/grouping problem: add ‘order by’/'group by' of the subquery to its outer statement if the subquery selects oracle rownum

[GitBox <gi...@apache.org>]

xinglijun1973 commented on code in PR #20257:
URL: https://github.com/apache/shardingsphere/pull/20257#discussion_r1004183861


##########
infra/binder/src/main/java/org/apache/shardingsphere/infra/binder/segment/select/projection/ProjectionUtil.java:
##########
@@ -0,0 +1,45 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.shardingsphere.infra.binder.segment.select.projection;
+
+import java.util.Collection;
+import java.util.LinkedList;
+
+import org.apache.shardingsphere.infra.binder.segment.select.projection.impl.DerivedProjection;
+import org.apache.shardingsphere.infra.binder.segment.select.projection.impl.ShorthandProjection;
+
+/**
+ * projection util. 
+ */
+public class ProjectionUtil {
+    
+    /**
+     * expand projection, such as ShorthandProjection.
+     * @param projection the projection to expand
+     * @return expanded projections
+     */
+    public static Collection<Projection> expandProjection(final Projection projection) {

Review Comment:
   It's to expand a column projection (especially Shorthand Projection), but projection context contains all projections. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org