You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Oliver Szabo <os...@hortonworks.com> on 2016/04/13 18:32:17 UTC

Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
-----------------------------------------------------------

Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Bugs: AMBARI-15865
    https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
-------

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)


Diffs
-----

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.groovy PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/DoNotDeleteMe.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/test/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.groovy PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/NeitherMe.java PRE-CREATION 
  ambari-logsearch/pom.xml 3d4edcd 

Diff: https://reviews.apache.org/r/46152/diff/


Testing
-------

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest


Thanks,

Oliver Szabo


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Sumit Mohanty <sm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/#review130407
-----------------------------------------------------------


Ship it!




Ship It!

- Sumit Mohanty


On April 22, 2016, 6:02 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46152/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 6:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15865
>     https://issues.apache.org/jira/browse/AMBARI-15865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a small ambari solr client (and rpm/deb), for logsearch solr.
> The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 1544ffe 
>   ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/control b853f13 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postinst 21a01fa 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postrm 21a01fa 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/posttrm 21a01fa 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/preinst 21a01fa 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/prerm 21a01fa 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckConfigZkCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateShardCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetShardsCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/ShardUtils.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/log4j.properties PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCloudCli.sh PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
>   ambari-logsearch/pom.xml 475de9f 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 93311fb 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 1a5f4d3 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml c54db90 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 5966704 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py b461b1f 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py c1a8cc7 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py 0171e36 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py ecb48c8 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/solr-client-log4j.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/LOGSEARCH/role_command_order.json 688186b 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 1a25aa9 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py 977cd9c 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 1c67272 
>   ambari-web/app/data/HDP2/site_properties.js 19e0931 
> 
> Diff: https://reviews.apache.org/r/46152/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest
> 
> python tests:
> 
> Total run:995
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
-----------------------------------------------------------

(Updated April 25, 2016, 4:29 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

-fixed typo


Bugs: AMBARI-15865
    https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
-------

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 1544ffe 
  ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/control b853f13 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postinst 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postrm 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/posttrm 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/preinst 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/prerm 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateShardCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetShardsCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/ShardUtils.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/log4j.properties PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCloudCli.sh PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
  ambari-logsearch/pom.xml 9fa7c96 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 93311fb 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 1a5f4d3 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml c54db90 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 5966704 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr_client.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py 4084243 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py c1a8cc7 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py 0171e36 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py ecb48c8 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/solr-client-log4j.properties.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/LOGSEARCH/role_command_order.json 688186b 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 1a25aa9 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py 977cd9c 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 1c67272 
  ambari-web/app/data/HDP2/site_properties.js a687893 

Diff: https://reviews.apache.org/r/46152/diff/


Testing
-------

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest

python tests:

Total run:995
Total errors:0
Total failures:0


Thanks,

Oliver Szabo


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Robert Nettleton <rn...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/#review130409
-----------------------------------------------------------


Ship it!




Ship It!

- Robert Nettleton


On April 22, 2016, 6:02 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46152/
> -----------------------------------------------------------
> 
> (Updated April 22, 2016, 6:02 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15865
>     https://issues.apache.org/jira/browse/AMBARI-15865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a small ambari solr client (and rpm/deb), for logsearch solr.
> The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)
> 
> 
> Diffs
> -----
> 
>   ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 1544ffe 
>   ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/control b853f13 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postinst 21a01fa 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postrm 21a01fa 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/posttrm 21a01fa 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/preinst 21a01fa 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/prerm 21a01fa 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckConfigZkCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateShardCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetShardsCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/ShardUtils.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/log4j.properties PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCloudCli.sh PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
>   ambari-logsearch/pom.xml 475de9f 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 93311fb 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 1a5f4d3 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml c54db90 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 5966704 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr_client.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py b461b1f 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py c1a8cc7 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py PRE-CREATION 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py 0171e36 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py ecb48c8 
>   ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/solr-client-log4j.properties.j2 PRE-CREATION 
>   ambari-server/src/main/resources/stacks/HDP/2.3/services/LOGSEARCH/role_command_order.json 688186b 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 1a25aa9 
>   ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py 977cd9c 
>   ambari-server/src/test/python/stacks/2.4/configs/default.json 1c67272 
>   ambari-web/app/data/HDP2/site_properties.js 19e0931 
> 
> Diff: https://reviews.apache.org/r/46152/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest
> 
> python tests:
> 
> Total run:995
> Total errors:0
> Total failures:0
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
-----------------------------------------------------------

(Updated April 22, 2016, 6:02 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

- updated python tests


Bugs: AMBARI-15865
    https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
-------

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 1544ffe 
  ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/control b853f13 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postinst 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postrm 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/posttrm 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/preinst 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/prerm 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateShardCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetShardsCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/ShardUtils.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/log4j.properties PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCloudCli.sh PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
  ambari-logsearch/pom.xml 475de9f 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 93311fb 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 1a5f4d3 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml c54db90 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 5966704 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr_client.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py b461b1f 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py c1a8cc7 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py 0171e36 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py ecb48c8 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/solr-client-log4j.properties.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/LOGSEARCH/role_command_order.json 688186b 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_logsearch.py 1a25aa9 
  ambari-server/src/test/python/stacks/2.4/LOGSEARCH/test_solr.py 977cd9c 
  ambari-server/src/test/python/stacks/2.4/configs/default.json 1c67272 
  ambari-web/app/data/HDP2/site_properties.js 19e0931 

Diff: https://reviews.apache.org/r/46152/diff/


Testing (updated)
-------

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest

python tests:

Total run:995
Total errors:0
Total failures:0


Thanks,

Oliver Szabo


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
-----------------------------------------------------------

(Updated April 22, 2016, 3:07 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

- added "add shard" command (and add shard during create collection if needed) and check configuration does exist in zookeeper or not
- added solr_cloud_util for ambari-commons -> to use solrCloudCli from stack definitions
- added logsearch solr client for logsearch service definition
- removed appender from rpm/deb build (its enough to use it as a dependency)


Bugs: AMBARI-15865
    https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
-------

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)


Diffs (updated)
-----

  ambari-common/src/main/python/resource_management/libraries/functions/package_conditions.py 1544ffe 
  ambari-common/src/main/python/resource_management/libraries/functions/solr_cloud_util.py PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/control b853f13 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postinst 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/postrm 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/posttrm 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/preinst 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/appender/prerm 21a01fa 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CheckConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateShardCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/GetShardsCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/util/ShardUtils.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/log4j.properties PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCloudCli.sh PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
  ambari-logsearch/pom.xml 475de9f 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logfeeder-env.xml 93311fb 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-env.xml 1a5f4d3 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/configuration/logsearch-solr-env.xml c54db90 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 5966704 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/logsearch_solr_client.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/params.py b461b1f 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py c1a8cc7 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch_solr.py PRE-CREATION 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_solr.py 0171e36 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/solr.py ecb48c8 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/templates/solr-client-log4j.properties.j2 PRE-CREATION 
  ambari-server/src/main/resources/stacks/HDP/2.3/services/LOGSEARCH/role_command_order.json 688186b 
  ambari-web/app/data/HDP2/site_properties.js 19e0931 

Diff: https://reviews.apache.org/r/46152/diff/


Testing
-------

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest


Thanks,

Oliver Szabo


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/#review129750
-----------------------------------------------------------



Looks good to me. Thanks

- Don Bosco Durai


On April 20, 2016, 4:36 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46152/
> -----------------------------------------------------------
> 
> (Updated April 20, 2016, 4:36 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15865
>     https://issues.apache.org/jira/browse/AMBARI-15865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a small ambari solr client (and rpm/deb), for logsearch solr.
> The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCloudCli.sh PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
>   ambari-logsearch/pom.xml 475de9f 
> 
> Diff: https://reviews.apache.org/r/46152/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
-----------------------------------------------------------

(Updated April 20, 2016, 4:36 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

removed test code


Bugs: AMBARI-15865
    https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
-------

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)


Diffs (updated)
-----

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCloudCli.sh PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
  ambari-logsearch/pom.xml 475de9f 

Diff: https://reviews.apache.org/r/46152/diff/


Testing
-------

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest


Thanks,

Oliver Szabo


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
-----------------------------------------------------------

(Updated April 20, 2016, 4:20 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

- added zookeeper download/upload config support


Bugs: AMBARI-15865
    https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
-------

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)


Diffs (updated)
-----

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractZookeeperRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/DownloadConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/UploadConfigZkCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCloudCli.sh PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
  ambari-logsearch/pom.xml 475de9f 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/metainfo.xml 5966704 
  ambari-server/src/main/resources/common-services/LOGSEARCH/0.5.0/package/scripts/setup_logsearch.py c1a8cc7 

Diff: https://reviews.apache.org/r/46152/diff/


Testing
-------

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest


Thanks,

Oliver Szabo


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
-----------------------------------------------------------

(Updated April 18, 2016, 10:01 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

- added router/maxShardsPerNode options
- fixed issues


Bugs: AMBARI-15865
    https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
-------

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)


Diffs (updated)
-----

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
  ambari-logsearch/pom.xml 475de9f 

Diff: https://reviews.apache.org/r/46152/diff/


Testing
-------

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest


Thanks,

Oliver Szabo


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/#review129420
-----------------------------------------------------------




ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java (line 103)
<https://reviews.apache.org/r/46152/#comment192845>

    I just added a return value here if the code executed successfully, the real assert here is the verify, that checks how many times the "request" called. altough the test method name is not right, that is the CollectionDoesNotExist case not the CollectionExists


- Oliver Szabo


On April 18, 2016, 4:47 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46152/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 4:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15865
>     https://issues.apache.org/jira/browse/AMBARI-15865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a small ambari solr client (and rpm/deb), for logsearch solr.
> The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
>   ambari-logsearch/pom.xml 475de9f 
> 
> Diff: https://reviews.apache.org/r/46152/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/#review129415
-----------------------------------------------------------




ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java (line 49)
<https://reviews.apache.org/r/46152/#comment192837>

    might be good to put the path at the end, e.g. host1:port,host2:port,host3:port,.../ambari_solr



ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java (line 95)
<https://reviews.apache.org/r/46152/#comment192838>

    short form for retryOption and intervalOption seems to be the same



ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java (line 52)
<https://reviews.apache.org/r/46152/#comment192839>

    Show we move the sleep in the else condition?



ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java (line 103)
<https://reviews.apache.org/r/46152/#comment192842>

    Not sure why we are testing result with "collection1".


- Don Bosco Durai


On April 18, 2016, 4:47 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46152/
> -----------------------------------------------------------
> 
> (Updated April 18, 2016, 4:47 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15865
>     https://issues.apache.org/jira/browse/AMBARI-15865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a small ambari solr client (and rpm/deb), for logsearch solr.
> The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
>   ambari-logsearch/pom.xml 475de9f 
> 
> Diff: https://reviews.apache.org/r/46152/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Oliver Szabo <os...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/
-----------------------------------------------------------

(Updated April 18, 2016, 4:47 p.m.)


Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.


Changes
-------

- rewrite solr client to java (from groovy)
- added ZkClient (for future usage)
- bosco's issues still in progress


Bugs: AMBARI-15865
    https://issues.apache.org/jira/browse/AMBARI-15865


Repository: ambari


Description
-------

Create a small ambari solr client (and rpm/deb), for logsearch solr.
The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)


Diffs (updated)
-----

  ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
  ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientBuilder.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientException.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/AbstractSolrRetryCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/CreateCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/commands/ListCollectionCommand.java PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh PRE-CREATION 
  ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.java PRE-CREATION 
  ambari-logsearch/pom.xml 475de9f 

Diff: https://reviews.apache.org/r/46152/diff/


Testing
-------

Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest


Thanks,

Oliver Szabo


Re: Review Request 46152: Add 'ambari-logsearch-solr-client' module for ambari-logsearch

Posted by Don Bosco Durai <bo...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/46152/#review128699
-----------------------------------------------------------




ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy (line 73)
<https://reviews.apache.org/r/46152/#comment192166>

    In LogSearch we use implicit routing, which needs to be sent as additional param while creating collections



ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy (line 78)
<https://reviews.apache.org/r/46152/#comment192167>

    We might have take a higher number or configurable param. If the node contains other shards, then this will fail.


- Don Bosco Durai


On April 13, 2016, 4:32 p.m., Oliver Szabo wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/46152/
> -----------------------------------------------------------
> 
> (Updated April 13, 2016, 4:32 p.m.)
> 
> 
> Review request for Ambari, Alejandro Fernandez, Andrew Onischuk, Robert Nettleton, Sandor Magyari, Sumit Mohanty, and Sebastian Toader.
> 
> 
> Bugs: AMBARI-15865
>     https://issues.apache.org/jira/browse/AMBARI-15865
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Create a small ambari solr client (and rpm/deb), for logsearch solr.
> The goal is the create a client which can be used for another services to access zookeeper/solr and create their own collections in logsearch solr. (e.g. for ATLAS or RANGER)
> 
> 
> Diffs
> -----
> 
>   ambari-logsearch/ambari-logsearch-assembly/pom.xml 2db0608 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/control PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/postrm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/preinst PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-assembly/src/main/package/deb/solr-client/prerm PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/build.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/pom.xml PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudCLI.groovy PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClient.groovy PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/java/org/apache/ambari/logsearch/solr/DoNotDeleteMe.java PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/main/resources/solrCli.sh PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/test/groovy/org/apache/ambari/logsearch/solr/AmbariSolrCloudClientTest.groovy PRE-CREATION 
>   ambari-logsearch/ambari-logsearch-solr-client/src/test/java/org/apache/ambari/logsearch/solr/NeitherMe.java PRE-CREATION 
>   ambari-logsearch/pom.xml 3d4edcd 
> 
> Diff: https://reviews.apache.org/r/46152/diff/
> 
> 
> Testing
> -------
> 
> Tests run: 5, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 1.917 sec - in org.apache.ambari.logsearch.solr.AmbariSolrCloudClientTest
> 
> 
> Thanks,
> 
> Oliver Szabo
> 
>