You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@thrift.apache.org by "Rush Manbert (JIRA)" <ji...@apache.org> on 2009/08/05 18:28:14 UTC

[jira] Created: (THRIFT-555) No macro definitions for htolell or letohll for PPC Mac OS X

No macro definitions for htolell or letohll for PPC Mac OS X
------------------------------------------------------------

                 Key: THRIFT-555
                 URL: https://issues.apache.org/jira/browse/THRIFT-555
             Project: Thrift
          Issue Type: Bug
          Components: Library (C++)
    Affects Versions: 0.1
         Environment: Mac OS X 10.5.7 PPC
            Reporter: Rush Manbert


On a PPC Mac, you end up getting the definitions at line 114 of TProtocol.h, and the macros htolell and letohll are not defined.

It looks like they should be defined as:

#  define htolell(n) bswap_64(n)
#  define letohll(n) bswap_64(n)

just like they are at line 111.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (THRIFT-555) No macro definitions for htolell or letohll for PPC Mac OS X

Posted by "David Reiss (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

David Reiss resolved THRIFT-555.
--------------------------------

       Resolution: Fixed
    Fix Version/s: 0.2

I also deleted the ntolell and letonll macros, since we aren't using them.

> No macro definitions for htolell or letohll for PPC Mac OS X
> ------------------------------------------------------------
>
>                 Key: THRIFT-555
>                 URL: https://issues.apache.org/jira/browse/THRIFT-555
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>    Affects Versions: 0.1
>         Environment: Mac OS X 10.5.7 PPC
>            Reporter: Rush Manbert
>             Fix For: 0.2
>
>         Attachments: Patch-Thrift-555.txt
>
>
> On a PPC Mac, you end up getting the definitions at line 114 of TProtocol.h, and the macros htolell and letohll are not defined.
> It looks like they should be defined as:
> #  define htolell(n) bswap_64(n)
> #  define letohll(n) bswap_64(n)
> just like they are at line 111.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (THRIFT-555) No macro definitions for htolell or letohll for PPC Mac OS X

Posted by "Rush Manbert (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rush Manbert updated THRIFT-555:
--------------------------------

    Attachment: Patch-Thrift-555.txt

Patch file.

> No macro definitions for htolell or letohll for PPC Mac OS X
> ------------------------------------------------------------
>
>                 Key: THRIFT-555
>                 URL: https://issues.apache.org/jira/browse/THRIFT-555
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>    Affects Versions: 0.1
>         Environment: Mac OS X 10.5.7 PPC
>            Reporter: Rush Manbert
>         Attachments: Patch-Thrift-555.txt
>
>
> On a PPC Mac, you end up getting the definitions at line 114 of TProtocol.h, and the macros htolell and letohll are not defined.
> It looks like they should be defined as:
> #  define htolell(n) bswap_64(n)
> #  define letohll(n) bswap_64(n)
> just like they are at line 111.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Closed: (THRIFT-555) No macro definitions for htolell or letohll for PPC Mac OS X

Posted by "Bryan Duxbury (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/THRIFT-555?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Bryan Duxbury closed THRIFT-555.
--------------------------------

    Assignee: Rush Manbert

> No macro definitions for htolell or letohll for PPC Mac OS X
> ------------------------------------------------------------
>
>                 Key: THRIFT-555
>                 URL: https://issues.apache.org/jira/browse/THRIFT-555
>             Project: Thrift
>          Issue Type: Bug
>          Components: Library (C++)
>    Affects Versions: 0.1
>         Environment: Mac OS X 10.5.7 PPC
>            Reporter: Rush Manbert
>            Assignee: Rush Manbert
>             Fix For: 0.2
>
>         Attachments: Patch-Thrift-555.txt
>
>
> On a PPC Mac, you end up getting the definitions at line 114 of TProtocol.h, and the macros htolell and letohll are not defined.
> It looks like they should be defined as:
> #  define htolell(n) bswap_64(n)
> #  define letohll(n) bswap_64(n)
> just like they are at line 111.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.