You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jmeter.apache.org by pm...@apache.org on 2012/02/02 20:58:13 UTC
svn commit: r1239798 -
/jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java
Author: pmouawad
Date: Thu Feb 2 19:58:13 2012
New Revision: 1239798
URL: http://svn.apache.org/viewvc?rev=1239798&view=rev
Log:
Bug 52552 - Help reference only works in English
Modified:
jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java
Modified: jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java
URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java?rev=1239798&r1=1239797&r2=1239798&view=diff
==============================================================================
--- jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java (original)
+++ jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java Thu Feb 2 19:58:13 2012
@@ -31,7 +31,9 @@ import java.util.Collection;
import java.util.HashMap;
import java.util.LinkedList;
import java.util.List;
+import java.util.Locale;
import java.util.Map;
+import java.util.ResourceBundle;
import javax.swing.JPopupMenu;
@@ -481,4 +483,18 @@ public class TestBeanGUI extends Abstrac
JMeterUtils.reportErrorToUser("Can't get beanInfo for " + testBeanClass.getName());
}
}
+
+ /**
+ * {@inheritDoc}}
+ * @see org.apache.jmeter.gui.AbstractJMeterGuiComponent#getDocAnchor()
+ */
+ @Override
+ public String getDocAnchor() {
+ ResourceBundle resourceBundle = ResourceBundle.getBundle(
+ testBeanClass.getName() + "Resources", // $NON-NLS-1$
+ new Locale("",""));
+
+ String name = resourceBundle.getString("displayName");
+ return name.replace(' ', '_');
+ }
}
Re: svn commit: r1239798 - /jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java
Posted by sebb <se...@gmail.com>.
On 2 February 2012 20:11, sebb <se...@gmail.com> wrote:
> On 2 February 2012 19:58, <pm...@apache.org> wrote:
>> Author: pmouawad
>> Date: Thu Feb 2 19:58:13 2012
>> New Revision: 1239798
>>
>> URL: http://svn.apache.org/viewvc?rev=1239798&view=rev
>> Log:
>> Bug 52552 - Help reference only works in English
>>
>
> Good - that has fixed it for me.
>
> Could the default resource bundle be fetched once?
Once per class ...
> Perhaps in JMeterUtils and shared?
That won't work.
>> Modified:
>> jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java
>>
>> Modified: jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java?rev=1239798&r1=1239797&r2=1239798&view=diff
>> ==============================================================================
>> --- jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java (original)
>> +++ jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java Thu Feb 2 19:58:13 2012
>> @@ -31,7 +31,9 @@ import java.util.Collection;
>> import java.util.HashMap;
>> import java.util.LinkedList;
>> import java.util.List;
>> +import java.util.Locale;
>> import java.util.Map;
>> +import java.util.ResourceBundle;
>>
>> import javax.swing.JPopupMenu;
>>
>> @@ -481,4 +483,18 @@ public class TestBeanGUI extends Abstrac
>> JMeterUtils.reportErrorToUser("Can't get beanInfo for " + testBeanClass.getName());
>> }
>> }
>> +
>> + /**
>> + * {@inheritDoc}}
>> + * @see org.apache.jmeter.gui.AbstractJMeterGuiComponent#getDocAnchor()
>> + */
>> + @Override
>> + public String getDocAnchor() {
>> + ResourceBundle resourceBundle = ResourceBundle.getBundle(
>> + testBeanClass.getName() + "Resources", // $NON-NLS-1$
>> + new Locale("",""));
>> +
>> + String name = resourceBundle.getString("displayName");
>> + return name.replace(' ', '_');
>> + }
>> }
>>
>>
Re: svn commit: r1239798 - /jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java
Posted by sebb <se...@gmail.com>.
On 2 February 2012 19:58, <pm...@apache.org> wrote:
> Author: pmouawad
> Date: Thu Feb 2 19:58:13 2012
> New Revision: 1239798
>
> URL: http://svn.apache.org/viewvc?rev=1239798&view=rev
> Log:
> Bug 52552 - Help reference only works in English
>
Good - that has fixed it for me.
Could the default resource bundle be fetched once?
Perhaps in JMeterUtils and shared?
> Modified:
> jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java
>
> Modified: jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java
> URL: http://svn.apache.org/viewvc/jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java?rev=1239798&r1=1239797&r2=1239798&view=diff
> ==============================================================================
> --- jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java (original)
> +++ jmeter/trunk/src/core/org/apache/jmeter/testbeans/gui/TestBeanGUI.java Thu Feb 2 19:58:13 2012
> @@ -31,7 +31,9 @@ import java.util.Collection;
> import java.util.HashMap;
> import java.util.LinkedList;
> import java.util.List;
> +import java.util.Locale;
> import java.util.Map;
> +import java.util.ResourceBundle;
>
> import javax.swing.JPopupMenu;
>
> @@ -481,4 +483,18 @@ public class TestBeanGUI extends Abstrac
> JMeterUtils.reportErrorToUser("Can't get beanInfo for " + testBeanClass.getName());
> }
> }
> +
> + /**
> + * {@inheritDoc}}
> + * @see org.apache.jmeter.gui.AbstractJMeterGuiComponent#getDocAnchor()
> + */
> + @Override
> + public String getDocAnchor() {
> + ResourceBundle resourceBundle = ResourceBundle.getBundle(
> + testBeanClass.getName() + "Resources", // $NON-NLS-1$
> + new Locale("",""));
> +
> + String name = resourceBundle.getString("displayName");
> + return name.replace(' ', '_');
> + }
> }
>
>