[GitHub] [couchdb] janl commented on a change in pull request #2390: feat: add metric counter for unindexed mango queries. Closes #1913

[GitBox <gi...@apache.org>]

janl commented on a change in pull request #2390: feat: add metric counter for unindexed mango queries. Closes #1913
URL: https://github.com/apache/couchdb/pull/2390#discussion_r363052411
 
 

 ##########
 File path: src/mango/src/mango_cursor.erl
 ##########
 @@ -182,6 +182,7 @@ maybe_add_warning_int(ok, _, UserAcc) ->
    UserAcc;
 
 maybe_add_warning_int(Warning, UserFun, UserAcc) ->
+    couch_stats:increment_counter([mango, unindexed_queries]),
 
 Review comment:
   the function clause in line 181 catches the `ok` case if I read things correctly. This function clause just unconditionally prints a warning, so I assumed I can just increment here without any additional logic

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services