You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/04/27 20:44:39 UTC

[GitHub] [hudi] bhasudha commented on a diff in pull request #5447: [HUDI-3943] Some description fixes for 0.10.1 docs

bhasudha commented on code in PR #5447:
URL: https://github.com/apache/hudi/pull/5447#discussion_r860229894


##########
pom.xml:
##########
@@ -127,8 +127,8 @@
     <hudi.flink.module>hudi-flink1.14.x</hudi.flink.module>
     <flink.bundle.version>1.14</flink.bundle.version>
     <flink.runtime.artifactId>flink-runtime</flink.runtime.artifactId>
-    <flink.table.runtime.artifactId>flink-table-runtime_${scala.binary.version}</flink.table.runtime.artifactId>

Review Comment:
   @CodeCooker17  can you help with context on these pom changes ? 



##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/config/HoodieClusteringConfig.java:
##########
@@ -87,7 +87,7 @@ public class HoodieClusteringConfig extends HoodieConfig {
       .key(CLUSTERING_STRATEGY_PARAM_PREFIX + "small.file.limit")
       .defaultValue(String.valueOf(300 * 1024 * 1024L))
       .sinceVersion("0.7.0")
-      .withDocumentation("Files smaller than the size specified here are candidates for clustering");
+      .withDocumentation("Files smaller than the size in bytes specified here are candidates for clustering");

Review Comment:
   +1



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org