You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "andygrove (via GitHub)" <gi...@apache.org> on 2026/05/23 13:36:05 UTC
[PR] ci: split iceberg_spark_test workflow per Iceberg version [datafusion-comet]
andygrove opened a new pull request, #4414:
URL: https://github.com/apache/datafusion-comet/pull/4414
## Summary
Splits `.github/workflows/iceberg_spark_test.yml` into one workflow per Iceberg version, mirroring the recent `spark_sql_test` split (#4408).
- New `iceberg_spark_test_reusable.yml` holds the build-native job and the three Iceberg test jobs (`iceberg-spark`, `iceberg-spark-extensions`, `iceberg-spark-runtime`), parameterized by Iceberg / Spark / Java version.
- Three thin callers — `iceberg_spark_test_1_8.yml`, `iceberg_spark_test_1_9.yml`, `iceberg_spark_test_1_10.yml` — each pin a single Spark version:
- Iceberg 1.8.1 → Spark 3.4.3 / JDK 11
- Iceberg 1.9.1 → Spark 3.5.8 / JDK 17
- Iceberg 1.10.0 → Spark 3.5.8 / JDK 17
- Only the latest (1.10) triggers on pull requests; 1.8 and 1.9 run on pushes to `main` only. All three remain `workflow_dispatch`-able.
- Updates `docs/source/contributor-guide/iceberg-spark-tests.md` to describe the new layout.
## Test plan
- [ ] `actionlint` passes on all four new workflow files.
- [ ] Wait for CI to confirm the 1.10 caller triggers on this PR (1.8 / 1.9 should not).
- [ ] After merge, verify push-to-main runs all three callers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: split iceberg_spark_test workflow per Iceberg version [datafusion-comet]
Posted by "github-advanced-security[bot] (via GitHub)" <gi...@apache.org>.
github-advanced-security[bot] commented on code in PR #4414:
URL: https://github.com/apache/datafusion-comet/pull/4414#discussion_r3292857787
##########
.github/workflows/iceberg_spark_test_1_8.yml:
##########
@@ -0,0 +1,57 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Runs on main only. Oldest supported Iceberg version, paired with Spark 3.4.
+name: Iceberg Spark SQL Tests (Iceberg 1.8)
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ branches:
+ - main
+ paths:
+ - "native/**/src/**"
+ - "native/**/Cargo.toml"
+ - "native/Cargo.lock"
+ - "!native/hdfs/**"
+ - "!native/fs-hdfs/**"
+ - "common/src/main/**"
+ - "common/pom.xml"
+ - "spark/src/main/**"
+ - "!spark/src/main/scala/org/apache/comet/GenerateDocs.scala"
+ - "spark/pom.xml"
+ - "dev/diffs/iceberg/**"
+ - "pom.xml"
+ - "rust-toolchain.toml"
+ - ".github/workflows/iceberg_spark_test_1_8.yml"
+ - ".github/workflows/iceberg_spark_test_reusable.yml"
+ - ".github/actions/setup-builder/**"
+ - ".github/actions/setup-iceberg-builder/**"
+ workflow_dispatch:
+
+jobs:
+ iceberg-spark:
+ uses: ./.github/workflows/iceberg_spark_test_reusable.yml
+ with:
+ iceberg-short: '1.8'
+ iceberg-full: '1.8.1'
+ spark-short: '3.4'
+ spark-full: '3.4.3'
+ java: 11
Review Comment:
## CodeQL / Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{}}
[Show more details](https://github.com/apache/datafusion-comet/security/code-scanning/85)
##########
.github/workflows/iceberg_spark_test_1_10.yml:
##########
@@ -0,0 +1,77 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Runs on every PR and on main. Latest supported Iceberg version, paired with
+# Spark 3.5.
+name: Iceberg Spark SQL Tests (Iceberg 1.10)
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ branches:
+ - main
+ paths:
+ - "native/**/src/**"
+ - "native/**/Cargo.toml"
+ - "native/Cargo.lock"
+ - "!native/hdfs/**"
+ - "!native/fs-hdfs/**"
+ - "common/src/main/**"
+ - "common/pom.xml"
+ - "spark/src/main/**"
+ - "!spark/src/main/scala/org/apache/comet/GenerateDocs.scala"
+ - "spark/pom.xml"
+ - "dev/diffs/iceberg/**"
+ - "pom.xml"
+ - "rust-toolchain.toml"
+ - ".github/workflows/iceberg_spark_test_1_10.yml"
+ - ".github/workflows/iceberg_spark_test_reusable.yml"
+ - ".github/actions/setup-builder/**"
+ - ".github/actions/setup-iceberg-builder/**"
+ pull_request:
+ paths:
+ - "native/**/src/**"
+ - "native/**/Cargo.toml"
+ - "native/Cargo.lock"
+ - "!native/hdfs/**"
+ - "!native/fs-hdfs/**"
+ - "common/src/main/**"
+ - "common/pom.xml"
+ - "spark/src/main/**"
+ - "!spark/src/main/scala/org/apache/comet/GenerateDocs.scala"
+ - "spark/pom.xml"
+ - "dev/diffs/iceberg/**"
+ - "pom.xml"
+ - "rust-toolchain.toml"
+ - ".github/workflows/iceberg_spark_test_1_10.yml"
+ - ".github/workflows/iceberg_spark_test_reusable.yml"
+ - ".github/actions/setup-builder/**"
+ - ".github/actions/setup-iceberg-builder/**"
+ workflow_dispatch:
+
+jobs:
+ iceberg-spark:
+ uses: ./.github/workflows/iceberg_spark_test_reusable.yml
+ with:
+ iceberg-short: '1.10'
+ iceberg-full: '1.10.0'
+ spark-short: '3.5'
+ spark-full: '3.5.8'
+ java: 17
Review Comment:
## CodeQL / Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{}}
[Show more details](https://github.com/apache/datafusion-comet/security/code-scanning/84)
##########
.github/workflows/iceberg_spark_test_1_9.yml:
##########
@@ -0,0 +1,57 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied. See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+# Runs on main only. Iceberg 1.9 paired with Spark 3.5.
+name: Iceberg Spark SQL Tests (Iceberg 1.9)
+
+concurrency:
+ group: ${{ github.repository }}-${{ github.head_ref || github.sha }}-${{ github.workflow }}
+ cancel-in-progress: true
+
+on:
+ push:
+ branches:
+ - main
+ paths:
+ - "native/**/src/**"
+ - "native/**/Cargo.toml"
+ - "native/Cargo.lock"
+ - "!native/hdfs/**"
+ - "!native/fs-hdfs/**"
+ - "common/src/main/**"
+ - "common/pom.xml"
+ - "spark/src/main/**"
+ - "!spark/src/main/scala/org/apache/comet/GenerateDocs.scala"
+ - "spark/pom.xml"
+ - "dev/diffs/iceberg/**"
+ - "pom.xml"
+ - "rust-toolchain.toml"
+ - ".github/workflows/iceberg_spark_test_1_9.yml"
+ - ".github/workflows/iceberg_spark_test_reusable.yml"
+ - ".github/actions/setup-builder/**"
+ - ".github/actions/setup-iceberg-builder/**"
+ workflow_dispatch:
+
+jobs:
+ iceberg-spark:
+ uses: ./.github/workflows/iceberg_spark_test_reusable.yml
+ with:
+ iceberg-short: '1.9'
+ iceberg-full: '1.9.1'
+ spark-short: '3.5'
+ spark-full: '3.5.8'
+ java: 17
Review Comment:
## CodeQL / Workflow does not contain permissions
Actions job or workflow does not limit the permissions of the GITHUB_TOKEN. Consider setting an explicit permissions block, using the following as a minimal starting point: {{}}
[Show more details](https://github.com/apache/datafusion-comet/security/code-scanning/86)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] ci: split iceberg_spark_test workflow per Iceberg version [datafusion-comet]
Posted by "mbutrovich (via GitHub)" <gi...@apache.org>.
mbutrovich merged PR #4414:
URL: https://github.com/apache/datafusion-comet/pull/4414
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org