You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2022/12/15 09:40:01 UTC
[GitHub] [spark] zhengruifeng opened a new pull request, #39074: [SPARK-41526][CONNECT][PYTHON] Implement `Column.isin`
zhengruifeng opened a new pull request, #39074:
URL: https://github.com/apache/spark/pull/39074
### What changes were proposed in this pull request?
Implement `Column.isin`
### Why are the changes needed?
for API coverage
### Does this PR introduce _any_ user-facing change?
yes, new API
### How was this patch tested?
added UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on a diff in pull request #39074: [SPARK-41526][CONNECT][PYTHON] Implement `Column.isin`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on code in PR #39074:
URL: https://github.com/apache/spark/pull/39074#discussion_r1049426752
##########
connector/connect/server/src/main/scala/org/apache/spark/sql/connect/planner/SparkConnectPlanner.scala:
##########
@@ -551,6 +551,13 @@ class SparkConnectPlanner(session: SparkSession) {
.Product(transformExpression(fun.getArgumentsList.asScala.head))
.toAggregateExpression())
+ case "in" =>
Review Comment:
if we don't intercept `in` here, it will fail with
```
raise self
grpc._channel._MultiThreadedRendezvous: <_MultiThreadedRendezvous of RPC that terminated with:
status = StatusCode.UNKNOWN
details = "[WRONG_NUM_ARGS.WITHOUT_SUGGESTION] Invalid number of arguments for the function `in`. Please, refer to 'https://spark.apache.org/docs/latest/sql-ref-functions.html' for a fix."
debug_error_string = "UNKNOWN:Error received from peer ipv6:%5B::1%5D:15002 {grpc_message:"[WRONG_NUM_ARGS.WITHOUT_SUGGESTION] Invalid number of arguments for the function `in`. Please, refer to \'https://spark.apache.org/docs/latest/sql-ref-functions.html\' for a fix.", grpc_status:2, created_time:"2022-12-15T17:17:23.380565+08:00"}"
>
```
This is the second case (the first one is `when`) that an expression has already been registered in `FunctionRegistry`, but do not have a constructor matching `UnresolvedFunction`.
I match them here instead of adding an extra constructor.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon commented on pull request #39074: [SPARK-41526][CONNECT][PYTHON] Implement `Column.isin`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on PR #39074:
URL: https://github.com/apache/spark/pull/39074#issuecomment-1352953634
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] zhengruifeng commented on pull request #39074: [SPARK-41526][CONNECT][PYTHON] Implement `Column.isin`
Posted by GitBox <gi...@apache.org>.
zhengruifeng commented on PR #39074:
URL: https://github.com/apache/spark/pull/39074#issuecomment-1354048740
@HyukjinKwon THank you for reivews
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] HyukjinKwon closed pull request #39074: [SPARK-41526][CONNECT][PYTHON] Implement `Column.isin`
Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #39074: [SPARK-41526][CONNECT][PYTHON] Implement `Column.isin`
URL: https://github.com/apache/spark/pull/39074
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org