[jira] [Commented] (THRIFT-3753) TServerFramework::stop may fail to interrupt connected clients

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-3753?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15330632#comment-15330632 ] 

ASF GitHub Bot commented on THRIFT-3753:
----------------------------------------

Github user jeking3 commented on the issue:

    https://github.com/apache/thrift/pull/959
  
    I recommend you rebase this against origin/master because the list of commits above leads me to believe it wasn't on origin/master to begin with, and the fix should be small.  Plus this will re-run the build so it passes, and we can look at merging it in.


> TServerFramework::stop may fail to interrupt connected clients
> --------------------------------------------------------------
>
>                 Key: THRIFT-3753
>                 URL: https://issues.apache.org/jira/browse/THRIFT-3753
>             Project: Thrift
>          Issue Type: Bug
>          Components: C++ - Library
>    Affects Versions: 0.9.3
>            Reporter: Ted Wang
>
> This is a sequence that exposes the race condition:
> (1) Thread-1: in serve(), blocked on accept()
> (2) Thread-2: in stop(), calls interrupt()
> (3) Thread-2: in stop(), in interruptChildren(), checked that socket is valid
> (4) Thread-1: in serve(), unblocked because of interrupt(), calls releaseOneDescriptor
> (5) Thread-2: in interruptChildren(), send fails so clients are not interrupted



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)