You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/03/10 07:58:05 UTC

[GitHub] [iotdb] neuyilan commented on a change in pull request #2787: [IOTDB-1193] Remove redundant sync meta leader in CManager for cluster module

neuyilan commented on a change in pull request #2787:
URL: https://github.com/apache/iotdb/pull/2787#discussion_r591175778



##########
File path: cluster/src/main/java/org/apache/iotdb/cluster/metadata/CMManager.java
##########
@@ -1335,12 +1332,6 @@ private boolean tryPullTimeSeriesSchemas(Node node, PullSchemaRequest request) {
    * @return all paths after removing wildcards in the path
    */
   public List<PartialPath> getMatchedPaths(PartialPath originPath) throws MetadataException {
-    // make sure this node knows all storage groups
-    try {
-      metaGroupMember.syncLeaderWithConsistencyCheck(false);
-    } catch (CheckConsistencyException e) {
-      throw new MetadataException(e);
-    }

Review comment:
       Hi, @LebronAl I see there are so many places use this method, how to make sure that this modification has no effect on the other logic that calls this function?
   
   The same as other methods.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org