You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ratis.apache.org by GitBox <gi...@apache.org> on 2021/02/20 05:39:40 UTC
[GitHub] [incubator-ratis] runzhiwang opened a new pull request #426: RATIS-1318. Remove incubating
runzhiwang opened a new pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426
## What changes were proposed in this pull request?
Remove incubating
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/RATIS-1318
## How was this patch tested?
no need new ut.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo merged pull request #426: RATIS-1318. Remove incubating
Posted by GitBox <gi...@apache.org>.
szetszwo merged pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on a change in pull request #426: RATIS-1318. Remove incubating
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on a change in pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426#discussion_r579609523
##########
File path: dev-support/vagrant/README.md
##########
@@ -13,7 +13,7 @@
-->
# What is this?
-This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache (Incubating) Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments.
+This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments.
Review comment:
Sure
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo commented on a change in pull request #426: RATIS-1318. Remove incubating
Posted by GitBox <gi...@apache.org>.
szetszwo commented on a change in pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426#discussion_r579607797
##########
File path: dev-support/vagrant/README.md
##########
@@ -13,7 +13,7 @@
-->
# What is this?
-This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache (Incubating) Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments.
+This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments.
Review comment:
There are quite many other changes required in vagrant. Let's change them all together in a separated JIRA?
```
-- ./dev-support/vagrant/README.md --------------------------------------------
16: This is a series of scripts for [Vagrant](https://vagrantup.com) to stand-up and test [Apache (Incubating) Ratis](https://ratis.incubator.apache.org/) servers and clients. One needs to have Vagrant and [VirtualBox](https://virtualbox.org) installed to stand-up these tests environments.
1 occurrence(s)
-- ./dev-support/vagrant/Vagrantfile ------------------------------------------
24: RATIS_PATH = ::File.join(VAGRANT_HOME, 'incubator-ratis')
1 occurrence(s)
-- ./dev-support/vagrant/bin/start_ratis_load_gen.sh --------------------------
22: cd ${HOME}/incubator-ratis
1 occurrence(s)
-- ./dev-support/vagrant/bin/start_ratis_server.sh ----------------------------
25: cd ${HOME}/incubator-ratis/
1 occurrence(s)
-- ./dev-support/vagrant/screenrcs/namazu_hdd_screenrc ------------------------
23: screen -t Disk0 0 /home/vagrant/namazu/bin/nmz inspectors fs -original-dir /home/vagrant/test_data/data0 -mount-point /home/vagrant/test_data/data0_slowed/ -autopilot /home/vagrant/incubator-ratis/dev-support/vagrant/namazu_configs/hdd_config.toml
24: screen -t Disk1 0 /home/vagrant/namazu/bin/nmz inspectors fs -original-dir /home/vagrant/test_data/data1 -mount-point /home/vagrant/test_data/data1_slowed/ -autopilot /home/vagrant/incubator-ratis/dev-support/vagrant/namazu_configs/hdd_config.toml
25: screen -t Disk2 0 /home/vagrant/namazu/bin/nmz inspectors fs -original-dir /home/vagrant/test_data/data2 -mount-point /home/vagrant/test_data/data2_slowed/ -autopilot /home/vagrant/incubator-ratis/dev-support/vagrant/namazu_configs/hdd_config.toml
3 occurrence(s)
-- ./dev-support/vagrant/screenrcs/ratis_ratis-hdd-slowdown_screenrc ----------
23: screen -t Server0 0 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data0_slowed n0 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
24: screen -t Server1 1 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data1_slowed n1 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
25: screen -t Server2 2 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data2_slowed n2 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
26: screen -t LoadGen 3 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_load_gen.sh n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
4 occurrence(s)
-- ./dev-support/vagrant/screenrcs/ratis_ratis-server_screenrc ----------------
23: screen -t Server0 0 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data0 n0 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
24: screen -t Server1 1 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data1 n1 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
25: screen -t Server2 2 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_server.sh /home/vagrant/test_data/data2 n2 n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
26: screen -t LoadGen 3 /home/vagrant/incubator-ratis/dev-support/vagrant/bin/start_ratis_load_gen.sh n0:127.0.0.1:6000,n1:127.0.0.1:6001,n2:127.0.0.1:6002
4 occurrence(s)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #426: RATIS-1318. Remove incubating
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426#issuecomment-782587486
@szetszwo Hi, I have updated the patch, there are other "incubator" and "incubating" related to repository name and email, so I did not change them.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo commented on pull request #426: RATIS-1318. Remove incubating
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426#issuecomment-782577005
@runzhiwang , I just have created https://dist.apache.org/repos/dist/dev/ratis/ and copied KEYS to there.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #426: RATIS-1318. Remove incubating
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426#issuecomment-782575039
```
-- ./dev-support/make_rc.sh ---------------------------------------------------
82: svn co https://dist.apache.org/repos/dist/dev/incubator/ratis "$SVNDISTDIR"
119: tar zvxf "$projectdir/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-src.tar.gz"
120: cd "apache-ratis-incubating-${RATISVERSION}"
130: cp "$WORKINGDIR/apache-ratis-incubating-${RATISVERSION}/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-bin.tar.gz" "apache-ratis-incubating-${RATISVERSION}-bin.tar.gz"
131: cp "$projectdir/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-src.tar.gz" "apache-ratis-incubating-${RATISVERSION}-src.tar.gz"
182: 10. (If the vote passed): Send out the next voting mail to the incubator mailing list.
```
@szetszwo Hi, line 119, 120, 130, 131 already changed in this PR. line 82 need to change dir, if we remove incubator, the dir will be https://dist.apache.org/repos/dist/dev/ratis, which does not exist.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo commented on pull request #426: RATIS-1318. Remove incubating
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426#issuecomment-782573452
@runzhiwang , thanks a lot for working on this. There are a few other "incubator" or "incubating" found in make_rc.sh.
{code}
-- ./dev-support/make_rc.sh ---------------------------------------------------
82: svn co https://dist.apache.org/repos/dist/dev/incubator/ratis "$SVNDISTDIR"
119: tar zvxf "$projectdir/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-src.tar.gz"
120: cd "apache-ratis-incubating-${RATISVERSION}"
130: cp "$WORKINGDIR/apache-ratis-incubating-${RATISVERSION}/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-bin.tar.gz" "apache-ratis-incubating-${RATISVERSION}-bin.tar.gz"
131: cp "$projectdir/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-src.tar.gz" "apache-ratis-incubating-${RATISVERSION}-src.tar.gz"
182: 10. (If the vote passed): Send out the next voting mail to the incubator mailing list.
{code}
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo commented on pull request #426: RATIS-1318. Remove incubating
Posted by GitBox <gi...@apache.org>.
szetszwo commented on pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426#issuecomment-782577994
Yes, we should put the 2.0.0 release to the new dir. For the old releases, we will move them once we have fixed the links in the web pages.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] runzhiwang commented on pull request #426: RATIS-1318. Remove incubating
Posted by GitBox <gi...@apache.org>.
runzhiwang commented on pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426#issuecomment-782577324
> I just have created https://dist.apache.org/repos/dist/dev/ratis/ and copied KEYS to there.
@szetszwo Thanks, do we put release 2.0.0 to https://dist.apache.org/repos/dist/dev/ratis/? and do we need to copy the previous release such as 1.0.0 to https://dist.apache.org/repos/dist/dev/ratis/?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-ratis] szetszwo edited a comment on pull request #426: RATIS-1318. Remove incubating
Posted by GitBox <gi...@apache.org>.
szetszwo edited a comment on pull request #426:
URL: https://github.com/apache/incubator-ratis/pull/426#issuecomment-782573452
@runzhiwang , thanks a lot for working on this. There are a few other "incubator" or "incubating" found in make_rc.sh.
```
-- ./dev-support/make_rc.sh ---------------------------------------------------
82: svn co https://dist.apache.org/repos/dist/dev/incubator/ratis "$SVNDISTDIR"
119: tar zvxf "$projectdir/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-src.tar.gz"
120: cd "apache-ratis-incubating-${RATISVERSION}"
130: cp "$WORKINGDIR/apache-ratis-incubating-${RATISVERSION}/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-bin.tar.gz" "apache-ratis-incubating-${RATISVERSION}-bin.tar.gz"
131: cp "$projectdir/ratis-assembly/target/apache-ratis-incubating-${RATISVERSION}-src.tar.gz" "apache-ratis-incubating-${RATISVERSION}-src.tar.gz"
182: 10. (If the vote passed): Send out the next voting mail to the incubator mailing list.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org