You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@wicket.apache.org by "Frank Klein Koerkamp (JIRA)" <ji...@apache.org> on 2010/09/20 10:34:36 UTC

[jira] Created: (WICKET-3060) Remove final from getFooter and header on AbstractAutoCompleteRenderer

Remove final from getFooter and header on AbstractAutoCompleteRenderer
----------------------------------------------------------------------

                 Key: WICKET-3060
                 URL: https://issues.apache.org/jira/browse/WICKET-3060
             Project: Wicket
          Issue Type: Improvement
          Components: wicket-extensions
    Affects Versions: 1.5-M2.1, 1.4.12
            Reporter: Frank Klein Koerkamp


Remove final so that i can add some message on the end of options. Like showing '25 of 100 options'. so that the user nows it should insert more input.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3060) Remove final from getFooter and header on AbstractAutoCompleteRenderer

Posted by "Frank Klein Koerkamp (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Frank Klein Koerkamp updated WICKET-3060:
-----------------------------------------

    Priority: Minor  (was: Major)

> Remove final from getFooter and header on AbstractAutoCompleteRenderer
> ----------------------------------------------------------------------
>
>                 Key: WICKET-3060
>                 URL: https://issues.apache.org/jira/browse/WICKET-3060
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 1.4.12, 1.5-M2.1
>            Reporter: Frank Klein Koerkamp
>            Priority: Minor
>
> Remove final so that i can add some message on the end of options. Like showing '25 of 100 options'. so that the user nows it should insert more input.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (WICKET-3060) Remove final from getFooter and header on AbstractAutoCompleteRenderer

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-3060:
------------------------------------

    Attachment: WICKET-3060.patch

Do you mean renderHeader() and renderFooter() ? Because there are no get** methods.
If we remove 'final' from these methods then we will need to either remove 'final' from render() of rework it because there are related.
See my suggestion in the attached patch. Does this work for you ?

> Remove final from getFooter and header on AbstractAutoCompleteRenderer
> ----------------------------------------------------------------------
>
>                 Key: WICKET-3060
>                 URL: https://issues.apache.org/jira/browse/WICKET-3060
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 1.4.12, 1.5-M2.1
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>            Priority: Minor
>         Attachments: WICKET-3060.patch
>
>
> Remove final so that i can add some message on the end of options. Like showing '25 of 100 options'. so that the user nows it should insert more input.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (WICKET-3060) Remove final from getFooter and header on AbstractAutoCompleteRenderer

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/WICKET-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12914854#action_12914854 ] 

Hudson commented on WICKET-3060:
--------------------------------

Integrated in Apache Wicket 1.5.x #362 (See [https://hudson.apache.org/hudson/job/Apache%20Wicket%201.5.x/362/])
    WICKET-3060 Format the file. No functional changes


> Remove final from getFooter and header on AbstractAutoCompleteRenderer
> ----------------------------------------------------------------------
>
>                 Key: WICKET-3060
>                 URL: https://issues.apache.org/jira/browse/WICKET-3060
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 1.4.12, 1.5-M2.1
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>            Priority: Minor
>         Attachments: WICKET-3060.patch
>
>
> Remove final so that i can add some message on the end of options. Like showing '25 of 100 options'. so that the user nows it should insert more input.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Assigned: (WICKET-3060) Remove final from getFooter and header on AbstractAutoCompleteRenderer

Posted by "Martin Grigorov (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/WICKET-3060?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov reassigned WICKET-3060:
---------------------------------------

    Assignee: Martin Grigorov

> Remove final from getFooter and header on AbstractAutoCompleteRenderer
> ----------------------------------------------------------------------
>
>                 Key: WICKET-3060
>                 URL: https://issues.apache.org/jira/browse/WICKET-3060
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket-extensions
>    Affects Versions: 1.4.12, 1.5-M2.1
>            Reporter: Frank Klein Koerkamp
>            Assignee: Martin Grigorov
>            Priority: Minor
>
> Remove final so that i can add some message on the end of options. Like showing '25 of 100 options'. so that the user nows it should insert more input.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.