You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/12/15 11:03:28 UTC
[GitHub] [cloudstack] shwstppr opened a new pull request, #6994: ui: fix persist networks config in deploy vm form
shwstppr opened a new pull request, #6994:
URL: https://github.com/apache/cloudstack/pull/6994
### Description
Fixes #6974
### Types of changes
- [ ] Breaking change (fix or feature that would cause existing functionality to change)
- [ ] New feature (non-breaking change which adds functionality)
- [x] Bug fix (non-breaking change which fixes an issue)
- [ ] Enhancement (improves an existing feature and functionality)
- [ ] Cleanup (Code refactoring and cleanup, that may add test cases)
### Feature/Enhancement Scale or Bug Severity
#### Feature/Enhancement Scale
- [ ] Major
- [ ] Minor
#### Bug Severity
- [ ] BLOCKER
- [ ] Critical
- [ ] Major
- [ ] Minor
- [ ] Trivial
### Screenshots (if appropriate):
https://user-images.githubusercontent.com/153340/207843215-9c106497-e388-4ef8-8ca9-3c29d9a79010.mp4
### How Has This Been Tested?
<!-- Please describe in detail how you tested your changes. -->
<!-- Include details of your testing environment, and the tests you ran to -->
<!-- see how your change affects other areas of the code, etc. -->
<!-- Please read the [CONTRIBUTING](https://github.com/apache/cloudstack/blob/main/CONTRIBUTING.md) document -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] codecov[bot] commented on pull request #6994: ui: fix persist networks config in deploy vm form
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #6994:
URL: https://github.com/apache/cloudstack/pull/6994#issuecomment-1353159282
# [Codecov](https://codecov.io/gh/apache/cloudstack/pull/6994?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#6994](https://codecov.io/gh/apache/cloudstack/pull/6994?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (29c9216) into [main](https://codecov.io/gh/apache/cloudstack/commit/0075717612533dae29ceb531741ef93c2131fc67?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0075717) will **increase** coverage by `1.13%`.
> The diff coverage is `n/a`.
```diff
@@ Coverage Diff @@
## main #6994 +/- ##
============================================
+ Coverage 10.36% 11.50% +1.13%
- Complexity 6631 7534 +903
============================================
Files 2453 2492 +39
Lines 242385 246774 +4389
Branches 37927 38559 +632
============================================
+ Hits 25126 28390 +3264
- Misses 214156 214787 +631
- Partials 3103 3597 +494
```
| [Impacted Files](https://codecov.io/gh/apache/cloudstack/pull/6994?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../cloudstack/api/response/ApiDiscoveryResponse.java](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hcGkvZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9BcGlEaXNjb3ZlcnlSZXNwb25zZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../cloudstack/api/response/ApiParameterResponse.java](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hcGkvZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9BcGlQYXJhbWV0ZXJSZXNwb25zZS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...e/cloudstack/api/response/ApiResponseResponse.java](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hcGkvZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2FwaS9yZXNwb25zZS9BcGlSZXNwb25zZVJlc3BvbnNlLmphdmE=) | `0.00% <0.00%> (-80.00%)` | :arrow_down: |
| [.../cloudstack/discovery/ApiDiscoveryServiceImpl.java](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9hcGkvZGlzY292ZXJ5L3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL2Rpc2NvdmVyeS9BcGlEaXNjb3ZlcnlTZXJ2aWNlSW1wbC5qYXZh) | `13.93% <0.00%> (-55.25%)` | :arrow_down: |
| [...rce/wrapper/LibvirtResizeVolumeCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UmVzaXplVm9sdW1lQ29tbWFuZFdyYXBwZXIuamF2YQ==) | `49.50% <0.00%> (-27.17%)` | :arrow_down: |
| [...rc/main/java/com/cloud/storage/StorageManager.java](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZW5naW5lL2NvbXBvbmVudHMtYXBpL3NyYy9tYWluL2phdmEvY29tL2Nsb3VkL3N0b3JhZ2UvU3RvcmFnZU1hbmFnZXIuamF2YQ==) | `76.92% <0.00%> (-23.08%)` | :arrow_down: |
| [...org/apache/cloudstack/quota/vo/QuotaBalanceVO.java](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-ZnJhbWV3b3JrL3F1b3RhL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9jbG91ZHN0YWNrL3F1b3RhL3ZvL1F1b3RhQmFsYW5jZVZPLmphdmE=) | `28.20% <0.00%> (-17.95%)` | :arrow_down: |
| [.../cloud/hypervisor/kvm/storage/KVMPhysicalDisk.java](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vc3RvcmFnZS9LVk1QaHlzaWNhbERpc2suamF2YQ==) | `70.45% <0.00%> (-10.80%)` | :arrow_down: |
| [...pper/LibvirtPrepareForMigrationCommandWrapper.java](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9oeXBlcnZpc29ycy9rdm0vc3JjL21haW4vamF2YS9jb20vY2xvdWQvaHlwZXJ2aXNvci9rdm0vcmVzb3VyY2Uvd3JhcHBlci9MaWJ2aXJ0UHJlcGFyZUZvck1pZ3JhdGlvbkNvbW1hbmRXcmFwcGVyLmphdmE=) | `43.10% <0.00%> (-10.09%)` | :arrow_down: |
| [...e/cloudstack/api/command/QuotaTariffUpdateCmd.java](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGx1Z2lucy9kYXRhYmFzZS9xdW90YS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvY2xvdWRzdGFjay9hcGkvY29tbWFuZC9RdW90YVRhcmlmZlVwZGF0ZUNtZC5qYXZh) | `44.00% <0.00%> (-8.39%)` | :arrow_down: |
| ... and [252 more](https://codecov.io/gh/apache/cloudstack/pull/6994/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
:mega: We’re building smart automated test selection to slash your CI/CD build times. [Learn more](https://about.codecov.io/iterative-testing/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #6994: ui: persist networks config in deploy vm form
Posted by GitBox <gi...@apache.org>.
soreana commented on PR #6994:
URL: https://github.com/apache/cloudstack/pull/6994#issuecomment-1358326457
> Thanks @shwstppr . @soreana can you test if this solves your issue (#6974)?
Thanks, @shwstppr, and @DaanHoogland. I've tested it and it looks good. I will also ask my colleagues to look at it tomorrow.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] soreana commented on pull request #6994: ui: persist networks config in deploy vm form
Posted by GitBox <gi...@apache.org>.
soreana commented on PR #6994:
URL: https://github.com/apache/cloudstack/pull/6994#issuecomment-1359522072
@DaanHoogland We've checked the PR. It works as expected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland commented on pull request #6994: ui: persist networks config in deploy vm form
Posted by GitBox <gi...@apache.org>.
DaanHoogland commented on PR #6994:
URL: https://github.com/apache/cloudstack/pull/6994#issuecomment-1354589061
Thanks @shwstppr . @soreana can you test if this solves your issue (#6974)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack] DaanHoogland merged pull request #6994: ui: persist networks config in deploy vm form
Posted by GitBox <gi...@apache.org>.
DaanHoogland merged PR #6994:
URL: https://github.com/apache/cloudstack/pull/6994
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org