[GitHub] jaydoane opened a new pull request #1782: Only validate partitioned db name if db is partitioned

[GitBox <gi...@apache.org>]

jaydoane opened a new pull request #1782: Only validate partitioned db name if db is partitioned
URL: https://github.com/apache/couchdb/pull/1782
 
 
   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   
   Maybe there's already code to check whether the {partitioned, true} prop is present, but I didn't see
   it. In any case, this seems like one way to do it.
   
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ```
   $ mix test --trace test/partition_crud_test.exs:299
   Including tags: [line: "299"]
   Excluding tags: [:test]
   
   
   PartitionCrudTest
     * test can create unpartitioned system db (218.2ms)
     * test _bulk_docs saves docs with partition key (skipped)
     * test Sets partition in db info (skipped)
     * test create database with bad `partitioned` value (skipped)
     * test _bulk_docs errors with bad partition key (skipped)
     * test _bulk_get bad partitioned document (skipped)
     * test POST and GET document (skipped)
     * test _bulk_docs errors with bad doc key (skipped)
     * test saves attachment with partitioned doc (skipped)
     * test POST and _bulk_get document (skipped)
     * test cannot create partitioned system db (skipped)
     * test PUT fails if a partition key is not supplied (skipped)
     * test POST fails if a partition key is not supplied (skipped)
     * test PUT fails for partitions with _ (skipped)
     * test PUT fails for bad partitions (skipped)
     * test _bulk_docs errors with missing partition key (skipped)
     * test PUT and GET document (skipped)
   
   CouchTestCase
   
   PartitionHelpers
   
   
   Finished in 0.3 seconds
   17 tests, 0 failures, 16 skipped
   ```
   
   ## Related Issues or Pull Requests
   
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [x] Code is written and works correctly;
   - [x] Changes are covered by tests;
   - [ ] Documentation reflects the changes;
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services