You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2016/11/08 15:58:35 UTC

[GitHub] spark pull request #15262: [SPARK-17690][STREAMING][SQL] Add mini-dfs cluste...

Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/15262#discussion_r87019344
  
    --- Diff: pom.xml ---
    @@ -800,6 +800,32 @@
             <version>${curator.version}</version>
             <scope>test</scope>
           </dependency>
    +	  <dependency>
    --- End diff --
    
    This does seem like a lot of build complexity relative to its value.
    
    BTW isn't this taking Hadoop or some of its dependencies out of compile scope? I am not sure why it would entail the changes to the deps files above


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org