[storm] branch master updated: [MINOR] makes the exception message more clear in StormSubmitter

[et...@apache.org]

This is an automated email from the ASF dual-hosted git repository.

ethanli pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/storm.git


The following commit(s) were added to refs/heads/master by this push:
     new ad4093a  [MINOR] makes the exception message more clear in StormSubmitter
     new c33ae62  Merge pull request #3256 from Ethanlm/minor-log-fixing
ad4093a is described below

commit ad4093ac68d52cc42d04624064a5a901c20292df
Author: Ethan Li <et...@gmail.com>
AuthorDate: Tue Apr 21 13:32:18 2020 -0500

    [MINOR] makes the exception message more clear in StormSubmitter
---
 storm-client/src/jvm/org/apache/storm/StormSubmitter.java | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/storm-client/src/jvm/org/apache/storm/StormSubmitter.java b/storm-client/src/jvm/org/apache/storm/StormSubmitter.java
index d391784..f782272 100644
--- a/storm-client/src/jvm/org/apache/storm/StormSubmitter.java
+++ b/storm-client/src/jvm/org/apache/storm/StormSubmitter.java
@@ -252,8 +252,8 @@ public class StormSubmitter {
         try {
             String serConf = JSONValue.toJSONString(topoConf);
             try (NimbusClient client = NimbusClient.getConfiguredClientAs(conf, asUser)) {
-                if (isTopologyNameAllowed(name, client)) {
-                    throw new RuntimeException("Topology with name `" + name + "` is either not allowed or it already exists on cluster");
+                if (!isTopologyNameAllowed(name, client)) {
+                    throw new RuntimeException("Topology name " + name + " is either not allowed or it already exists on the cluster");
                 }
 
                 // Dependency uploading only makes sense for distributed mode
@@ -438,7 +438,7 @@ public class StormSubmitter {
 
     private static boolean isTopologyNameAllowed(String name, NimbusClient client) {
         try {
-            return !client.getClient().isTopologyNameAllowed(name);
+            return client.getClient().isTopologyNameAllowed(name);
         } catch (Exception e) {
             throw new RuntimeException(e);
         }