[Bug 7941] New: sql/txrep_sqlite.sql: typo in UPDATE trigger column name breaks txrep DB

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7941

            Bug ID: 7941
           Summary: sql/txrep_sqlite.sql: typo in UPDATE trigger column
                    name breaks txrep DB
           Product: Spamassassin
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: NEW
          Severity: normal
          Priority: P2
         Component: spamassassin
          Assignee: dev@spamassassin.apache.org
          Reporter: mail@maciej.szmigiero.name
  Target Milestone: Undefined

sql/txrep_sqlite.sql has a typo in UPDATE trigger column name: [1] should be
[2] (note the "hot" vs "hit").

This typo breaks UPDATE operations on txrep DBs created from that script.

While at it I would suggest applying the attached patch to
"SQLBasedAddrList.pm" so errors like this one (happening at DBI prepare
operation) are correctly handled and logged, instead of printing just [3] which
doesn't give a clue what is wrong.

References:
[1]: WHEN NEW.last_hot < OLD.last_hit

[2]: WHEN NEW.last_hit < OLD.last_hit

[3]: Can't call method "execute" on an undefined value

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7941] sql/txrep_sqlite.sql: typo in UPDATE trigger column name breaks txrep DB

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7941

Matija Nalis <mn...@voyager.hr> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mnalis-sabug@voyager.hr

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7941] sql/txrep_sqlite.sql: typo in UPDATE trigger column name breaks txrep DB

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7941

Maciej S. Szmigiero <ma...@maciej.szmigiero.name> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |mail@maciej.szmigiero.name

--- Comment #1 from Maciej S. Szmigiero <ma...@maciej.szmigiero.name> ---
Created attachment 5757
  --> https://bz.apache.org/SpamAssassin/attachment.cgi?id=5757&action=edit
show DBI prepare operation errors

-- 
You are receiving this mail because:
You are the assignee for the bug.

[Bug 7941] sql/txrep_sqlite.sql: typo in UPDATE trigger column name breaks txrep DB

[bu...@spamassassin.apache.org]

https://bz.apache.org/SpamAssassin/show_bug.cgi?id=7941

Henrik Krohns <ap...@hege.li> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
   Target Milestone|Undefined                   |4.0.0
                 OS|Linux                       |All
                 CC|                            |apache@hege.li
           Hardware|PC                          |All
         Resolution|---                         |FIXED

--- Comment #2 from Henrik Krohns <ap...@hege.li> ---
Thanks, there were many $sth checks missing.

Sending        trunk/lib/Mail/SpamAssassin/SQLBasedAddrList.pm
Sending        trunk/sql/txrep_sqlite.sql
Transmitting file data ..done
Committing transaction...
Committed revision 1899744.

-- 
You are receiving this mail because:
You are the assignee for the bug.