You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2020/05/16 20:20:28 UTC
[GitHub] [cloudstack-primate] GabrielBrascher opened a new pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
GabrielBrascher opened a new pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343
Advanced Network with Security Groups is a great option for deploying a Zone with IPv6 address support. However, it is not possible to set IPv6 DNS + IPv6 CIDR + IPv6 gateway via the zoneWizard UI.
This PR adds a small enhancement on the UI Zone deployment to allow deploying a Zone with Advanced Network with Security Groups + IPv6 CIDR, IPv6 gateway, and IPv6 DNS.
Note that API [1] offers full support for such action, therefore there is no need for changing the API. It is just a small enhancement on UI that might be useful in the meantime that we wait for the new ACS UI.
[1] https://cloudstack.apache.org/api/apidocs-4.13/apis/createNetwork.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#issuecomment-639263836
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] GabrielBrascher commented on a change in pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#discussion_r439159540
##########
File path: src/views/infra/zone/ZoneWizardZoneDetailsStep.vue
##########
@@ -120,6 +120,43 @@
}]"
/>
</a-form-item>
+ <a-form-item
+ :label="$t('ip6cidr')"
+ v-bind="formItemLayout"
+ v-if="isAdvancedZone && securityGroupsEnabled"
+ has-feedback>
+ <a-input
+ v-decorator="['ipv6Cidr', {
+ rules: [
+ {
+ message: 'Please enter IpV6 CIDR',
+ initialValue: ip6cidr
+ }
+ ]
+ }]"
+ />
+ </a-form-item>
+ <a-form-item
+ :label="$t('ip6gateway')"
+ v-bind="formItemLayout"
+ v-if="isAdvancedZone && securityGroupsEnabled"
Review comment:
IPv6 gateway and CIDR are handled on an advanced network with security group enabled. I don't see any harm in adding it to any type of zone network; however, that might lead users to believe that ACS will provide IPv6 support to the zone.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#issuecomment-631891797
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive. JID-1933
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#issuecomment-631889772
@rhtyd a Jenkins job has been kicked to build primate packages. I'll keep you posted as I make progress.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] blueorangutan commented on pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
blueorangutan commented on pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#issuecomment-639269405
Packaging result: :heavy_check_mark:centos :heavy_check_mark:debian :heavy_check_mark:archive.
QA: http://primate-qa.cloudstack.cloud:8080/client/pr/343 (JID-1973)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#issuecomment-639263626
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd merged pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
rhtyd merged pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#issuecomment-631889603
Hi @GabrielBrascher - have you tested this by deploying a zone, does it pass/fail? Thanks.
@blueorangutan package
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#issuecomment-643069467
Thanks @GabrielBrascher for your replies, the PR was already tested and merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on a change in pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
rhtyd commented on a change in pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#discussion_r434402062
##########
File path: src/views/infra/zone/ZoneWizardZoneDetailsStep.vue
##########
@@ -120,6 +120,43 @@
}]"
/>
</a-form-item>
+ <a-form-item
+ :label="$t('ip6cidr')"
+ v-bind="formItemLayout"
+ v-if="isAdvancedZone && securityGroupsEnabled"
Review comment:
Is this setting/field only taken into consideration when SG is enabled @GabrielBrascher ?
##########
File path: src/views/infra/zone/ZoneWizardZoneDetailsStep.vue
##########
@@ -120,6 +120,43 @@
}]"
/>
</a-form-item>
+ <a-form-item
+ :label="$t('ip6cidr')"
+ v-bind="formItemLayout"
+ v-if="isAdvancedZone && securityGroupsEnabled"
+ has-feedback>
+ <a-input
+ v-decorator="['ipv6Cidr', {
+ rules: [
+ {
+ message: 'Please enter IpV6 CIDR',
+ initialValue: ip6cidr
+ }
+ ]
+ }]"
+ />
+ </a-form-item>
+ <a-form-item
+ :label="$t('ip6gateway')"
+ v-bind="formItemLayout"
+ v-if="isAdvancedZone && securityGroupsEnabled"
Review comment:
Is this setting/field only taken into consideration when SG is enabled @GabrielBrascher ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] rhtyd commented on pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
rhtyd commented on pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#issuecomment-639409976
Tested on live env, LGTM; fixed translation label issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] GabrielBrascher commented on pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#issuecomment-633994950
@rhtyd I will run a few more tests this week.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [cloudstack-primate] GabrielBrascher commented on a change in pull request #343: Allow configuring IPv6 default guest network when deploying a new Zone
Posted by GitBox <gi...@apache.org>.
GabrielBrascher commented on a change in pull request #343:
URL: https://github.com/apache/cloudstack-primate/pull/343#discussion_r439159086
##########
File path: src/views/infra/zone/ZoneWizardZoneDetailsStep.vue
##########
@@ -120,6 +120,43 @@
}]"
/>
</a-form-item>
+ <a-form-item
+ :label="$t('ip6cidr')"
+ v-bind="formItemLayout"
+ v-if="isAdvancedZone && securityGroupsEnabled"
Review comment:
Sorry for the late reply @rhtyd.
So far there is no support for IPv6 via VPC/VRs. Therefore, the zone must be an Advanced zone with Security Group enabled to handle IPv6 allocation and ACLs.
Thanks for the review!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org