You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by GitBox <gi...@apache.org> on 2022/06/27 12:03:50 UTC
[GitHub] [flink-table-store] JingsongLi opened a new pull request, #177: [FLINK-28264] Refactor split and read in table store
JingsongLi opened a new pull request, #177:
URL: https://github.com/apache/flink-table-store/pull/177
Refactor split and read, for better Hybrid reading. The full and incremental read paths should be different, otherwise it is easy to get bugs.
* Add boolean isIncremental to Split
* Use Split in Flink Source Split and Hive Split
* FileStoreRead.createReader(Split)
* Create ConcatRecordReader or MergeTreeReader by Split.isIncremental
* Do key projection in KeyValueFileStoreRead.createReader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #177: [FLINK-28264] Refactor split and read in table store
Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #177:
URL: https://github.com/apache/flink-table-store/pull/177#discussion_r908011725
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/table/FileStoreTableFactory.java:
##########
@@ -56,13 +56,14 @@ public static FileStoreTable create(Configuration conf, String user) {
tableSchema = tableSchema.copy(newOptions);
if (conf.get(FileStoreOptions.WRITE_MODE) == WriteMode.APPEND_ONLY) {
- return new AppendOnlyFileStoreTable(name, schemaManager, tableSchema, user);
+ return new AppendOnlyFileStoreTable(tablePath, schemaManager, tableSchema, user);
Review Comment:
Nit: `name` can be removed. See L#41
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] JingsongLi merged pull request #177: [FLINK-28264] Refactor split and read in table store
Posted by GitBox <gi...@apache.org>.
JingsongLi merged PR #177:
URL: https://github.com/apache/flink-table-store/pull/177
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [flink-table-store] LadyForest commented on a diff in pull request #177: [FLINK-28264] Refactor split and read in table store
Posted by GitBox <gi...@apache.org>.
LadyForest commented on code in PR #177:
URL: https://github.com/apache/flink-table-store/pull/177#discussion_r907977310
##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreRead.java:
##########
@@ -33,6 +31,5 @@
public interface FileStoreRead<T> {
/** Create a {@link RecordReader} from partition and bucket and files. */
Review Comment:
Nit: modify the comment since the input argument has changed.
```suggestion
/** Create a {@link RecordReader} from split. */
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org