[jira] [Comment Edited] (HBASE-26969) Eliminate MOB renames when SFT is enabled

["Szabolcs Bukros (Jira)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-26969?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17580779#comment-17580779 ] 

Szabolcs Bukros edited comment on HBASE-26969 at 8/17/22 1:09 PM:
------------------------------------------------------------------

[~apurtell] [~huaxiangsun] Please find [#4712|https://github.com/apache/hbase/pull/4712] with the branch-2 backport.
Please note I made some additional changes:
 *   [#4617|https://github.com/apache/hbase/pull/4617] left 2 test classes in the code that the original commit deleted and I had to delete them here.
 * HBASE-25970 is another dependency I missed in HBASE-27154. To shorten the review cycles instead of backporting it separately I included the changes it contained in this PR. Please let me know if that would not be acceptable and I prepare a separate PR for that backport.


was (Author: bszabolcs):
[~apurtell] [~huaxiangsun] Please find #4712 with the branch-2 backport.
Please note I made some additional changes:
 *   [#4617|https://github.com/apache/hbase/pull/4617] left 2 test classes in the code that the original commit deleted and I had to delete them here.
 * HBASE-25970 is another dependency I missed in HBASE-27154. To shorten the review cycles instead of backporting it separately I included the changes it contained in this PR. Please let me know if that would not be acceptable and I prepare a separate PR for that backport.

> Eliminate MOB renames when SFT is enabled
> -----------------------------------------
>
>                 Key: HBASE-26969
>                 URL: https://issues.apache.org/jira/browse/HBASE-26969
>             Project: HBase
>          Issue Type: Sub-task
>          Components: mob
>    Affects Versions: 2.5.0, 3.0.0-alpha-3
>            Reporter: Szabolcs Bukros
>            Assignee: Szabolcs Bukros
>            Priority: Major
>             Fix For: 2.5.0, 3.0.0-alpha-4
>
>
> MOB file compaction and flush still relies on renames even when SFT is enabled.
> My proposed changes are:
>  * when requireWritingToTmpDirFirst is false during mob flush/compact instead of using the temp writer we should create a different writer using a {color:#000000}StoreFileWriterCreationTracker that writes directly to the mob store folder{color}
>  * {color:#000000}these StoreFileWriterCreationTracker should be stored in the MobStore. This would requires us to extend MobStore with a createWriter and a finalizeWriter method to handle this{color}
>  * {color:#000000}refactor {color}MobFileCleanerChore to run on the RS instead on Master to allow access to the {color:#000000}StoreFileWriterCreationTracker{color}s to make sure the currently written files are not cleaned up



--
This message was sent by Atlassian Jira
(v8.20.10#820010)