You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/12/27 17:21:54 UTC

[GitHub] [airflow] jsnb-devoted commented on pull request #28563: Change trigger name so kwargs arent logged

jsnb-devoted commented on PR #28563:
URL: https://github.com/apache/airflow/pull/28563#issuecomment-1366059570

   > > I'm passing in a bearer token as part of the trigger's kwargs
   > 
   > That sounds like a bad idea, why do you need to do that?
   
   @kaxil / @dstandish I'm doing this so that I don't have to keep authenticating with the API every time the trigger runs. I'm totally open to this being a bad idea but I was just trying to get an MVP of this working. Is the best practice here to have to authenticate every time the trigger runs?
   
   Seemed like the logging of all the kwargs was more incidental than anything so I thought I would propose the change. If logging all of the kwargs was intended then no sweat if we want to close this.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org