[GitHub] [accumulo] cshannon commented on a diff in pull request #3331: Reuse already read lastLocation information during location updates

["cshannon (via GitHub)" <gi...@apache.org>]

cshannon commented on code in PR #3331:
URL: https://github.com/apache/accumulo/pull/3331#discussion_r1180539655


##########
server/base/src/main/java/org/apache/accumulo/server/util/ManagerMetadataUtil.java:
##########
@@ -253,18 +253,16 @@ public static Optional<StoredTabletFile> updateTabletDataFile(ServerContext cont
    * last location if needed and set the new last location
    *
    * @param context The server context
-   * @param ample The metadata persistence layer
    * @param tabletMutator The mutator being built
-   * @param extent The tablet extent
    * @param location The new location
+   * @param lastLocation The previous last location, which may be null
    */
-  public static void updateLastForAssignmentMode(ClientContext context, Ample ample,
-      Ample.TabletMutator tabletMutator, KeyExtent extent, TServerInstance location) {
+  public static void updateLastForAssignmentMode(ClientContext context,
+      Ample.TabletMutator tabletMutator, TServerInstance location, Location lastLocation) {
     // if the location mode is assignment, then preserve the current location in the last
     // location value
+    log.info("Loaded Last location: {}", lastLocation);

Review Comment:
   Yep, I forgot to take this out, I will remove it.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@accumulo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org