You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@giraph.apache.org by "Zhiwei Gu (Created) (JIRA)" <ji...@apache.org> on 2011/10/19 03:29:10 UTC
[jira] [Created] (GIRAPH-59) test is debug enabled before
LOG.debug(), so as for LOG.info()
test is debug enabled before LOG.debug(), so as for LOG.info()
--------------------------------------------------------------
Key: GIRAPH-59
URL: https://issues.apache.org/jira/browse/GIRAPH-59
Project: Giraph
Issue Type: Bug
Reporter: Zhiwei Gu
Assignee: Zhiwei Gu
Priority: Minor
For example: src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
in putMsgList(),
LOG.debug("putMsgList: Adding msgList " + msgList +
" on vertex " + vertex);
should be:
if (LOG.isDebugEnabled()) {
LOG.debug("putMsgList: Adding msgList " + msgList +
" on vertex " + vertex);
}
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (GIRAPH-59) test is debug enabled before
LOG.debug(), so as for LOG.info()
Posted by "Avery Ching (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Avery Ching resolved GIRAPH-59.
-------------------------------
Resolution: Fixed
Made a few small changes (line wrap, double if in one case), but otherwise mostly committed intact.
> test is debug enabled before LOG.debug(), so as for LOG.info()
> --------------------------------------------------------------
>
> Key: GIRAPH-59
> URL: https://issues.apache.org/jira/browse/GIRAPH-59
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.70.0
> Reporter: Zhiwei Gu
> Assignee: Zhiwei Gu
> Priority: Minor
> Fix For: 0.70.0
>
> Attachments: GIRAPH-59.patch
>
>
> For example: src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
> in putMsgList(),
> LOG.debug("putMsgList: Adding msgList " + msgList +
> " on vertex " + vertex);
> should be:
> if (LOG.isDebugEnabled()) {
> LOG.debug("putMsgList: Adding msgList " + msgList +
> " on vertex " + vertex);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-59) test is debug enabled before
LOG.debug(), so as for LOG.info()
Posted by "Avery Ching (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130327#comment-13130327 ]
Avery Ching commented on GIRAPH-59:
-----------------------------------
+1, thanks Zhiwei. I will commit on your behalf.
> test is debug enabled before LOG.debug(), so as for LOG.info()
> --------------------------------------------------------------
>
> Key: GIRAPH-59
> URL: https://issues.apache.org/jira/browse/GIRAPH-59
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.70.0
> Reporter: Zhiwei Gu
> Assignee: Zhiwei Gu
> Priority: Minor
> Fix For: 0.70.0
>
> Attachments: GIRAPH-59.patch
>
>
> For example: src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
> in putMsgList(),
> LOG.debug("putMsgList: Adding msgList " + msgList +
> " on vertex " + vertex);
> should be:
> if (LOG.isDebugEnabled()) {
> LOG.debug("putMsgList: Adding msgList " + msgList +
> " on vertex " + vertex);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (GIRAPH-59) test is debug enabled before
LOG.debug(), so as for LOG.info()
Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-59?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13130330#comment-13130330 ]
Hudson commented on GIRAPH-59:
------------------------------
Integrated in Giraph-trunk-Commit #16 (See [https://builds.apache.org/job/Giraph-trunk-Commit/16/])
GIRAPH-59: Missing some test if debug enabled before LOG.debug() and
LOG.info(). (guzhiwei via aching).
aching : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1185953
Files :
* /incubator/giraph/trunk/CHANGELOG
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimplePageRankVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SimpleSuperstepVertex.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/examples/SuperstepBalancer.java
* /incubator/giraph/trunk/src/main/java/org/apache/giraph/graph/BspServiceWorker.java
> test is debug enabled before LOG.debug(), so as for LOG.info()
> --------------------------------------------------------------
>
> Key: GIRAPH-59
> URL: https://issues.apache.org/jira/browse/GIRAPH-59
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.70.0
> Reporter: Zhiwei Gu
> Assignee: Zhiwei Gu
> Priority: Minor
> Fix For: 0.70.0
>
> Attachments: GIRAPH-59.patch
>
>
> For example: src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
> in putMsgList(),
> LOG.debug("putMsgList: Adding msgList " + msgList +
> " on vertex " + vertex);
> should be:
> if (LOG.isDebugEnabled()) {
> LOG.debug("putMsgList: Adding msgList " + msgList +
> " on vertex " + vertex);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (GIRAPH-59) test is debug enabled before
LOG.debug(), so as for LOG.info()
Posted by "Zhiwei Gu (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/GIRAPH-59?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Zhiwei Gu updated GIRAPH-59:
----------------------------
Attachment: GIRAPH-59.patch
> test is debug enabled before LOG.debug(), so as for LOG.info()
> --------------------------------------------------------------
>
> Key: GIRAPH-59
> URL: https://issues.apache.org/jira/browse/GIRAPH-59
> Project: Giraph
> Issue Type: Bug
> Affects Versions: 0.70.0
> Reporter: Zhiwei Gu
> Assignee: Zhiwei Gu
> Priority: Minor
> Fix For: 0.70.0
>
> Attachments: GIRAPH-59.patch
>
>
> For example: src/main/java/org/apache/giraph/comm/BasicRPCCommunications.java
> in putMsgList(),
> LOG.debug("putMsgList: Adding msgList " + msgList +
> " on vertex " + vertex);
> should be:
> if (LOG.isDebugEnabled()) {
> LOG.debug("putMsgList: Adding msgList " + msgList +
> " on vertex " + vertex);
> }
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira