[GitHub] [cassandra] frankgh commented on a diff in pull request #1535: CASSANDRA-17513 Adding new property to server encryption options for creating outbound keystore for internode mTLS

[GitBox <gi...@apache.org>]

frankgh commented on code in PR #1535:
URL: https://github.com/apache/cassandra/pull/1535#discussion_r865467053


##########
conf/cassandra.yaml:
##########
@@ -1251,6 +1251,8 @@ server_encryption_options:
   # Set to a valid keystore if internode_encryption is dc, rack or all
   keystore: conf/.keystore
   keystore_password: cassandra
+#  outbound_keystore: conf/.keystore
+#  outbound_keystore_password: cassandra

Review Comment:
   Can we also add a comment describing these two properties, and maybe explain that when the `outbound_keystore` is not provided, it will default to `keystore` and when `outbound_keystore_password` is not provided it will default to `keystore_password`
   ```suggestion
   #  outbound_keystore:
   #  outbound_keystore_password:
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@cassandra.apache.org
For additional commands, e-mail: pr-help@cassandra.apache.org