You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2024/02/10 23:52:57 UTC

[PR] Fix pyhive hive_pure_sasl extra name [airflow]

hussein-awala opened a new pull request, #37323:
URL: https://github.com/apache/airflow/pull/37323

   I noticed this warning in the build ci image job:
   ```
   WARNING: pyhive 0.7.0 does not provide the extra 'hive-pure-sasl'
   ```
   After checking, found that the correct name of this extra was always `hive_pure_sasl`: https://github.com/dropbox/PyHive/pull/454


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix pyhive hive_pure_sasl extra name [airflow]

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.

hussein-awala commented on PR #37323:
URL: https://github.com/apache/airflow/pull/37323#issuecomment-1937358184

   it was added with correct name by https://github.com/apache/airflow/pull/32607


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix pyhive hive_pure_sasl extra name [airflow]

Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.

hussein-awala commented on PR #37323:
URL: https://github.com/apache/airflow/pull/37323#issuecomment-1937358952

   it was changed to the wrong name I think by mistake by https://github.com/apache/airflow/pull/36537
   
   cc: @potiuk 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix pyhive hive_pure_sasl extra name [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk merged PR #37323:
URL: https://github.com/apache/airflow/pull/37323


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix pyhive hive_pure_sasl extra name [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk commented on PR #37323:
URL: https://github.com/apache/airflow/pull/37323#issuecomment-1937385826

   Not really. That was deliberate and it is there to follow https://peps.python.org/pep-0685/ . Any (conforming) package installer should normalize the extras when comparing them to `re.sub(r"[-_.]+", "-", name).lower()` - so I pre-normalized all our extras to follow that, so that we are compliant with extras "after normalization". 
   
   I believed there is (wrong) warning that the extra does not exist when it is used, but the extra is actually used (or so I thought). But I just checked it and indeed it seems that PEP-0685 for that case is not yet implemented by `pip`. @uranusjr ? 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix pyhive hive_pure_sasl extra name [airflow]

Posted by "potiuk (via GitHub)" <gi...@apache.org>.

potiuk commented on PR #37323:
URL: https://github.com/apache/airflow/pull/37323#issuecomment-1937497729

   Yeah, this is simply manifestation of unfinished https://github.com/pypa/pip/issues/11445 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org