[jira] [Commented] (DELTASPIKE-255) base class for extensions

["Romain Manni-Bucau (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DELTASPIKE-255?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13425850#comment-13425850 ] 

Romain Manni-Bucau commented on DELTASPIKE-255:
-----------------------------------------------

If we want something like that maybe DS extensions shouldn't be cdi extensions...seems weird but more logical. This way the on/off mode is easy to manage.

maybe we should discuss about it, no?
                
> base class for extensions
> -------------------------
>
>                 Key: DELTASPIKE-255
>                 URL: https://issues.apache.org/jira/browse/DELTASPIKE-255
>             Project: DeltaSpike
>          Issue Type: Improvement
>          Components: Core
>    Affects Versions: 0.3-incubating
>            Reporter: Gerhard Petracek
>            Assignee: Gerhard Petracek
>             Fix For: 0.4-incubating
>
>
> in myfaces codi we have
>     /**
>      * Returns if the current instance is active or not.
>      *
>      * @return true if the current instance is active, false otherwise
>      */
>     boolean isActivated();
> in Deactivatable to keep it more obvious where the logic for the de-/activation is located.
> in deltaspike we don't have this method any longer, but we could use an abstract class which contains our generic observer implementation - instead of c&p
>     protected void init(@Observes BeforeBeanDiscovery beforeBeanDiscovery)
>     {
>         isActivated = ClassDeactivationUtils.isActivated(getClass());
>     }
> for every extension.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira