You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Darrel Schneider <ds...@pivotal.io> on 2016/10/28 17:24:36 UTC
Review Request 53268: GEODE-2043: change makeTombstone to handle
exception
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53268/
-----------------------------------------------------------
Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken Howe.
Bugs: GEODE-2043
https://issues.apache.org/jira/browse/GEODE-2043
Repository: geode
Description
-------
Now if makeTombstone has an exception but had already changed
the region entry value to a TOMBSTONE, it will now change
the value to REMOVE_PHASE2 instead of leaving it as a TOMBSTONE.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionEntry.java 4e1f0aad533b1eba1223ff67fdf6656d7e1d4050
geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionEntryTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/53268/diff/
Testing
-------
precheckin and hydra test that was failing.
Thanks,
Darrel Schneider
Re: Review Request 53268: GEODE-2043: change makeTombstone to handle
exception
Posted by Eric Shu <es...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53268/#review154140
-----------------------------------------------------------
Ship it!
Ship It!
- Eric Shu
On Oct. 28, 2016, 5:24 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53268/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2016, 5:24 p.m.)
>
>
> Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken Howe.
>
>
> Bugs: GEODE-2043
> https://issues.apache.org/jira/browse/GEODE-2043
>
>
> Repository: geode
>
>
> Description
> -------
>
> Now if makeTombstone has an exception but had already changed
> the region entry value to a TOMBSTONE, it will now change
> the value to REMOVE_PHASE2 instead of leaving it as a TOMBSTONE.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionEntry.java 4e1f0aad533b1eba1223ff67fdf6656d7e1d4050
> geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionEntryTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53268/diff/
>
>
> Testing
> -------
>
> precheckin and hydra test that was failing.
>
>
> Thanks,
>
> Darrel Schneider
>
>
Re: Review Request 53268: GEODE-2043: change makeTombstone to handle
exception
Posted by Ken Howe <kh...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/53268/#review154141
-----------------------------------------------------------
Ship it!
Ship It!
- Ken Howe
On Oct. 28, 2016, 5:24 p.m., Darrel Schneider wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/53268/
> -----------------------------------------------------------
>
> (Updated Oct. 28, 2016, 5:24 p.m.)
>
>
> Review request for geode, anilkumar gingade, Eric Shu, Scott Jewell, and Ken Howe.
>
>
> Bugs: GEODE-2043
> https://issues.apache.org/jira/browse/GEODE-2043
>
>
> Repository: geode
>
>
> Description
> -------
>
> Now if makeTombstone has an exception but had already changed
> the region entry value to a TOMBSTONE, it will now change
> the value to REMOVE_PHASE2 instead of leaving it as a TOMBSTONE.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/AbstractRegionEntry.java 4e1f0aad533b1eba1223ff67fdf6656d7e1d4050
> geode-core/src/test/java/org/apache/geode/internal/cache/AbstractRegionEntryTest.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/53268/diff/
>
>
> Testing
> -------
>
> precheckin and hydra test that was failing.
>
>
> Thanks,
>
> Darrel Schneider
>
>