You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2019/12/20 14:00:28 UTC
[GitHub] [spark] cloud-fan opened a new pull request #26968: [SQL][minor]
update the final plan in UI for AQE
cloud-fan opened a new pull request #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
a followup of https://github.com/apache/spark/pull/26576, which mistakenly removes the UI update of the final plan.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
fix mistake.
### Does this PR introduce any user-facing change?
<!--
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If no, write 'No'.
-->
no
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
existing tests
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26968: [SQL][minor]
update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-568022157
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26968:
[SQL][minor] update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-567937986
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20423/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26968: [SQL][minor]
update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-567937986
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/20423/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] manuzhang commented on a change in pull request #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
manuzhang commented on a change in pull request #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#discussion_r360800463
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -205,6 +205,7 @@ case class AdaptiveSparkPlanExec(
// Run the final plan when there's no more unfinished stages.
currentPhysicalPlan = applyPhysicalRules(result.newPlan, queryStageOptimizerRules)
+ executionId.foreach(onUpdatePlan)
Review comment:
The root nodes of `Physical Plan` in `physicalPlanDescription`s are different: `AdaptiveSparkPlan(isFinalPlan=true)` vs `AdaptiveSparkPlan(isFinalPlan=false)`. So are root nodes of `sparkPlan`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26968: [SQL][minor] update the
final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-568021159
**[Test build #115624 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115624/testReport)** for PR 26968 at commit [`566918c`](https://github.com/apache/spark/commit/566918cec3e8c1051d602376bc30fbfcea460b3b).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] manuzhang commented on a change in pull request #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
manuzhang commented on a change in pull request #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#discussion_r360823766
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -205,6 +205,7 @@ case class AdaptiveSparkPlanExec(
// Run the final plan when there's no more unfinished stages.
currentPhysicalPlan = applyPhysicalRules(result.newPlan, queryStageOptimizerRules)
+ executionId.foreach(onUpdatePlan)
Review comment:
I've sent https://github.com/apache/spark/pull/26983. Please review.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26968: [SQL][minor]
update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-568022162
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115624/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#discussion_r360790661
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -205,6 +205,7 @@ case class AdaptiveSparkPlanExec(
// Run the final plan when there's no more unfinished stages.
currentPhysicalPlan = applyPhysicalRules(result.newPlan, queryStageOptimizerRules)
+ executionId.foreach(onUpdatePlan)
Review comment:
It doesn't matter. `onUpdatePlan` only look at `currentPhysicalPlan`, so we must call `onUpdatePlan` after setting `currentPhysicalPlan`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26968:
[SQL][minor] update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-568022157
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] JkSelf commented on issue #26968: [SQL][minor] update the
final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
JkSelf commented on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-568128085
LGTM. Thanks
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on issue #26968: [SQL][minor]
update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-567936319
**[Test build #115624 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115624/testReport)** for PR 26968 at commit [`566918c`](https://github.com/apache/spark/commit/566918cec3e8c1051d602376bc30fbfcea460b3b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-568347435
unfortunately we don't have a good test framework for UI. It would be great if we have one.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26968:
[SQL][minor] update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-568022162
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/115624/
Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] manuzhang commented on a change in pull request #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
manuzhang commented on a change in pull request #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#discussion_r360810996
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -205,6 +205,7 @@ case class AdaptiveSparkPlanExec(
// Run the final plan when there's no more unfinished stages.
currentPhysicalPlan = applyPhysicalRules(result.newPlan, queryStageOptimizerRules)
+ executionId.foreach(onUpdatePlan)
Review comment:
Sure. Thanks for your reply.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#discussion_r360801607
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -205,6 +205,7 @@ case class AdaptiveSparkPlanExec(
// Run the final plan when there's no more unfinished stages.
currentPhysicalPlan = applyPhysicalRules(result.newPlan, queryStageOptimizerRules)
+ executionId.foreach(onUpdatePlan)
Review comment:
ah good catch! somehow I misread the code and thought it doesn't matter.
For UI it doesn't matter as we will strip the `AdaptiveSparkPlanExec`, but if there is a spark listener catching this event, it matters.
Can you send a PR to fix it? Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on issue #26968: [SQL][minor] update
the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-567933978
cc @maryannxue @JkSelf
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on issue #26968:
[SQL][minor] update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-567937973
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] manuzhang commented on a change in pull request #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
manuzhang commented on a change in pull request #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#discussion_r360797024
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -205,6 +205,7 @@ case class AdaptiveSparkPlanExec(
// Run the final plan when there's no more unfinished stages.
currentPhysicalPlan = applyPhysicalRules(result.newPlan, queryStageOptimizerRules)
+ executionId.foreach(onUpdatePlan)
Review comment:
Does it matter for what's displayed on UI or anyone interested in sql update event ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on issue #26968: [SQL][minor] update the
final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-567936319
**[Test build #115624 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/115624/testReport)** for PR 26968 at commit [`566918c`](https://github.com/apache/spark/commit/566918cec3e8c1051d602376bc30fbfcea460b3b).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] manuzhang commented on issue #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
manuzhang commented on issue #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-568345424
@cloud-fan Is there any UT to catch such mistake that it won't happen again ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on a change in pull request #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#discussion_r360798051
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -205,6 +205,7 @@ case class AdaptiveSparkPlanExec(
// Run the final plan when there's no more unfinished stages.
currentPhysicalPlan = applyPhysicalRules(result.newPlan, queryStageOptimizerRules)
+ executionId.foreach(onUpdatePlan)
Review comment:
what do you mean? Even if you move `isFinalPlan = true` before this line, nothing gets changed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on issue #26968: [SQL][minor]
update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on issue #26968: [SQL][minor] update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#issuecomment-567937973
Merged build finished. Test PASSed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] manuzhang commented on a change in pull request #26968:
[SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
Posted by GitBox <gi...@apache.org>.
manuzhang commented on a change in pull request #26968: [SPARK-29906][SQL][FOLLOWUP] Update the final plan in UI for AQE
URL: https://github.com/apache/spark/pull/26968#discussion_r360790195
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala
##########
@@ -205,6 +205,7 @@ case class AdaptiveSparkPlanExec(
// Run the final plan when there's no more unfinished stages.
currentPhysicalPlan = applyPhysicalRules(result.newPlan, queryStageOptimizerRules)
+ executionId.foreach(onUpdatePlan)
Review comment:
Why is the plan sent out before `isFinalPlan = true` ? Isn't it the final plan ?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org