You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@harmony.apache.org by "Ilya Berezhniuk (JIRA)" <ji...@apache.org> on 2008/03/14 17:22:24 UTC
[jira] Created: (HARMONY-5606) [drlvm][port] Make Port shared
library
[drlvm][port] Make Port shared library
--------------------------------------
Key: HARMONY-5606
URL: https://issues.apache.org/jira/browse/HARMONY-5606
Project: Harmony
Issue Type: Sub-task
Reporter: Ilya Berezhniuk
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5606) [drlvm][port] Make Port shared
library
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5606:
-------------------------------------
Attachment: 0002-Make-Port-Crash-Signal-Handler-shared-v3-02-patch.patch
0001-Make-Port-Crash-Signal-Handler-shared-v3-01-move.patch
Here are the updated "v3" patches to fix the problem with hythread dependency from crash handler, and CH dependency from APR.
Some CH restructuring was made, and now CH gets only 1 function from the rest of Port at compile time, and fully independent from APR.
The tests are passed for me on 5 platforms with clean rebuild.
1st patch is for moved files as usual; 2nd patch is the actual patch.
> [drlvm][port] Make Port shared library
> --------------------------------------
>
> Key: HARMONY-5606
> URL: https://issues.apache.org/jira/browse/HARMONY-5606
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: 0001-Make-Port-Crash-Signal-Handler-shared-v3-01-move.patch, 0001-Make-Port-Crash-Signal-Handler-shared.patch, 0001-Make-Port-shared.patch, 0002-Make-Port-Crash-Signal-Handler-shared-v3-02-patch.patch
>
>
> DRLVM Portlib should become shared library.
> It's needed at least for avoiding multiple instances of Portlib static variables.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5606) [drlvm][port] Make Port shared
library
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5606:
-------------------------------------
Attachment: 0001-Make-Port-shared.patch
Here is the patch which makes Port shared library.
The Port library also provides APR and log4cxx functionality to other components.
This patch is checked on Linux only for now, but AFAIK Linux is now more tough on linkage.
On the other hand, this approach does not allow inlining of several performance-critical functions like atomics and apr_palloc.
Now I'm working on another approach with splitting Port on 2 libraries: shared Crash Handler library, and static library providing the rest of functionality.
Such approach allows keeping a possibility for inlining, and seems to fit all crash handler requirements.
> [drlvm][port] Make Port shared library
> --------------------------------------
>
> Key: HARMONY-5606
> URL: https://issues.apache.org/jira/browse/HARMONY-5606
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Attachments: 0001-Make-Port-shared.patch
>
>
> DRLVM Portlib should become shared library.
> It's needed at least for avoiding multiple instances of Portlib static variables.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5606) [drlvm][port] Make Port shared
library
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5606:
-------------------------------------
Component/s: DRLVM
Estimated Complexity: Moderate
Description:
DRLVM Portlib should become shared library.
It's needed at least for avoiding multiple instances of Portlib static variables.
> [drlvm][port] Make Port shared library
> --------------------------------------
>
> Key: HARMONY-5606
> URL: https://issues.apache.org/jira/browse/HARMONY-5606
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Ilya Berezhniuk
>
> DRLVM Portlib should become shared library.
> It's needed at least for avoiding multiple instances of Portlib static variables.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5606) [drlvm][port] Make Port shared
library
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5606:
-------------------------------------
Patch Info: [Patch Available]
> [drlvm][port] Make Port shared library
> --------------------------------------
>
> Key: HARMONY-5606
> URL: https://issues.apache.org/jira/browse/HARMONY-5606
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Attachments: 0001-Make-Port-Crash-Signal-Handler-shared.patch, 0001-Make-Port-shared.patch
>
>
> DRLVM Portlib should become shared library.
> It's needed at least for avoiding multiple instances of Portlib static variables.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (HARMONY-5606) [drlvm][port] Make Crash Handler
shared library
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky resolved HARMONY-5606.
----------------------------------------
Resolution: Fixed
Fix Version/s: 5.0M6
Changes are applied at 639339. Please check that they were made as expected.
> [drlvm][port] Make Crash Handler shared library
> -----------------------------------------------
>
> Key: HARMONY-5606
> URL: https://issues.apache.org/jira/browse/HARMONY-5606
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Fix For: 5.0M6
>
> Attachments: 0001-Make-Port-Crash-Signal-Handler-shared-v3-01-move.patch, 0001-Make-Port-Crash-Signal-Handler-shared.patch, 0001-Make-Port-shared.patch, 0002-Make-Port-Crash-Signal-Handler-shared-v3-02-patch.patch
>
>
> DRLVM Portlib should become shared library.
> It's needed at least for avoiding multiple instances of Portlib static variables.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5606) [drlvm][port] Make Crash Handler
shared library
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5606:
-------------------------------------
Estimated Complexity: Advanced (was: Moderate)
Summary: [drlvm][port] Make Crash Handler shared library (was: [drlvm][port] Make Port shared library)
> [drlvm][port] Make Crash Handler shared library
> -----------------------------------------------
>
> Key: HARMONY-5606
> URL: https://issues.apache.org/jira/browse/HARMONY-5606
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: 0001-Make-Port-Crash-Signal-Handler-shared-v3-01-move.patch, 0001-Make-Port-Crash-Signal-Handler-shared.patch, 0001-Make-Port-shared.patch, 0002-Make-Port-Crash-Signal-Handler-shared-v3-02-patch.patch
>
>
> DRLVM Portlib should become shared library.
> It's needed at least for avoiding multiple instances of Portlib static variables.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (HARMONY-5606) [drlvm][port] Make Port shared
library
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk updated HARMONY-5606:
-------------------------------------
Attachment: 0001-Make-Port-Crash-Signal-Handler-shared.patch
Attaching the patch for new approach (0001-Make-Port-Crash-Signal-Handler-shared.patch).
It works fine, and most part of port library is still static, so there should be no performance issues.
> [drlvm][port] Make Port shared library
> --------------------------------------
>
> Key: HARMONY-5606
> URL: https://issues.apache.org/jira/browse/HARMONY-5606
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Attachments: 0001-Make-Port-Crash-Signal-Handler-shared.patch, 0001-Make-Port-shared.patch
>
>
> DRLVM Portlib should become shared library.
> It's needed at least for avoiding multiple instances of Portlib static variables.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (HARMONY-5606) [drlvm][port] Make Crash Handler
shared library
Posted by "Ilya Berezhniuk (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ilya Berezhniuk closed HARMONY-5606.
------------------------------------
Thanks Gregory!
I've checked, the patch is applied correctly.
> [drlvm][port] Make Crash Handler shared library
> -----------------------------------------------
>
> Key: HARMONY-5606
> URL: https://issues.apache.org/jira/browse/HARMONY-5606
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Fix For: 5.0M6
>
> Attachments: 0001-Make-Port-Crash-Signal-Handler-shared-v3-01-move.patch, 0001-Make-Port-Crash-Signal-Handler-shared.patch, 0001-Make-Port-shared.patch, 0002-Make-Port-Crash-Signal-Handler-shared-v3-02-patch.patch
>
>
> DRLVM Portlib should become shared library.
> It's needed at least for avoiding multiple instances of Portlib static variables.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (HARMONY-5606) [drlvm][port] Make Port shared
library
Posted by "Gregory Shimansky (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HARMONY-5606?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gregory Shimansky reassigned HARMONY-5606:
------------------------------------------
Assignee: Gregory Shimansky
> [drlvm][port] Make Port shared library
> --------------------------------------
>
> Key: HARMONY-5606
> URL: https://issues.apache.org/jira/browse/HARMONY-5606
> Project: Harmony
> Issue Type: Sub-task
> Components: DRLVM
> Reporter: Ilya Berezhniuk
> Assignee: Gregory Shimansky
> Attachments: 0001-Make-Port-Crash-Signal-Handler-shared.patch, 0001-Make-Port-shared.patch
>
>
> DRLVM Portlib should become shared library.
> It's needed at least for avoiding multiple instances of Portlib static variables.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.