You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by Graham Leggett <mi...@sharp.fm> on 2001/09/20 11:05:49 UTC

Re: cvs commit: httpd-proxy/module-2.0 CHANGES mod_proxy.c mod_proxy.h proxy_http.c

ianh@apache.org wrote:

>   Added New Option 'HTTPProxyOverrideReturnedErrors' which lets the server override
>   the error pages returned from the proxied server and replace them with the standard
>   server error handling on the main server.

I don't like the name of the option - it should start with Proxy* in
order to be consistent with the other options.

Something like "ProxyErrorOverride"?

Is there a reason this option doesn't also work with FTP? (Admittedly I
haven't looked at the ftp code for a while, I'm not sure if it would
make sense, but for consistency I think it should work for both).

Regards,
Graham
-- 
-----------------------------------------
minfrin@sharp.fm		"There's a moon
					over Bourbon Street
						tonight..."

Re: cvs commit: httpd-proxy/module-2.0 CHANGES mod_proxy.c mod_pr oxy.h proxy_http.c

Posted by Ian Holsman <ia...@cnet.com>.
On Thu, 2001-09-20 at 02:05, Graham Leggett wrote:
> ianh@apache.org wrote:
> 
> >   Added New Option 'HTTPProxyOverrideReturnedErrors' which lets the
> server override
> >   the error pages returned from the proxied server and replace them
> with the standard
> >   server error handling on the main server.
> 
> I don't like the name of the option - it should start with Proxy* in
> order to be consistent with the other options.
> 
> Something like "ProxyErrorOverride"?
> 
> Is there a reason this option doesn't also work with FTP? (Admittedly I
> haven't looked at the ftp code for a while, I'm not sure if it would
> make sense, but for consistency I think it should work for both).
I'm not sure how the FTP error handling works, and how the HTTP server
would handle the error mapping to HTTP codes. so I'm not sure if it is
applicable.

The option should be setup/configured I guess in the proxy_http.c code
but I'm not sure how that will work with all the other config stuff.

> 
> Regards,
> Graham
> -- 
> -----------------------------------------
> minfrin@sharp.fm		"There's a moon
> 					over Bourbon Street
> 						tonight..."
-- 
Ian Holsman          IanH@cnet.com
Performance Measurement & Analysis
CNET Networks   -   (415) 364-8608


Re: cvs commit: httpd-proxy/module-2.0 CHANGES mod_proxy.c mod_pr oxy.h proxy_http.c

Posted by Ian Holsman <ia...@cnet.com>.
On Thu, 2001-09-20 at 02:05, Graham Leggett wrote:
> ianh@apache.org wrote:
> 
> >   Added New Option 'HTTPProxyOverrideReturnedErrors' which lets the
> server override
> >   the error pages returned from the proxied server and replace them
> with the standard
> >   server error handling on the main server.
> 
> I don't like the name of the option - it should start with Proxy* in
> order to be consistent with the other options.
> 
> Something like "ProxyErrorOverride"?
> 
> Is there a reason this option doesn't also work with FTP? (Admittedly I
> haven't looked at the ftp code for a while, I'm not sure if it would
> make sense, but for consistency I think it should work for both).
I'm not sure how the FTP error handling works, and how the HTTP server
would handle the error mapping to HTTP codes. so I'm not sure if it is
applicable.

The option should be setup/configured I guess in the proxy_http.c code
but I'm not sure how that will work with all the other config stuff.

> 
> Regards,
> Graham
> -- 
> -----------------------------------------
> minfrin@sharp.fm		"There's a moon
> 					over Bourbon Street
> 						tonight..."
-- 
Ian Holsman          IanH@cnet.com
Performance Measurement & Analysis
CNET Networks   -   (415) 364-8608