[GitHub] [felix-atomos] HannesWell commented on a diff in pull request #70: add handling for running build on Windows

["HannesWell (via GitHub)" <gi...@apache.org>]

HannesWell commented on code in PR #70:
URL: https://github.com/apache/felix-atomos/pull/70#discussion_r1145887674


##########
atomos.utils/atomos.utils.substrate.impl/src/main/java/org/apache/felix/atomos/utils/substrate/impl/NativeImageArgumentsImpl.java:
##########
@@ -121,7 +121,7 @@ public List<String> arguments()
             .map(Path::toAbsolutePath)//
             .sorted(NativeImageArgumentsImpl::byAbsolutePath)//
             .map(Path::toString)//
-            .collect(Collectors.joining(":"));
+            .collect(Collectors.joining(NativeImageCliUtil.isWindows() ? ";" : ":"));

Review Comment:
   Just stumbled upon this and thought that `File.pathSeparator` should already have the distinction between windows and unix build in.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@felix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org