[GitHub] [bookkeeper] Apurva007 commented on a diff in pull request #3914: [Bug] Fix internal server error when GC is triggered with forcemajor or forceminor flags

["Apurva007 (via GitHub)" <gi...@apache.org>]

Apurva007 commented on code in PR #3914:
URL: https://github.com/apache/bookkeeper/pull/3914#discussion_r1164892084


##########
bookkeeper-server/src/main/java/org/apache/bookkeeper/server/http/service/TriggerGCService.java:
##########
@@ -68,9 +68,9 @@ public HttpServiceResponse handle(HttpServiceRequest request) throws Exception {
                 bookieServer.getBookie().getLedgerStorage().forceGC();
             } else {
                 @SuppressWarnings("unchecked")
-                Map<String, Object> configMap = JsonUtil.fromJson(requestBody, HashMap.class);
-                Boolean forceMajor = (Boolean) configMap.getOrDefault("forceMajor", null);
-                Boolean forceMinor = (Boolean) configMap.getOrDefault("forceMinor", null);
+                Map<String, String> configMap = JsonUtil.fromJson(requestBody, HashMap.class);

Review Comment:
   @hangc0276 Thanks for the review. I will add the respective tests.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org