[GitHub] [superset] michellethomas commented on a change in pull request #12529: fix: Update Limit Control with SQL_ROW_MAX value

[GitBox <gi...@apache.org>]

michellethomas commented on a change in pull request #12529:
URL: https://github.com/apache/superset/pull/12529#discussion_r557797715



##########
File path: superset-frontend/src/SqlLab/components/SqlEditor.jsx
##########
@@ -539,7 +539,15 @@ class SqlEditor extends React.PureComponent {
   }
 
   renderQueryLimit() {
-    const menuDropdown = (
+    // Update the limit dropdown with SQL_ROW_MAX value
+    const { maxRow } = this.props;

Review comment:
       It looks like this limit control is getting applied to the UI results and to CSV export. Our main concern is with CSV export so that's why I mentioned the `SQL_ROW_MAX`. If I run a query with a limit 10 in the UI dropdown (with no limit in the query) and run it then download csv I get only 10 rows in the CSV. It sounds like this is the same as the old functionality for the limit UI control to affect the csv and the UI results. I wasn't aware that changed, but if there's some other setting we need to make the UI limit only apply to the ui results let me know.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org