You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/10/27 13:22:09 UTC

[GitHub] [arrow] bkietz commented on pull request #8533: ARROW-10080: [R] Call gc() and try again in MemoryPool

bkietz commented on pull request #8533:
URL: https://github.com/apache/arrow/pull/8533#issuecomment-717239034


   I've replace explicit calls to `arrow::default_memory_pool()` with `gc_memory_pool()` to pick up this change. However there are many Arrow APIs which don't require an explicit `MemoryPool` and will invoke `arrow::default_memory_pool()` if none is provided. The leak will persist if we fail to identify one of these and keep the default memory pool. I've fixed two implicit default pool usages: [`dataset___Dataset__NewScan`](https://github.com/apache/arrow/pull/8533/files#diff-5a95c2439a17adb8dec5e2f4760b6f632da493a24b2a85f2e00368fa982dcca9R34-R39) and [`compute__CallFunction`](https://github.com/apache/arrow/pull/8533/files#diff-a138b87f0da58d824c72293eab62d9f352718dcb7f41a47ea7e1c3c84bbe27ddR179-R186). I'll look for others but please call out any I miss


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org